From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tobias Gerdin Newsgroups: gmane.emacs.bugs Subject: bug#32029: PATCH: xref-find-definitions-at-mouse Date: Mon, 2 Jul 2018 01:18:50 +0200 Message-ID: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1530489012 14401 195.159.176.226 (1 Jul 2018 23:50:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Jul 2018 23:50:12 +0000 (UTC) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 To: 32029@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 02 01:50:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZm6U-0003Xj-OF for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Jul 2018 01:50:02 +0200 Original-Received: from localhost ([::1]:56008 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZm8b-0001Zd-Py for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 19:52:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZm8T-0001YS-NR for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:52:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZm8Q-0006a1-KL for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34565) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZm8Q-0006Zu-FI for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fZm8P-0003W6-WB for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tobias Gerdin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jul 2018 23:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32029 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.153048911113500 (code B ref -1); Sun, 01 Jul 2018 23:52:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Jul 2018 23:51:51 +0000 Original-Received: from localhost ([127.0.0.1]:42462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZm8E-0003Vf-OK for submit@debbugs.gnu.org; Sun, 01 Jul 2018 19:51:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZlcZ-0002mF-Bx for submit@debbugs.gnu.org; Sun, 01 Jul 2018 19:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZlcT-0004aX-6L for submit@debbugs.gnu.org; Sun, 01 Jul 2018 19:19:02 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:55005) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fZlcT-0004aQ-2Y for submit@debbugs.gnu.org; Sun, 01 Jul 2018 19:19:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZlcR-0004rP-TI for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:19:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZlcM-0004Xw-VV for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:18:59 -0400 Original-Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:36599) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZlcM-0004XB-N5 for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:18:54 -0400 Original-Received: by mail-lf0-x229.google.com with SMTP id n24-v6so10576913lfh.3 for ; Sun, 01 Jul 2018 16:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=V1kmihtEHTw3k2xrET5iVAaMfeGKyUxm+7wl4gtJKO0=; b=uog1UfXE0rsFpgkFgo5GBISNKsDhrU8oVqxZQ/MhlcXHsGbzyKgRsosLOPpCautHOz +kDVwVFa8a0DXgrQ+LpiWJFWIrZpFG+afr3CoFaPodmOGMZRpp++JoibyPIKOptxXkzf k7zQOYY5CAwclpeIxF9+r8XTUXuWAQJIBXEa5iKNtEVr64l5uxEQNtCeFNYY2l5PWvOZ eglulYyOabnNjgbBXKmcpbkiQowZAxPA2Kcy1ly2E0g+WGW9jOFQiWQ/LcEoEdsYjZEZ I1ZsuT+GeM7EsVpU6PMSduegxTZX4pB2sYKW9MNk3YqdY8ojCASlQddcyjdYj2HvrnB5 Uv2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=V1kmihtEHTw3k2xrET5iVAaMfeGKyUxm+7wl4gtJKO0=; b=H+YAE3OftpIy7hVzQ05x/sEJ2+FKIU+4k7UPk9PPZtve6nCGlayVhxu47Un8FEfTak qIkh/lksIubTXFP82coysqGLguj2RqgocS9yVJzs86cvK0M1NsRcLBet54MRqg63OJOT DWKvIw3hh7prGwwDtJ8itI4sBhSdMqCkYvuucPLxcrrrXYcSSwiB0g3FyocjFR00SU3W NcM3H2WWDsE/MVdTx5M1vBwwlPvLMETWfYtmSDfdFSl7irS5BjPFHiHPPAW65hFu8ARA whtoXOdOiNb8l1sUthf2/XEj8Wgq3DuJfVG4UfcZmcbTCdrGrwxJgqwOibtGeH001EA9 nQdQ== X-Gm-Message-State: APt69E1hH8Np3jServSO/jl1gmxAf0CVELBDHLZ1mZ74LMAZEik+vLkR a/RaAzxMgQCtws+KBrb19JL1MyX5 X-Google-Smtp-Source: AAOMgpcXFKP7l9J6UoAOBxhWPVzt8LfjskaeW6t+MCpoVGsCIjgvbCvtIknMkgs4yB/oFMfxlOE6HA== X-Received: by 2002:a19:d313:: with SMTP id k19-v6mr7633774lfg.29.1530487132712; Sun, 01 Jul 2018 16:18:52 -0700 (PDT) Original-Received: from Tobias-MBP.lan (h83-209-121-192.cust.se.alltele.net. [83.209.121.192]) by smtp.gmail.com with ESMTPSA id o34-v6sm1439181lfg.12.2018.07.01.16.18.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jul 2018 16:18:51 -0700 (PDT) Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Sun, 01 Jul 2018 19:51:49 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148068 Archived-At: Hello, I find it convenient to be able to go to definitions using the mouse (especially when getting to know new code bases). I have the below function bound to C-mouse-1 like so: (global-set-key [C-mouse-1] 'xref-find-definitions-at-mouse) (global-set-key [C-down-mouse-1] nil) I also find it convenient to be able to get back to where I was using only the mouse (enabling keyboard-free navigation): (global-set-key [C-mouse-3] 'xref-pop-marker-stack) (global-set-key [C-down-mouse-3] nil) Finding suitable default keybindings (well, "mouse bindings") is beyond the scope of this patch, but what I have above is the same binding as other popular IDEs such as IntelliJ and VS Code. Regards, Tobias Gerdin diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 9a437b6f69..85a1bc6be4 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -873,6 +873,18 @@ With prefix argument, prompt for the identifier."    (interactive (list (xref--read-identifier "Find references of: ")))    (xref--find-xrefs identifier 'references identifier nil)) +;;;###autoload +(defun xref-find-definitions-at-mouse (event) +  "Find the definition of identifier around mouse click." +  (interactive "e") +  (let* ((backend (xref-find-backend)) +     (identifier (save-excursion +              (mouse-set-point event) +              (xref-backend-identifier-at-point backend)))) +    (if identifier +    (xref--find-definitions identifier nil) +      (user-error "No identifier here")))) +  (declare-function apropos-parse-pattern "apropos" (pattern))  ;;;###autoload