From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#55810: 28.1; No "really edit the buffer?" prompt when editing a changed file over Tramp Date: Sun, 5 Jun 2022 14:31:55 -0700 Message-ID: <9ac561e4-2131-fa3a-7bcc-be329812ec9d@gmail.com> References: <87pmjm27x9.fsf@gnus.org> <362c7432-b4ed-3ebf-7c20-109e11f4c8e8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35641"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, 55810@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 05 23:33:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxxsB-000992-BB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 23:33:23 +0200 Original-Received: from localhost ([::1]:50840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxxsA-0001AU-2L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 17:33:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxxrq-00012a-54 for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 17:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxxrp-0008DV-TJ for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 17:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nxxrp-0003XT-R1 for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 17:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2022 21:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 55810-submit@debbugs.gnu.org id=B55810.165446472713528 (code B ref 55810); Sun, 05 Jun 2022 21:33:01 +0000 Original-Received: (at 55810) by debbugs.gnu.org; 5 Jun 2022 21:32:07 +0000 Original-Received: from localhost ([127.0.0.1]:33662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxxqx-0003W8-CE for submit@debbugs.gnu.org; Sun, 05 Jun 2022 17:32:07 -0400 Original-Received: from mail-pf1-f181.google.com ([209.85.210.181]:39510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxxqs-0003V8-9A for 55810@debbugs.gnu.org; Sun, 05 Jun 2022 17:32:06 -0400 Original-Received: by mail-pf1-f181.google.com with SMTP id y196so11291140pfb.6 for <55810@debbugs.gnu.org>; Sun, 05 Jun 2022 14:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=/xCfEM4PE9QNGc3uWPQNQcanWVp6mka3LkRfkoAKqMg=; b=OgFqClDZSfs6BeOYigm/OB3TZ3GW+4GGrBaqPGP56bFl2nar8opBDXoE4ekl42WE3d FXF/jLzYOR8YkVzad+rSBBkpa3eegthkOBM4nptUVrRaZoksdSP4Ku0nwmxw58wRxMp8 ON8Om5bC6C/zYFTdn/Hhsymo2c9bhsd39YETTSukjCLYvV8A+R0C1iaQBATn9wqIAI8O dNq7WU4IkMLPx9KVf58j/3SqQxVFjYHafRbqhauUGO5mPYAz73pX4dDjihnO9bJyBg5c m++VWdO+5+sqld21HldacRON0/hjlMwlpY5WVGxxpx13QkXLNPD7VKAfH0UY6ZJhn9fo GmIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/xCfEM4PE9QNGc3uWPQNQcanWVp6mka3LkRfkoAKqMg=; b=ipeTCr9tKks4Aqcex1uwf0X/e/g1UQgboOC0/aH5cd2bBVa8sDbPrlRdcYP2L8452O YQYotL1Sa0JkA10KOS249gh+qwb6X4zNDU0MUlFolgH+YZpXSm2C5T+fGVabhpBqEbgh 5Znk2AUSHhn2mi8UqrNAOqdTVn8Tmd90A7L0KqP35E+wJAcRMjstCvVFzQAJSrAJZxce CksSe3UT2ZmPgKJOTGLLT/GfIE10wigUUvhoV9EKabhJ+mqMZDWEsgX7CKxv9NdO1Wmz MIKuNI9/69MmS3hUJVTk1pHV8Bvm3AWlDTCBHjJRhsyPjph+d6vpTOWPbpyeNNDj+ky0 VOlQ== X-Gm-Message-State: AOAM533Q1fVTPlc5SbxK/2wwW4SpmlSl72Wi2pXbV6hu3rejvWzAc7DE IVjIZbrtu10kjjp2Q/O/2kg= X-Google-Smtp-Source: ABdhPJyh+PHOx6jLFxAcCA0WoYO9gk+ffpaffFsqQfKhIQz7W4Am4nIMvJsReBjTdMt/uNx+NJUo1A== X-Received: by 2002:a62:798b:0:b0:51b:a8fd:a459 with SMTP id u133-20020a62798b000000b0051ba8fda459mr26635229pfc.37.1654464716426; Sun, 05 Jun 2022 14:31:56 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id cj10-20020a056a00298a00b0051bd72bb2e6sm6124284pfb.197.2022.06.05.14.31.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jun 2022 14:31:56 -0700 (PDT) In-Reply-To: <362c7432-b4ed-3ebf-7c20-109e11f4c8e8@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233754 Archived-At: On 6/5/2022 1:25 PM, Jim Porter wrote: > On 6/5/2022 1:04 PM, Lars Ingebrigtsen wrote: >> I can reproduce this in Emacs 28.1, but not on the emacs-28 branch >> (i.e., what will become Emacs 28.2).  Would it be possible for you to >> test with that branch? > > You're right, it looks like this is also fixed on the emacs-28 branch. > I'll try to bisect this (if only so that I write some defadvice to fix > it temporarily for 28.1) and report back if I find anything useful. Ok, the commit that fixed this is 93974198b62bea0350be503c8fc017e9d1a4542f, which is just a fixup commit after 009e88e002333b4090b021d24390c9137e5a2555. That commit updates Tramp to 2.5.3-pre, so I guess it was just a bug in the Tramp that shipped with 28.1. However, I came across an interesting wrinkle. This is actually fixed in the GNU ELPA version of Tramp (currently 2.5.2.5). Installing this in Emacs 28.1 doesn't work correctly though, since v2.5.2.5 is "less" than the built-in Tramp version (v2.5.2.28.1). That explains why updating Tramp from GNU ELPA fixed the issue for me until I restarted Emacs. It loaded the fixed code temporarily, but then after restart, it chose the unfixed code because package.el thinks the built-in version is newer. CC'ing Michael here. Maybe the easy solution is just to bump the GNU ELPA version of Tramp to 2.5.3 or something, and then package.el will recognize it as newer than what ships with 28.1. For now, I have a workaround at least: I can just override the `load-path' to point to the newer Tramp version.