From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#31946: 27.0.50; The NSM should warn about more TLS problems Date: Tue, 27 Aug 2019 16:25:58 +0100 Message-ID: <9a970e22-093f-0a8c-2457-121af0edda35@gmail.com> References: <87h8647de5.fsf@gnus.org> <86tva4dq8h.fsf@gmail.com> <83k1azgbbi.fsf@gnu.org> <86zhjvrfbp.fsf@gmail.com> <83blwbg5i2.fsf@gnu.org> <86tva3rdpv.fsf@gmail.com> <834l23g1mg.fsf@gnu.org> <86d0grfse1.fsf@gmail.com> <83tva3dqb8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188122"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: 31946@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 27 17:39:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2dZ1-000mjY-Fo for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2019 17:39:19 +0200 Original-Received: from localhost ([::1]:52926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2dZ0-00034K-3j for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2019 11:39:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51689) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2dN9-0006yO-0a for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 11:27:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2dN7-0001uG-Tp for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 11:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40513) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2dN7-0001u8-Q0 for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 11:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2dN7-0003u6-L1 for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 11:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2019 15:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security fixed Original-Received: via spool by 31946-submit@debbugs.gnu.org id=B31946.156691957414950 (code B ref 31946); Tue, 27 Aug 2019 15:27:01 +0000 Original-Received: (at 31946) by debbugs.gnu.org; 27 Aug 2019 15:26:14 +0000 Original-Received: from localhost ([127.0.0.1]:49334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2dMM-0003t3-10 for submit@debbugs.gnu.org; Tue, 27 Aug 2019 11:26:14 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:38638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2dMJ-0003sp-Gf for 31946@debbugs.gnu.org; Tue, 27 Aug 2019 11:26:11 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id e16so2150731wro.5 for <31946@debbugs.gnu.org>; Tue, 27 Aug 2019 08:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DPT9XK33eE3emAdIasP7dP77CHXnc9gds3K9yt0YWHc=; b=rnmnYbd3Iphd54ZQRLcnCI/lXgfUupOZ5nLJB3oMX/2y3gtCwfcRE9iwRKzxmZ/I3l BwQ/ldJYkry868VH/L99C0VubMDLq0KWa2l0aOdhIT2DpffUDjwT9kfZakZicJEXy0Sv vGdCDDiqHBs2YkElzm0OHPFj/JgPk+n4rcBWK4WvfKkLSFydsksjGbyYXxgGWivfrYKp ifVheRLrw2ZumOU3IdLrWejrZq/iU6rDacv3krqOickOWYLEvxo5/pfaseczFPM3p2kL ZplK++S4h6fTvKFxdmkXDcm9fEBFONo5shUs65P3/3w5a6BxrSaN4klGxRQY+tsGP+dT fuEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DPT9XK33eE3emAdIasP7dP77CHXnc9gds3K9yt0YWHc=; b=TTOtZwg51ezhBO2kqyVMXyAttf44tHC9ExRIKKXuwtfqi0uAOpkPvOoGenJVEKjldN l6jAqTHu+f5bnyAcp78mpF+UUBUh4+1SmpqyMKoNu9uCb+LDHSUAlkVqJjLei6Mya6QI BGSxGj8NJUTNhHtjjk8LUVvTYIx91d3C4xFzqLSElFlpGOtxvJlxif5JJG2xQYkfSiwp vW5mlYwLPaunzcYlPyA73B5+KBEz+QbmnXJrFE53fvxEym3Ooa1ZApNk9nLw5+0V0hCt CAApzHiJkthXLh0H34VXAT2MJuC6lppce7PzSKsfgxtM/bMCaLlY0IjYWeMNqG0TPcB4 vzEQ== X-Gm-Message-State: APjAAAV9U/6KGfoTDIQP1FwuEjgqwqDRdEThRZGkBxjavjPMibwPA1dD ronrUIRJhYg+3jaeS0d9RbRVJook X-Google-Smtp-Source: APXvYqzPTDWlrPpOXYNsKrPbNoh+LBNmG0sy21t9y9W21ugDIfDnMOPrEtUw6yvMDidtgp1H8uRt7Q== X-Received: by 2002:adf:f812:: with SMTP id s18mr31983730wrp.32.1566919565016; Tue, 27 Aug 2019 08:26:05 -0700 (PDT) Original-Received: from [10.17.20.25] (uk.solarflare.com. [193.34.186.16]) by smtp.gmail.com with ESMTPSA id g7sm4258191wmh.1.2019.08.27.08.25.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Aug 2019 08:25:59 -0700 (PDT) In-Reply-To: <83tva3dqb8.fsf@gnu.org> Content-Language: en-GB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165972 Archived-At: On 27/08/2019 8:23 am, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Mon, 26 Aug 2019 23:56:06 +0100 >> >> > Looks like something is wrong with how I'm using gnutls_free when it >> > comes from the DLL. I need to look into that. >> >> Found it I think. gnutls_free is a pointer of type gnutls_free_function, >> so the value returned from GetProcAddress is a data pointer, not a >> function address. Something like the following patch appears to work >> i.e. no longer crashes with the recipe above. > > Yes, thanks. I was struggling with the same thing, but evidently > there's a limit to what I can do after 11PM at my age ;-) > >> If this is the right fix then we will need to add e.g. DEF_DLL_DATA and >> LOAD_DLL_DATA macros for runtime import of data (and an equivalent to >> get_proc_addr to use the right types for runtime data imports). > > I think there's no need to invent harness for a single user, we can > simply do that by hand. Please try the patch below, it's against the > current master (it also removes the unnecessary intermediate buffer > allocation while at that). Your patch works (tested with package-list and gnus) - please install. Thanks, AndyM