From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44294: No widen by xref-find-definitions Date: Wed, 28 Oct 2020 23:37:01 +0200 Message-ID: <9a425c29-56c5-90f4-ffbc-19bbd0643d03@yandex.ru> References: <87mu06p1aw.fsf_-_@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3131"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: Juri Linkov , 44294@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 28 22:39:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXtAJ-0000iU-UF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 22:39:31 +0100 Original-Received: from localhost ([::1]:36496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXtAI-0002Hu-WC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Oct 2020 17:39:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXt8u-0001Tl-Tz for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 17:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXt8s-0001oo-6E for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 17:38:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXt8s-0001o2-4M for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 17:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Oct 2020 21:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44294-submit@debbugs.gnu.org id=B44294.16039210316862 (code B ref 44294); Wed, 28 Oct 2020 21:38:02 +0000 Original-Received: (at 44294) by debbugs.gnu.org; 28 Oct 2020 21:37:11 +0000 Original-Received: from localhost ([127.0.0.1]:50947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXt83-0001mc-6g for submit@debbugs.gnu.org; Wed, 28 Oct 2020 17:37:11 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:46341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXt81-0001mM-U6 for 44294@debbugs.gnu.org; Wed, 28 Oct 2020 17:37:10 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id t11so960042edj.13 for <44294@debbugs.gnu.org>; Wed, 28 Oct 2020 14:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U0OmG3liBLqgo0hNooehHn77bqSJLDuvjCuxrzMxklc=; b=WwKk/vNnhs7hP9YKswVVzATjF0+EtdANnMb2b1BI23tGEZgKH5BLu3fadBjhbmko2g FK+t/QI9RAIvT39eQQ/UH9Lp7+WmysFa9cg1t706y67+dtiF2cLI2nslLQk5qVv422Gc GrL03g9RXSH9EnGlDRq6rBHoIGM3Bfj12pqktB13gSiI+u0l1BJthr9auBIlQa+UP/Wv 2rrLp36osB4UG7bCqbbTTm0R2BEQbNuWH/ZjdX52MbVDllnfIFkvArj8OgJ17NzAYfUC 6irrEPaRsSIEQmTEO2kGcwF6hRHWS98Dq2XvccOr9oJXwgW1C3CxcdRBi2PsxH7xQVrh hW4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U0OmG3liBLqgo0hNooehHn77bqSJLDuvjCuxrzMxklc=; b=DFnEM5F3lkgSSLHyOBxn+B0x+U64RVV6O9lJXv6mb40Z22zu/Nd749DF0q4e8XkOzA NsHqiXD9AAQ7zKggPuDZn0f5aGaTVT58s06KB/tWnXNGUdH6npBhC1PZl3nOQmr5pHyx N64FA6Cm89kk7NfiOoe7t5WxEvbGGomN4qaxh3UcR47rRsHFSLJvpETmf/8WlWpz6qeh I2evPpSLmjtR9SpAOm7mQ2h2DNDM24NLuPBLHRxc1vntRm1/5uYHb+AfP+h7o65cuvuf ZYy3+OVLoKnQQv+eqKb6iStTmPm1oKDWL2PtQcOYN3bk4JcuC0GvB35iKkyZCGaVaZEm ZMHg== X-Gm-Message-State: AOAM531INPM/grtG2ar7oCRmJlG2F0Gjql592m4q7oCDkEsaADA1c7o6 GtY5gu+jipMdpBiGCguF3vGizgBh7aG4WA== X-Google-Smtp-Source: ABdhPJzfSpNJUkinX5GFtHWzcOr0HOu3McUKfoZyqR2H7Hp4+JVG8lt+dWxfz+KJiqhXlJUxB8mUFQ== X-Received: by 2002:a50:fb0d:: with SMTP id d13mr952086edq.85.1603921023902; Wed, 28 Oct 2020 14:37:03 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id g20sm387106ejz.88.2020.10.28.14.37.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2020 14:37:03 -0700 (PDT) In-Reply-To: <87mu06p1aw.fsf_-_@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191923 Archived-At: On 28.10.2020 22:01, Juri Linkov wrote: > Oh, sorry, I noticed this problem is just the tip of the iceberg, > so creating a separate bug report from bug#5042 and bug#9917. > > The patch above fixes the problem of using xref-find-definitions > in elisp-mode, but using xref-find-definitions in narrowed > C files still fails with the error "Rerun etags: `%s' not found in %s". > > Here is an additional patch that fixes this as well: Thank you. I'm fine with both patches, please feel free to install. > - (user-error "Rerun etags: `%s' not found in %s" > - pat buffer-file-name))) > + (if (or (= (point-min) 1) (not widen-automatically)) Couldn't a buffer be narrowed, but point-min still be equal to 1?