From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#48157: Emacs-28 on Mac: corrupted GUI when setting default-frame-alist Date: Mon, 3 May 2021 09:56:45 +0200 Message-ID: <9a3da27e-277a-61a0-afdb-5e791f3966bb@gmx.at> References: <22131E77-40E5-4F8B-AF94-BB35F2771165@it.uc3m.es> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------1DC48937F5308A91AD4E0BBC" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34957"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48157@debbugs.gnu.org To: PEDRO ANDRES ARANDA GUTIERREZ Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 09:57:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldTS2-00090l-Jb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 09:57:10 +0200 Original-Received: from localhost ([::1]:39610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldTS1-00068A-Mn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 03:57:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldTRu-00067q-Ef for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 03:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldTRu-0001aB-7d for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 03:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldTRu-0002nT-4y for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 03:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 07:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48157 X-GNU-PR-Package: emacs Original-Received: via spool by 48157-submit@debbugs.gnu.org id=B48157.162002861610745 (code B ref 48157); Mon, 03 May 2021 07:57:02 +0000 Original-Received: (at 48157) by debbugs.gnu.org; 3 May 2021 07:56:56 +0000 Original-Received: from localhost ([127.0.0.1]:46109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldTRn-0002nF-V8 for submit@debbugs.gnu.org; Mon, 03 May 2021 03:56:56 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:32909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldTRm-0002n9-04 for 48157@debbugs.gnu.org; Mon, 03 May 2021 03:56:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620028607; bh=8B1TZl07fSDsHq3fxzlRozTBBstrM41MkOL7tmDimBw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=SDYV3rHlNaq/wJE0kQ4d8gZf9SuHHjATk1jLHA9Wya90vhKH3ZHe9FK9dFWB1VLSQ 0nQ0rVJqFkLx2dsd4paqZLAphoSlJNErKw35PGsJvfCAc+F+EM20n6ZNEyPAzmPDWc 1SqDug6IIYGUc9aZ95psCkAUwjwY8qEQ4lYyRNf8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.3]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MFKGP-1loAo20UJd-00Fg17; Mon, 03 May 2021 09:56:47 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:uS3qctI7qcNhaiEuEC/ZWAQFa7j+POfeiNjkVkC/oYSFwwcrxih zukA8jA2TgzBQYtmUv2nJxeewy8sWri56L32YRDw836tRGyFcgitKwgaUzy78ZttvMHzLFQ sf8wXgrMUlz/eiwpLBYKvGmrZpM1PI3hwTsB1Hkp2Vywb6m8CmkUCkOvKPZ6iHfeUba1RDc wr8GjyU87vG0WEfbdhRZg== X-UI-Out-Filterresults: notjunk:1;V03:K0:JmNQ7ZWTQmU=:GQVdWsKVQHrHqoDh0Z0U81 HV9HPuQKixbOl/SY2832qLgxgfvaYB7/xtEEMq9lwukupoE4dPGAUoIVl83iIHpp160lHZDJG FS0GcZXIvhIcpLqozFcvrmfhnouisLsjJWLkz95baC9X36skJQf6Ea2FHJzHpdZlN4NulwXnR /yQOBTQBKjoPv4eSn9Mix31zg5qqpQRNj648d8qziVsuHY/x1cisLs4FuoNPZEaQw180bfebM LbKB/mQHvLf/ork6aKAVOYcIu6BaIvXkO5V1pmLyUuvP2q1I1NyZtatgPpK6Fv+CPwjqM+bdh SrYboTnoXcXFW1l85rjIviQdjeBc4oeQzRsRQVsvQqNZMxGLRWSAMY0NVwO/aJYlzrBR/OaMT 849WqXQFRQoUc/b9Dcho3PFJToASI66WjB60AHZYf/CqMq+apUWwQN9kQUrUoNKNVqoUMSOMO g1aRnWf864d0ZIqzNYC7s5zkzjigquqceTLjJZj44VKpUjuMMG4sygcE8eqU9kyGtgW63IUd1 Ce+mXEb0C8pKeP0nEmQgmy6kPIT1R4x5llkdlgcIeIoNlCyr53WI6Tr6okyCdxOI4ZMq670Ja rMcQo+q/8lKquHww+Ce+WMlhc0CSVTu76SrrfaUuu/9I7WyK9LjRYql1EGR6Ftb1sr5e7a27Q WX4Z7QrfahL/3RdXCrzpEwnVPogQkuJqk0jPWLbrvOx1ZwngvxOhZi+7IQixSLCec6E5iVcS6 deLNG9On8XRiM+uKcFkbCaC2IbKewdhDvDApAsXxGvyBrbJEw8xbmfxCuqkt+yR4wb8vpwF2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205476 Archived-At: This is a multi-part message in MIME format. --------------1DC48937F5308A91AD4E0BBC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > I retried a couple of minutes ago and it continues to startup weirdly on my > MacBook Air Did you try Alan's latest fixes (I attach them here)? martin --------------1DC48937F5308A91AD4E0BBC Content-Type: text/x-patch; name="0001-Fix-incorrect-resizing-behaviour-on-macOS-bug-48157-.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-Fix-incorrect-resizing-behaviour-on-macOS-bug-48157-.pa"; filename*1="tch" >>From c4048b3cd6841a7f2ccdfb3f6c880c9ee176390a Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sun, 2 May 2021 22:38:13 +0100 Subject: [PATCH] Fix incorrect resizing behaviour on macOS (bug#48157, bug#48162) * src/nsterm.m ([EmacsView viewDidResize:]): The drawing buffer can be resized independently of Emacs's idea of the frame size. Co-authored-by: martin rudalics =2D-- src/nsterm.m | 36 ++++++++++++++++++++++-------------- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index 6e7ab1266b..bb20886ab1 100644 =2D-- a/src/nsterm.m +++ b/src/nsterm.m @@ -7303,16 +7303,34 @@ - (void)viewDidResize:(NSNotification *)notificati= on NSTRACE ("[EmacsView viewDidResize]"); +#ifdef NS_DRAW_TO_BUFFER + /* If the buffer size doesn't match the view's backing size, destroy + the buffer and let it be recreated at the correct size later. */ + if ([self wantsUpdateLayer] && surface) + { + NSRect surfaceRect =3D {{0, 0}, [surface getSize]}; + NSRect frameRect =3D [[self window] convertRectToBacking:frame]; + + if (!NSEqualRects (frameRect, surfaceRect)) + { + [surface release]; + surface =3D nil; + + [self setNeedsDisplay:YES]; + } + } +#endif + neww =3D (int)NSWidth (frame); newh =3D (int)NSHeight (frame); oldw =3D FRAME_PIXEL_WIDTH (emacsframe); oldh =3D FRAME_PIXEL_HEIGHT (emacsframe); /* Don't want to do anything when the view size hasn't changed. */ - if ((oldh =3D=3D newh && oldw =3D=3D neww) - || (emacsframe->new_size_p - && newh =3D=3D emacsframe->new_height - && neww =3D=3D emacsframe->new_width)) + if (emacsframe->new_size_p + ? (newh =3D=3D emacsframe->new_height + && neww =3D=3D emacsframe->new_width) + : (oldh =3D=3D newh && oldw =3D=3D neww)) { NSTRACE_MSG ("No change"); return; @@ -7321,16 +7339,6 @@ - (void)viewDidResize:(NSNotification *)notificatio= n NSTRACE_SIZE ("New size", NSMakeSize (neww, newh)); NSTRACE_SIZE ("Original size", NSMakeSize (oldw, oldh)); -#ifdef NS_DRAW_TO_BUFFER - if ([self wantsUpdateLayer]) - { - [surface release]; - surface =3D nil; - - [self setNeedsDisplay:YES]; - } -#endif - change_frame_size (emacsframe, neww, newh, false, YES, false); SET_FRAME_GARBAGED (emacsframe); =2D- 2.30.2 --------------1DC48937F5308A91AD4E0BBC--