unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Gregor Zattler <telegraph@gmx.net>
Cc: 53809@debbugs.gnu.org
Subject: bug#53809: 29.0.50; fatal error: assertion failed: string_immovable_p (bytestr)
Date: Mon, 7 Feb 2022 17:48:17 +0100	[thread overview]
Message-ID: <9FCF3332-7825-40CE-B01C-5A017D026436@acm.org> (raw)
In-Reply-To: <87ee4eiu1k.fsf@no.workgroup>

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

7 feb. 2022 kl. 16.19 skrev Gregor Zattler <telegraph@gmx.net>:

> It's from a package, called gnus-alias, which is rather old.

Indeed, and that's why we didn't detect the bug earlier. The attached patch has now been installed on master. Does it help?


[-- Attachment #2: 0001-Pin-lazily-read-bytecode-bug-53809.patch --]
[-- Type: application/octet-stream, Size: 848 bytes --]

From 03e0d3903b671c3b4c3137629eea5206df997a80 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= <mattiase@acm.org>
Date: Mon, 7 Feb 2022 17:36:11 +0100
Subject: [PATCH] Pin lazily read bytecode (bug#53809)

* src/eval.c (Ffetch_bytecode): Bytecode strings read lazily weren't
pinned as they must be.  Do so.

Bug reported by Gregor Zattler.
---
 src/eval.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/eval.c b/src/eval.c
index c87b1bc704..ae9b18da0b 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -3495,6 +3495,7 @@ DEFUN ("fetch-bytecode", Ffetch_bytecode, Sfetch_bytecode,
 	      bytecode = Fstring_as_unibyte (bytecode);
 	    }
 
+	  pin_string (bytecode);
 	  ASET (object, COMPILED_BYTECODE, bytecode);
 	  ASET (object, COMPILED_CONSTANTS, XCDR (tem));
 	}
-- 
2.32.0 (Apple Git-132)


  reply	other threads:[~2022-02-07 16:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05 22:50 bug#53809: 29.0.50; fatal error: assertion failed: string_immovable_p (bytestr) Gregor Zattler
2022-02-06  7:38 ` Eli Zaretskii
2022-02-06 23:44   ` Gregor Zattler
2022-02-07 13:49     ` Eli Zaretskii
2022-02-07 14:12       ` Gregor Zattler
2022-02-07 14:30         ` Eli Zaretskii
2022-02-07 15:01           ` Mattias Engdegård
2022-02-07 15:19             ` Gregor Zattler
2022-02-07 16:48               ` Mattias Engdegård [this message]
2022-02-07 18:07                 ` Gregor Zattler
2022-02-08 20:50                   ` Mattias Engdegård
2022-02-07 18:52             ` Eli Zaretskii
2022-02-07 19:09               ` Mattias Engdegård
2022-02-07 19:45                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9FCF3332-7825-40CE-B01C-5A017D026436@acm.org \
    --to=mattiase@acm.org \
    --cc=53809@debbugs.gnu.org \
    --cc=telegraph@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).