From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Howard Melman Newsgroups: gmane.emacs.bugs Subject: bug#50642: 27.2; autoload xref-pulse-momentarily Date: Fri, 17 Sep 2021 21:48:47 -0400 Message-ID: <9F48766D-5656-422E-9608-C1F7203FB8E5@gmail.com> References: <1BC3E278-B041-4D01-AA25-706FD01CD1E7@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11562"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50642@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 03:49:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRPTk-0002nr-1Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 03:49:20 +0200 Original-Received: from localhost ([::1]:34378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRPTh-0001iU-Sj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Sep 2021 21:49:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRPTS-0001iL-WC for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 21:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRPTS-0003FD-Ok for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 21:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRPTS-0003Up-7C for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 21:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Howard Melman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 01:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50642 X-GNU-PR-Package: emacs Original-Received: via spool by 50642-submit@debbugs.gnu.org id=B50642.163192973813429 (code B ref 50642); Sat, 18 Sep 2021 01:49:02 +0000 Original-Received: (at 50642) by debbugs.gnu.org; 18 Sep 2021 01:48:58 +0000 Original-Received: from localhost ([127.0.0.1]:33304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRPTN-0003UX-SI for submit@debbugs.gnu.org; Fri, 17 Sep 2021 21:48:58 -0400 Original-Received: from mail-qt1-f180.google.com ([209.85.160.180]:40940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRPTK-0003UJ-Uq for 50642@debbugs.gnu.org; Fri, 17 Sep 2021 21:48:56 -0400 Original-Received: by mail-qt1-f180.google.com with SMTP id c19so10383475qte.7 for <50642@debbugs.gnu.org>; Fri, 17 Sep 2021 18:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1Mz9yrJwShOksrK+lZsy2CZT3HZXHe+c4ii5Qi6ly0c=; b=Gn4HKxIGTRKzPz7x5gcW8ap9h2CTReuNpNsq7yXkpbaHEoMVqNrXrxSBx8R8Z2BBiN uFboqK+4Dwji96mHjST6jsoYu6FVU5WIfJwzNfCRH3WQUrPUWdk7SJaPF+NJobiZ6Fx4 40+ay8RQJHVvbr9zhof6nxhM1/U8k/kFyxM8o6afcc2n9ypi2HFxpoXoXLR2nN8ED1VP duA7e9FMmMmDwsW4BqzkLrtbhT0UcrPOk/8kMHJnxjs4vXY/QNSpeiRSEv596tkDGJHQ tYCuTcbIgCUCFl9++RLTTzKi3Ivpvq6MYXylQVYmIIOwhUrZPTGZ5S0hKwXhJyuWThhh xOTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1Mz9yrJwShOksrK+lZsy2CZT3HZXHe+c4ii5Qi6ly0c=; b=0h5BD6/+OeYk6+uNPfQgVfmP/you4M+y0JYuJE/BVi9e53UJkpq4Qdlvg7lb6wSDJd wZkIgKHyldgfXogPi4Em0FQtklFJ2qYtIgtLxXFzpKK2iTqnw4wchwjb9y5RvLtfEyYY daIiZNjf1Q7q09QGRSOXUwuCMMEEzcqlBqOrz6iBTloGnaKlEtUHBKHlon6jgwYAPz0A WvI96EwshI7gpSH/WW3Vz57bWEqcRET/fmGXTYkLoC54FI3A2HF73XYJO/mMbCG4m9ri UOJTVA+BbOyZ8jXM6LkQyOkKpsvVtYTA6yxBr0+8+OdL+Z+i11IP34yoMytZL+T03vfr 6f0A== X-Gm-Message-State: AOAM531kIdhJ2aGK7M3nByfW0ZzhovQxDwzN6vzUeNyqPwkSrQ5MLlAD yTEluJq3idBnw4ONJOmH5Q8= X-Google-Smtp-Source: ABdhPJx9gDZqt2yHm1WKwH5PdekmpE6UKWD8ZFXt5/M5W6lh7oobGOztAdSeopueKWvNa7F1lFr+nQ== X-Received: by 2002:ac8:4654:: with SMTP id f20mr13255547qto.386.1631929729102; Fri, 17 Sep 2021 18:48:49 -0700 (PDT) Original-Received: from smtpclient.apple (pool-108-26-204-101.bstnma.fios.verizon.net. [108.26.204.101]) by smtp.gmail.com with ESMTPSA id z12sm1876110qtj.76.2021.09.17.18.48.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Sep 2021 18:48:48 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214596 Archived-At: On Sep 17, 2021, at 8:14 PM, Dmitry Gutov wrote: >=20 > Well, um. I don't really mind but xref-pulse-momentarily was designed = to pulse after a jump to an xref location. That's why it refers to = xref--current-item in its implementation. >=20 > It does fall back to pulsing the whole line, so I suppose it can be = useful in other cases too. >=20 > But maybe Counsel wants to provide its own version of this function? = It can call xref-pulse-momentarily after xref navigations, but maybe do = some more useful fallbacks for other commands? I'm not sure which other = kinds of jumps consult-after-jump-hook also handles. I'm not the consult author, but given that it doesn't actually use a = pulse function, it just suggests one possible one, I doubt it will. It looked to me in some cases consult wasn't pulsing the whole line but = rather just a symbol, but perhaps I'm mistaken (I can't seem to get it = to do so now). It uses this hook in various grep/imenu/outline/etc. = navigation commands. I do still think it would be nice for pulse.el to define a function = suitable for use in a jump-like hook that take no arguments and pulses = the current line or maybe symbol. The former is trival, but if = pulse-momentary-highlight-one-line allowed it's POINT argument to be = optional, emacs could provide it for everyone. It seems like in Emacs = 27 all the callers of it just pass (point) anyway. Or maybe pulse-line-hook-function is supposed to be this? In which case = it should be autoloaded and pulse-command-advice-flag should be a = defcustom and have a docstring? Howard=