From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK. Date: Wed, 30 Mar 2022 12:42:54 +0000 Message-ID: <9EqAhFUloeB4kQNtbW9VlWwN8Z3sNW2ymLkuwBA1XV5j19ttoHI_X78nrUFrz_2uqvJAu2DuGDJk0SMb2XeNUZVQgsp7EmJpzWoaWemfDVg=@rjt.dev> References: <83bkxn8wpp.fsf@gnu.org> Reply-To: Randy Taylor Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12557"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54633@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 14:54:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZXpq-00038G-58 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 14:54:02 +0200 Original-Received: from localhost ([::1]:35750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZXpp-0002xc-8W for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 08:54:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZXnu-0000FN-O3 for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 08:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZXnu-0003hr-Dk for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 08:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZXnu-0000By-Cg for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 08:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54633-submit@debbugs.gnu.org id=B54633.1648644695688 (code B ref 54633); Wed, 30 Mar 2022 12:52:02 +0000 Original-Received: (at 54633) by debbugs.gnu.org; 30 Mar 2022 12:51:35 +0000 Original-Received: from localhost ([127.0.0.1]:34777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZXnS-0000B0-J2 for submit@debbugs.gnu.org; Wed, 30 Mar 2022 08:51:35 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:44603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZXfK-0008M1-5R for 54633@debbugs.gnu.org; Wed, 30 Mar 2022 08:43:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail; t=1648644181; bh=/JbJ1X0ZLgcTK7ZgEheBxZNCkzHTVGriMPHfHeV6LAc=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=dSwhn4CYxwBcso/MCWWX0uAfMBeLyP75y6WPDYVvAK6O4rrz7Cc7xaJNpuD7e8swK MDxrgEkzW6buDz4Ki1Vbb9mXBikG47jlM7d/D1GcBv4vsbifbHoMf15yrpWtu+bltG dgMSHg5vSHQGXk7Dy6VoDSvCh8t7q2+/pdZWZMqb70u4ufVJGTAEa1XHDrzDnpAmfq ugaEp6nB9rk5Hq59mme7v7MYU41MTJZ2ALOaHL/xsaNzq6W5OcjKH5B6KeB4mXdAme aqqEYhMgRx7xtUu8n94N2VduC7ehJA0rbmWWi/k54cFkRXucYtsMty6RtGdZPLQIor wMxmuowrUd7UA== In-Reply-To: <83bkxn8wpp.fsf@gnu.org> X-Mailman-Approved-At: Wed, 30 Mar 2022 08:51:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229105 Archived-At: When I build Emacs I specify "--without-gif". When using PGTK: - With the original code and specifying "--without-gif", here is what con= figure gives me: Does Emacs use a gif library? ye= s -lgif - With the patch and specifying "--without-gif", I get this (as expected)= : Does Emacs use a gif library? no - With the patch, if I remove "--without-gif" or specify "--with-gif=3Dye= s", I get this (as expected): Does Emacs use a gif library? = yes -lgif When using X11: - With the original code and specifying "--without-gif", here is what con= figure gives me (as expected): Does Emacs use a gif library? = no - With the original code and removing "--without-gif" or specifying "--wi= th-gif=3D"yes", here is what configure gives me (as expected): Does Emacs u= se a gif library? yes -lgif The check in the code for "--without-gif" only applies to X11, but not the = other systems. This patch fixes it to apply for all the systems in that check, in the same= fashion as the SVG check (see line 2660 in configure.ac). ------- Original Message ------- On Wednesday, March 30th, 2022 at 08:13, Eli Zaretskii wrote= : > > Date: Wed, 30 Mar 2022 01:45:16 +0000 > > > From: Randy Taylor dev@rjt.dev > > > > --without-gif was only checked against X11; with this patch it is now c= hecked against all the options. > > Please describe the problem you had with the current code. Because I > > don't think I see the problem you are trying to fix. > > Thanks.