From: "Mattias Engdegård" <mattiase@acm.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 33205@debbugs.gnu.org
Subject: bug#33205: 26.1; unibyte/multibyte missing in rx.el
Date: Wed, 7 Nov 2018 21:19:07 +0100 [thread overview]
Message-ID: <9EE3CC19-803A-42EE-A6D2-D438CD805F7C@acm.org> (raw)
In-Reply-To: <834lcsd7qu.fsf@gnu.org>
7 nov. 2018 kl. 20.10 skrev Eli Zaretskii <eliz@gnu.org>:
>> Perhaps those char classes didn't see much use.
>
> Definitely not. I cannot even think of a practical use case for them
> nowadays.
But were they useful back then, when they were added? If so, for what? Maybe it's been lost in the mists of time.
>
>> The old behaviour seems a little more intuitive, but it must be rare to need regex matching of rubbish bytes in multibyte strings. If you could argue that the status quo is fine then I wouldn't necessarily object, but would suggest that at least the code be made explicit about it (and the documentation, as well).
>
> I can fix the docs, but I don't think I understand what would you like
> to do about the code.
If we are content with [:unibyte:]/[:multibyte:] = [:ascii:]/[:nonascii:], then it would be nice if the code were obvious about it. Right now, ISUNIBYTE and IS_REAL_ASCII differ, and it takes some digging to realise that they have the same effect. Removing RECC_UNIBYTE/RECC_MULTIBYTE entirely and use RECC_ASCII/RECC_NONASCII throughout would make the semantics clear.
next prev parent reply other threads:[~2018-11-07 20:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 15:03 bug#33205: 26.1; unibyte/multibyte missing in rx.el Mattias Engdegård
2018-10-30 17:27 ` Eli Zaretskii
2018-10-31 15:27 ` Mattias Engdegård
2018-10-31 15:55 ` Eli Zaretskii
2018-11-05 16:49 ` Eli Zaretskii
2018-11-07 18:08 ` Mattias Engdegård
2018-11-07 19:10 ` Eli Zaretskii
2018-11-07 20:19 ` Mattias Engdegård [this message]
2018-11-19 20:07 ` Mattias Engdegård
2018-12-08 8:56 ` Eli Zaretskii
2018-12-08 9:23 ` Mattias Engdegård
2018-12-08 11:11 ` Eli Zaretskii
2018-12-28 18:17 ` Mattias Engdegård
2018-12-29 9:24 ` Eli Zaretskii
2018-12-29 9:23 ` Eli Zaretskii
2018-12-29 10:43 ` Mattias Engdegård
2018-12-29 14:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9EE3CC19-803A-42EE-A6D2-D438CD805F7C@acm.org \
--to=mattiase@acm.org \
--cc=33205@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).