unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrii Kolomoiets <andreyk.mad@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 38156@debbugs.gnu.org
Subject: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers prompt
Date: Thu, 14 Nov 2019 09:13:33 +0200	[thread overview]
Message-ID: <9E38A0BD-16D2-48B5-B87A-02A1F3F9986C@gmail.com> (raw)
In-Reply-To: <878sojq9w1.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi Lars,

> On 14 Nov 2019, at 07:55, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> 
> I applied the patch anyway, because it provides a way to make the
> backends say whether they support it or not, which seems generally
> useful.

Please install attached patch. Totally missed that default vc functions
are called with `backend` argument.

Thanks.


[-- Attachment #2: 0001-lisp-vc-vc.el-vc-default-update-on-retrieve-tag-Acce.patch --]
[-- Type: application/octet-stream, Size: 808 bytes --]

From dfc40b85d9ff6fbc5344cd6882881c421decee35 Mon Sep 17 00:00:00 2001
From: Andrii Kolomoiets <andreyk.mad@gmail.com>
Date: Thu, 14 Nov 2019 09:07:31 +0200
Subject: [PATCH] lisp/vc/vc.el (vc-default-update-on-retrieve-tag): Accept
 backend

* lisp/vc/vc.el (vc-default-update-on-retrieve-tag): Accept backend argument

diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 401b39145c..0d29c80d02 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -3032,7 +3032,7 @@ vc-default-receive-file
   "Let BACKEND receive FILE from another version control system."
   (vc-call-backend backend 'register (list file) rev ""))
 
-(defun vc-default-update-on-retrieve-tag ()
+(defun vc-default-update-on-retrieve-tag (_backend)
   "Prompt for update buffers on `vc-retrieve-tag'."
   t)
 
-- 
2.15.1


  reply	other threads:[~2019-11-14  7:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-09 20:29 bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers prompt Andrii Kolomoiets
2019-11-14  5:55 ` Lars Ingebrigtsen
2019-11-14  7:13   ` Andrii Kolomoiets [this message]
2019-11-14  7:18     ` Lars Ingebrigtsen
2019-11-14  9:54   ` Andrii Kolomoiets
2019-11-16  7:13     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9E38A0BD-16D2-48B5-B87A-02A1F3F9986C@gmail.com \
    --to=andreyk.mad@gmail.com \
    --cc=38156@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).