From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#5744: 23.1.92; doc string of `version<' etc. Date: Sat, 20 Mar 2010 11:10:10 -0700 Message-ID: <9C18B608A91D4DE5B54FC6ACB722141C@us.oracle.com> References: <4E614B66A7BE41B496EA061D77C80C2E@us.oracle.com> <87pr2yriq4.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1269109529 15333 80.91.229.12 (20 Mar 2010 18:25:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 20 Mar 2010 18:25:29 +0000 (UTC) Cc: 5744@debbugs.gnu.org To: =?UTF-8?Q?"'=C5=A0tep=C3=A1n?= Nemec'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 20 19:25:25 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nt3MS-0003c4-Nz for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Mar 2010 19:25:25 +0100 Original-Received: from localhost ([127.0.0.1]:48050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nt3MS-0004MV-5o for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Mar 2010 14:25:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nt3MB-0004DW-Nw for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2010 14:25:07 -0400 Original-Received: from [140.186.70.92] (port=45791 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nt3MA-0004CQ-4e for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2010 14:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nt3M7-0000RA-SG for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2010 14:25:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60829) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nt3M7-0000R6-OZ for bug-gnu-emacs@gnu.org; Sat, 20 Mar 2010 14:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Nt38Y-0008Dy-38; Sat, 20 Mar 2010 14:11:02 -0400 X-Loop: bug-gnu-emacs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Mar 2010 18:11:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5744 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5744-submit@debbugs.gnu.org id=B5744.126910863331607 (code B ref 5744); Sat, 20 Mar 2010 18:11:01 +0000 Original-Received: (at 5744) by debbugs.gnu.org; 20 Mar 2010 18:10:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nt385-0008Dk-12 for submit@debbugs.gnu.org; Sat, 20 Mar 2010 14:10:33 -0400 Original-Received: from acsinet12.oracle.com ([141.146.126.234]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nt383-0008De-7G for 5744@debbugs.gnu.org; Sat, 20 Mar 2010 14:10:31 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet12.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o2KIAMxx004189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 20 Mar 2010 18:10:26 GMT Original-Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o2KIALYN011252; Sat, 20 Mar 2010 18:10:22 GMT Original-Received: from abhmt006.oracle.com by acsmt354.oracle.com with ESMTP id 102562251269108609; Sat, 20 Mar 2010 11:10:09 -0700 Original-Received: from dradamslap1 (/24.5.179.75) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 20 Mar 2010 11:10:09 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87pr2yriq4.fsf@gmail.com> Thread-Index: AcrIVNUCE9Kv1TG5RY6x2aXoyg3v2wAANPXA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4BA50F8E.00D4:SCFMA4539814,ss=1,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 20 Mar 2010 14:11:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:35658 Archived-At: > > 1. Change "lesser than" to "less than". > > "Lesser" seems completely fine to me, but I'm not a native speaker. That's why it seems completely fine to you. It's not English. ;-) "less than" is correct; "lesser than" is not correct. > > 2. Say explicitly that V1 and V2 are strings. > > I think that's clear from the docstring, but more clarity > never hurts, yes. > > > Say in fact that they are strings of the format returned by variable > > `emacs-version'. > > That would be misleading at best IMHO. > The function accepts a far wider set of arguments. Oh really? Then all the more reason to explicitly specify the accepted formats (completely). You cannot use a function reliably if you don't know what kinds of arguments it handles. > Also note that you would most probably want to change docstrings of > the whole family of the version functions to stay consistent. Of course. That's why I wrote "`version<' ETC." in the subject line. Also: 3. Specifically state the ordering rule. Wrt alphabetical comparison, don't just give an example, state that letters are compared alphabetically (and state whether that's case-sensitive). 4. Mention at least one of these version-comparison functions in the Elisp manual, node `Version Info'.