From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#3174: "italic" is underlined now (NS?) Date: Sun, 14 Jun 2009 10:37:16 -0400 Message-ID: <9B0EAB9B-4FD7-4B20-8F20-34F74BF1135B@gmail.com> References: <572FEF4D-AE1C-4805-AF88-AD9B048111C4@gmail.com> <87ws7i3kgr.fsf@cyd.mit.edu> <1AAB5F70-1F6C-4ED8-8B73-F75834BCBFFE@gmail.com> <46210028-DD72-4C1D-B95C-A23A8592A87E@gmail.com> <2779F4B4-BEF7-4AF5-B22B-7D0568649EC6@gmail.com> <78DA06D4-062E-40AC-B8D8-44B0ED0B66B0@gmail.com> Reply-To: David Reitter , 3174@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: multipart/signed; boundary=Apple-Mail-81-395064306; micalg=sha1; protocol="application/pkcs7-signature" X-Trace: ger.gmane.org 1244991465 26974 80.91.229.12 (14 Jun 2009 14:57:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Jun 2009 14:57:45 +0000 (UTC) Cc: 3174@emacsbugs.donarmstrong.com To: Adrian Robert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 14 16:57:36 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MFr9L-0005Dk-Av for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jun 2009 16:57:35 +0200 Original-Received: from localhost ([127.0.0.1]:34814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MFr9K-0002mH-S9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jun 2009 10:57:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MFr9F-0002k8-6M for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2009 10:57:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MFr9A-0002iF-6q for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2009 10:57:28 -0400 Original-Received: from [199.232.76.173] (port=51766 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MFr99-0002iA-CW for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2009 10:57:23 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:57620) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MFr98-00066y-Ok for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2009 10:57:23 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5EEvK9a015096; Sun, 14 Jun 2009 07:57:21 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n5EEe7FN012071; Sun, 14 Jun 2009 07:40:07 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: David Reitter Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Sun, 14 Jun 2009 14:40:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3174 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: Original-Received: via spool by 3174-submit@emacsbugs.donarmstrong.com id=B3174.124499025211840 (code B ref 3174); Sun, 14 Jun 2009 14:40:06 +0000 Original-Received: (at 3174) by emacsbugs.donarmstrong.com; 14 Jun 2009 14:37:32 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-ew0-f226.google.com (mail-ew0-f226.google.com [209.85.219.226]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5EEbQNB011835 for <3174@emacsbugs.donarmstrong.com>; Sun, 14 Jun 2009 07:37:28 -0700 Original-Received: by ewy26 with SMTP id 26so4208902ewy.1 for <3174@emacsbugs.donarmstrong.com>; Sun, 14 Jun 2009 07:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=YobL8WB9EoWBiJzoIOkMnXkHQOU2LqmU9oPoZixUxnw=; b=JJUoJzKTnmSLRO8hIbdGe/8tAa9rbgqev9ga+Nh1NfubgE/iZtKcjBRWnYy6k2g9Hc hPdSs9CKShWbrLu/F5UoKS5klkY3jeTk/zqw8R+Kzw12oxA/mpv2CmLIChEn9fXLYdDG i3J4Uz7XQD57OeXYtyJQoCHCu1Cdy6hZVSRyM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=KKuuA+lVlVRaodZ6Df2E+hAqSzeHw6yZ3f3edtaYJJn3tKHDArBXAApFns0TV9eQ59 MXwbTFfB8FjPMSZn2bYoQUX0669GWZ3A9s/uqDbxBocpdQpm2Qu7eqMbObJGoRxrCptR ORXyXoPNCqGjr8a/rkuTPkh6mT8n2SOe6QMUE= Original-Received: by 10.210.92.5 with SMTP id p5mr6940370ebb.15.1244990240986; Sun, 14 Jun 2009 07:37:20 -0700 (PDT) Original-Received: from ?192.168.1.42? (pool-71-162-19-47.pitbpa.east.verizon.net [71.162.19.47]) by mx.google.com with ESMTPS id 24sm1685045eyx.23.2009.06.14.07.37.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 14 Jun 2009 07:37:19 -0700 (PDT) In-Reply-To: <78DA06D4-062E-40AC-B8D8-44B0ED0B66B0@gmail.com> X-Mailer: Apple Mail (2.935.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sun, 14 Jun 2009 10:57:28 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28696 Archived-At: --Apple-Mail-81-395064306 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On Jun 13, 2009, at 7:34 AM, Adrian Robert wrote: > > Don't understand this. The lines above in the log say that a font > is requested with only the family specified, nothing about slant. > Then fdesc, the result of ns_spec_to_descriptor, is printed out, > also showing no slant trait. So why/how does ns_attribute_value() > return something? Could you add: > > NSLog(@"slant: %@", ns_attribute_value (fdesc, NSFontSlantTrait)); > > And see what that prints? If it prints 0, it makes some kind of > sense, but on Tiger at least nsfont.m:114 gets nil, indicating no > possession either way of the attribute. Returning an explicit > NSNumber of 0 is such a semantically different behavior I can't > believe that changed from Tiger to Leopard. This seems to be the case though. NSFontSlantTrait is 0.0. It's still in line with the documentation, even though nil would make more sense... I suggest the patch below - this makes it work for me. - D diff --git a/src/nsfont.m b/src/nsfont.m index 990d58e..06beb99 100644 --- a/src/nsfont.m +++ b/src/nsfont.m @@ -504,6 +504,8 @@ ns_findfonts (Lisp_Object font_spec, BOOL isMatch) family = [fdesc objectForKey: NSFontFamilyAttribute]; if (family != nil && !foundItal && XINT (Flength (list)) > 0 && (ns_attribute_value (fdesc, NSFontSlantTrait) == nil + /* from OSX 10.5 on, 0.0 is returned if no italic trait is available */ + || ([ns_attribute_value (fdesc, NSFontSlantTrait) floatValue] == 0.0) || ns_has_attribute (fdesc, NSFontSlantTrait))) { NSFontDescriptor *sDesc = [[[NSFontDescriptor new] --Apple-Mail-81-395064306 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICED6shx13jEDrq0eL8FRq5ykwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MTIwOTAyMDgwMVoXDTA5MTIwOTAyMDgw MVowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDOdo6kAwlkBxUb8dj4saMbYg4SVng8CUePFn3cjjWrakBTbUVa4Z0n wlUxr7AitEeKhBy5nGhu96+jKUPrCwYNRCZ0l2ovvuGq4z1m1nZ5/c8WvFlVhieuxXMUfmb/O7D3 IojoX6iS8n5MNNU2IWNNT/AD3vOl6DKgOtOw4J9y+QIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAIjI8yEW wkiEfA9PMgpjnD6KyCXT0iZjHhW2PkR53yZZLUoTboHnKgsFwYp/gzzIL8J5cvZaRUyMUzXDufPP dRmxxCs2jXXLDD/8bvdvOuMzqgYoFA73fAfsC8S6qUL1PayZ90J8CZHNhDwqWqOA56T+DdKUegJT sqoHKh6OnypTMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA+rIcdd4xA66tH i/BUaucpMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA5MDYxNDE0MzcxN1owIwYJKoZIhvcNAQkEMRYEFDl7EfMGi4jIlxU3V7SkEzYy4EWm MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQPqyHHXeMQOurR4vwVGrnKTCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQPqyHHXeMQOurR4vwVGrnKTANBgkqhkiG9w0B AQEFAASBgLiKCLYCBXT8CaJBw3GAhGgYbO87BIhHh+0BOTeUS4d6xnNs7821N0OA5BSbK7i5mz9x NPI75UX7tj3Stc1HZFDnWamD1j8LusR5kN151HHIDtmblIYITRkPCpQzxBoelfX9nJrw+zrenkO7 tIn0uOOG7E/j5WH7+nU1J6sX+2wbAAAAAAAA --Apple-Mail-81-395064306--