From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 60197@debbugs.gnu.org
Subject: bug#60197: 30.0.50; beginning-of-defun broken after new treesit impl
Date: Tue, 20 Dec 2022 20:08:09 -0800 [thread overview]
Message-ID: <9AC22A2A-6ED8-4778-95CE-EB29A7FC4633@gmail.com> (raw)
In-Reply-To: <87edsv7lc4.fsf@thornhill.no>
Theodor Thornhill <theo@thornhill.no> writes:
> Hi, Yuan!
>
> It seems 'prog-fill-reindent-defun' is broken after the latest changes
> to treesit-beginning-of-defun. The culprit is that we now use remap
> instead of setting the beginning-of-defun-function. What is the
> reasoning behind that change? Can't we just rely on the variable
> beginning-of-defun-function?
Not really, end-of-defun uses beginning/end-of-defun-function in a way
that’s incompatible with nested defuns[1]. So if we want to support
navigation nested defuns reliably we need to remap the commands instead.
In the future (ie emacs 30), we can extend the current
beginning/end-of-defun to support nested defuns, then we don’t need to
remap the commands anymore.
> I see you mentioned it is inteded to be used as a command, but surely
> both should be possible?
Could you remind me where is this function defined? I should have
updated it when I changed the defun navigation implementation. (It was
broken by my change before the defun nav change which you noticed, I
thought I’m going to fix it with the new defun nav functions, but I
forgot...)
Yuan
[1] For example, a nested defun like this:
def parent:
(1)
def child:
return 0
(2) return 1
(3)
When point is at (1), end-of-defun calls beginning-of-defun-function
followed by end-of-defun-function to check if point is in a defun: if
point ends up after the starting point, then starting point is inside a
defun, and we can stop there. In this case, point ends up at
(3), because b-o-d-f goes to previous b-o-d, which is the beg of parent,
then e-o-d-f goes to (3), which is the end of that parent, and
end-of-defun stops at (3).
However, we should have gone to (2), which is the immediately following
end-of-defun.
Thanks,
Yuan
next prev parent reply other threads:[~2022-12-21 4:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 10:13 bug#60197: 30.0.50; beginning-of-defun broken after new treesit impl Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-20 8:32 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-21 4:08 ` Yuan Fu [this message]
2022-12-21 5:58 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-21 6:50 ` Yuan Fu
2022-12-21 7:42 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-22 5:00 ` Yuan Fu
2022-12-22 7:48 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-22 8:51 ` Yuan Fu
2022-12-22 9:28 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9AC22A2A-6ED8-4778-95CE-EB29A7FC4633@gmail.com \
--to=casouri@gmail.com \
--cc=60197@debbugs.gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).