From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Date: Mon, 18 Jul 2016 22:17:56 +0300 Message-ID: <995c1f7f-a0fa-a0bf-60f5-41a0a201fe75@yandex.ru> References: <87twfnd50u.fsf@users.sourceforge.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1468869688 16232 80.91.229.3 (18 Jul 2016 19:21:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2016 19:21:28 +0000 (UTC) Cc: 23648@debbugs.gnu.org To: npostavs@users.sourceforge.net, Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 18 21:21:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPE6F-0006yF-MG for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 21:21:07 +0200 Original-Received: from localhost ([::1]:49897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPE6B-0003nW-MV for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 15:21:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPE4I-0001uD-UC for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 15:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPE4E-0006kH-0P for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 15:19:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPE4D-0006k4-SL for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 15:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPE4D-0006VC-MV for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 15:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146886948724913 (code B ref 23648); Mon, 18 Jul 2016 19:19:01 +0000 Original-Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 19:18:07 +0000 Original-Received: from localhost ([127.0.0.1]:56023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPE3K-0006Tl-Tm for submit@debbugs.gnu.org; Mon, 18 Jul 2016 15:18:07 -0400 Original-Received: from mail-wm0-f52.google.com ([74.125.82.52]:38060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPE3J-0006TG-Sa for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 15:18:06 -0400 Original-Received: by mail-wm0-f52.google.com with SMTP id o80so130712701wme.1 for <23648@debbugs.gnu.org>; Mon, 18 Jul 2016 12:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=hp58j7gXQyde/xoyWytqWXl24YKkVMCpkqqUOAbCfsY=; b=hz4ZQArz7kIsC/N/GbqPxVM47396vJkhq9pbvdIVO91PwFcwpQHrGzGWoMq5K/jmLa /zvtCm2OK0PyRj3TL3sO9K42P7ZA1dZ7BAL0jUfD9Dfv4970vSc9g4waeMisntwB50cn pdXXUby+t7DQKv3VMl6gtZdCrKwtyr2iXmiie6+2QYqIQF0B63h/K3wKv1vnqL1xk6RV +jhxwdpQTsjbseMf/0SsxundnvEe+dijj0gBP1wJOAgV4lgC/fCMFrnqVlFMEOf039KO sl1PavRM8LILD5c9z7tE1/bKUuRw21RplGdNVxnVnRsdSiY6cJyJhh9HDI/ZTc9IWYoX ErWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=hp58j7gXQyde/xoyWytqWXl24YKkVMCpkqqUOAbCfsY=; b=U8OF0FnmKsH0OWHrQsjfU49ohPXwpzbrFdgoWGh/PB4VpJNyyyviSILFuMZ3KQl7Im OsDXiMyEbsXPdTCuBpMPozEnfRwVALE1I1k/cg1IZNtYCoJ8ET6yLWpHPlvh32LGHlaJ B9HlAZavF8FEejpIzDk/OuB94Hm12RpjBsOWgXu/81+ppng/g1vbBZ7z50fLRFJHGmHF Wr+XJylTMtgOoey/qY702wtOqnv+JwbK6NutW0ClSMVwttj8MUrQf5L2/jjm5WMcJ8z8 jRiGdRT6df37S6/z9dTCbPI8q5OLCaCizAkZC8Q8YZG5JqIh6hZIPvDIRUBgShEjPNMC +fiA== X-Gm-Message-State: ALyK8tLJJSJzpZQ0CRN7S4rXiZFhftVBIxffzhShu/vp9eZOOvre9fldZi6oD6QmLUwddg== X-Received: by 10.194.229.70 with SMTP id so6mr2967879wjc.178.1468869480039; Mon, 18 Jul 2016 12:18:00 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id 12sm18080789wmj.19.2016.07.18.12.17.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2016 12:17:59 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 In-Reply-To: <87twfnd50u.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121237 Archived-At: On 07/18/2016 06:00 AM, npostavs@users.sourceforge.net wrote: >> Here `delete-dups' destructively modifies a list that includes >> `defun-declarations-alist' as its tail verbatim, not as a copy. >> Attached patch should fix that. > > I agree with analysis and patch here. I like the patch as well. Maybe it would be better to use cl-remove-duplicates with nconc instead (the use of nil is a little non-obvious), but that would require having cl-lib loaded at runtime, and elisp-mode depending on it. In any case, the proposed patch looks safe.