From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Mon, 30 Jan 2023 18:00:33 -0800 Message-ID: <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6989"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60845@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 31 03:01:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMfxR-0001dx-KX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Jan 2023 03:01:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMfxI-0008NT-Po; Mon, 30 Jan 2023 21:01:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMfxH-0008N4-Kq for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 21:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMfxH-0002gA-6l for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 21:01:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMfxG-0006Go-1f for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 21:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2023 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60845-submit@debbugs.gnu.org id=B60845.167513044224063 (code B ref 60845); Tue, 31 Jan 2023 02:01:02 +0000 Original-Received: (at 60845) by debbugs.gnu.org; 31 Jan 2023 02:00:42 +0000 Original-Received: from localhost ([127.0.0.1]:51010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMfww-0006G2-C1 for submit@debbugs.gnu.org; Mon, 30 Jan 2023 21:00:42 -0500 Original-Received: from mail-pj1-f45.google.com ([209.85.216.45]:50804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMfwt-0006Fn-RF for 60845@debbugs.gnu.org; Mon, 30 Jan 2023 21:00:40 -0500 Original-Received: by mail-pj1-f45.google.com with SMTP id m11so12885749pji.0 for <60845@debbugs.gnu.org>; Mon, 30 Jan 2023 18:00:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=IMsNww2HH2TrjOvMQ2bJrP0/8WyfoY6H75hmPsgNOlQ=; b=AIrm0xtyGt8/3uSafcO0v4CxE4FTIGmzhbVf/oKL942V9SXniBmCI0MFZBuKy6p1V3 K8AD8ooCsmsLAXEOYn9pyq8nPUPvhpZ/aoEqOsFDL8TxlIc4nKWSTGGhToRX8cdfPRGX 6hDWQxpQ3W4kbx2OpSe2gYbvgxUDt59cJpI+hikgTM3OiENcbnCBoMECVqsnrYTKYBku 1HRd/0r5ZHQxgCnH7dZGF+w1WUO3VJadsgf1m0H46hcNKOzO7pNtvD90nKnNvKXwEY+D /ShF+SFPXqRpjrV6QxYleP6Lxt1h11bz8tPgAwsMl6s+dNkBDNg6lcQVAnfSMlTElZvQ eARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IMsNww2HH2TrjOvMQ2bJrP0/8WyfoY6H75hmPsgNOlQ=; b=44b5MEtYb1gfv6nQn2u9VloBZhTeOJYL4GcegYQs0oggNxU7QyBrKa/gDTyKJ5AmmY hNGO+Ng1LHbfUsYqYzvdNY5d+HP0Siaih2Vjyk+MejK5kpI1evj9GD5261Kvs6PKrIBI 6XXKKo1EGpnshfmaq71E7WTi4G/8bQE1PV+jmCMJGIhMvfsHNSsW2/5r3W3miwxqv7g1 qaRG3lJ7zxyniJ+DovUQuoZFQEsKrZup9CJG1rV4ii6NDzivb6TnvLBdm6BlMvKPUqiw zVUtu91APJLGypzZxu+/W+pT2C2O/sqwPAO4F0Chnd2QMnYZppzDRx2lSqVWxwCLuRB7 s7sg== X-Gm-Message-State: AO0yUKV/2/1bGIOwVusCeyqNYT7jsD4s0Rq0OnKvtQpDpeGNvEXPOpRL pyA46vK4ic7e8M07CqZUicM= X-Google-Smtp-Source: AK7set8TvVFb1x2TXd5KbQ89BGbadNJajuAYZ9/Y8vqhdKzPA8lYI9ffgzsLRjDNpzMywohDLJyIHA== X-Received: by 2002:a05:6a20:9387:b0:b0:3329:c395 with SMTP id x7-20020a056a20938700b000b03329c395mr14963009pzh.30.1675130433844; Mon, 30 Jan 2023 18:00:33 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id by12-20020a056a00400c00b00593baab06dcsm3084423pfb.198.2023.01.30.18.00.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 18:00:33 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254497 Archived-At: On 1/30/2023 6:54 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > It sounds good to me, but I'm definitely not well versed in this aspect > of the interaction between Eshell and Pcomplete (more specifically, > this is a part of their interaction which I find quite tricky), so it's > good that you add corresponding regression tests. Thanks for taking a look. I've merged my patches as e7d0aa248e. We can leave this open though to discuss what to do about the Pcomplete side of things. I think we can remove the workaround for Emacs 29, but maybe we want some additional changes. (It would also be nice to add some more Pcomplete support on the Eshell side. For example, when completing arguments to 'echo', Pcomplete shows options for the real /bin/echo, instead of showing options for the built-in function 'eshell/echo'.)