From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41821: 28.0.50; read-directory-name in vc commands should provide defaults from projects Date: Wed, 1 Jul 2020 23:24:19 +0300 Message-ID: <990a9046-c4e6-efb2-01dd-60198994127b@yandex.ru> References: <87r1ulxk48.fsf@mail.linkov.net> <87y2oh8fdv.fsf@mail.linkov.net> <87366ohw5z.fsf@mail.linkov.net> <878sge7jls.fsf@mail.linkov.net> <7e136435-7123-fa42-e4a8-66b82e6595da@yandex.ru> <87pn9pxris.fsf@mail.linkov.net> <83d05ottnw.fsf@gnu.org> <0b42f540-f779-446b-4411-8dae3a50d09d@yandex.ru> <837dvwtrv1.fsf@gnu.org> <835zbgtqps.fsf@gnu.org> <625de669-0715-1467-0bd1-84328b4bee5f@yandex.ru> <83wo3ws4g8.fsf@gnu.org> <83tuyzs2np.fsf@gnu.org> <87h7uuj1v3.fsf@mail.linkov.net> <87h7utjx75.fsf@mail.linkov.net> <3f9e85ba-66a9-abd0-61bf-800ea8bb4ee3@yandex.ru> <87eepw5nlt.fsf@mail.linkov.net> <83v9j7xpoj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39123"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 Cc: 41821@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 01 22:25:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jqjID-000A4q-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Jul 2020 22:25:17 +0200 Original-Received: from localhost ([::1]:55622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqjIC-0001Wj-Dq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Jul 2020 16:25:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqjI0-0001WX-Eb for bug-gnu-emacs@gnu.org; Wed, 01 Jul 2020 16:25:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jqjHy-0003mr-GM for bug-gnu-emacs@gnu.org; Wed, 01 Jul 2020 16:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jqjHy-0003IL-AW for bug-gnu-emacs@gnu.org; Wed, 01 Jul 2020 16:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Jul 2020 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41821 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 41821-submit@debbugs.gnu.org id=B41821.159363507012624 (code B ref 41821); Wed, 01 Jul 2020 20:25:02 +0000 Original-Received: (at 41821) by debbugs.gnu.org; 1 Jul 2020 20:24:30 +0000 Original-Received: from localhost ([127.0.0.1]:53769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqjHR-0003HY-S5 for submit@debbugs.gnu.org; Wed, 01 Jul 2020 16:24:30 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:50231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqjHP-0003HL-UX for 41821@debbugs.gnu.org; Wed, 01 Jul 2020 16:24:28 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id l17so23956074wmj.0 for <41821@debbugs.gnu.org>; Wed, 01 Jul 2020 13:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jxT+5xD3KphLkudnTh2AqwEXY73bXPYWN9cGS3YuOKE=; b=Bmdp/I8cEdA/rA1oujnOYeqMPdCub2t9eJHRedd2EClKFNMOZrYZJ1G8C3U48lyijL zt9Vx1WmoodMWLK0stkoLCN54e0Uac2GVau1NBRaxzpsEGHMlFE1M1ErmfozTuIphn3X YR5IXu/96WJWUdLOcUIUBWwga7RsMUt1nL6tHBWRckbnjmBJI0glz//U4/EBbUurMGBe wIiy7jhth9CWtXI9ITMVr5RR5gC9FakK6cxE6K+yKWknIQH1E8uIFl7++lqkwpp+mDa5 TF/RybC8xDtoqQxVMpT3xtug18v4eRvYt6iUTvDd1cFJnNa5ymM6HUfv0pfJnuweKABO SZFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jxT+5xD3KphLkudnTh2AqwEXY73bXPYWN9cGS3YuOKE=; b=gt4loXLnD5eGgQTY1PE4bellmJQh7bjrn+4U+hOIHIFgc4r6ZPsnSQvKOiZN2vIrCJ 6yh5gJLwfsApDp5scKCovZWq3mKPwhe+hKetGTLDU6zcncjnQOPem7/0BBoGOYxjfeAW TD20FpBSClBYMc+mv6Jd/jVF3pzBIYqnVxUCu1pzJXfm82ZN6mu5fCUgZ3/MzF55M76E EtLZVBhrE+UaF/maJdYz45yWnE9S4b5qdLrrN2aBE8Y5K3IQSXMYsPKho05MizqnBeqg RNEvPBT3OXe6KKnpbYnY8OOZLeOwBAi013xh1b4ejkv3eiPJC4v+5DmCSCgXoHV9uNfs JYrA== X-Gm-Message-State: AOAM533MjWOq61zjJ3XNKLqKDfDVAk5q3vfCoFZMsh81DKmW6x+9JRTs vU0LDtoLpT0+Zs31db27FXs= X-Google-Smtp-Source: ABdhPJwJ9BoMW4b/nOflq1apyHXm9u1GZ94YdMVN+hQZNgHQU1fMcOtXDze77bISbjPHnW22lompfA== X-Received: by 2002:a1c:1d93:: with SMTP id d141mr27344453wmd.14.1593635061844; Wed, 01 Jul 2020 13:24:21 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id d13sm8260843wrn.61.2020.07.01.13.24.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 13:24:21 -0700 (PDT) In-Reply-To: <83v9j7xpoj.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182619 Archived-At: Hi Eli, On 01.07.2020 17:42, Eli Zaretskii wrote: > Like you, Dmitry, I'm a bit uneasy with mixing the two sets of > features. We should decide on some concept and try to stick to it; > right now, it seems to me that we prefer to have specialized commands > in project.el rather than inject project.el-specific nits into > commands outside project.el, which I think could be a slippery slope. In my previous message I drew a line, of sorts, where I think it's okay to suggest directories to search in in rgrep from known project roots. I do think it's okay. I'm not sure if I understand your position, because you say you agree, but then make a one-directional statement. > Why isn't that a better approach? I don't think it's wise to blur the > difference between using project.el features and the VC back-end > features that support them. If someone wants to use project.el in VC > commands, let them use project.el commands, not VC commands. That > way, Emacs will know that some kind of project is being worked on, and > could offer more targeted support for such users. Not sure that's going to result in optimal user experience. After all, simply having a copy of every command, but acting on a project, would make it 2x the number of commands. And project-rgrep, on the other hand, would probably search the current project root without prompting. Unlike the proposed change to rgrep, which only makes it a suggestion. Another long-term violation of your idea is the default definition of xref-backend-references. It uses the current project. You could say that mixes up abstractions as well, but it's just too handy to implement this way.