From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Newsgroups: gmane.emacs.bugs Subject: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Date: Thu, 22 Sep 2016 22:22:13 -0400 Message-ID: <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> References: <20160922231447.GA3833@odonien.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="52FwUwOAkXBg3MEvS2l8nr4D3NJNOeMIX" X-Trace: blaine.gmane.org 1474622782 23032 195.159.176.226 (23 Sep 2016 09:26:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Sep 2016 09:26:22 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 23 11:26:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnMkA-0003xL-F4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 11:26:06 +0200 Original-Received: from localhost ([::1]:42894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnMkA-0007Xy-8E for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 05:26:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnLJA-0001Gx-Cp for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 03:54:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnLJ4-0007Bo-F3 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 03:54:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnLJ4-0007Bi-B6 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 03:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bnLJ4-0005q3-5e for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 03:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2016 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24514 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24514-submit@debbugs.gnu.org id=B24514.147461718222349 (code B ref 24514); Fri, 23 Sep 2016 07:54:02 +0000 Original-Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 07:53:02 +0000 Original-Received: from localhost ([127.0.0.1]:33031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLI6-0005oO-Ic for submit@debbugs.gnu.org; Fri, 23 Sep 2016 03:53:02 -0400 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:35607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLI5-0005nt-9e for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 03:53:01 -0400 Original-Received: by mail-wm0-f46.google.com with SMTP id l132so15259395wmf.0 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 00:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=resent-from:resent-date:resent-message-id:resent-to:delivered-to :subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=+J/I/cshNjN4Cnbv/HPnUP88sIOe6a5ieO2K7ae/0ho=; b=mhroGECcEPoI1kKt54blLoB+l0EG+Y35UOydyzXUx48arH6K1L9nZ2jEZkM5xXHTo0 l3oCMGqjxAum7LCOEj1azcSxA8ZEpxcRjVNYq6rqNgsn9ayxE23Lv2/R199UhBIAlRnd kgTt9W/bxm4DWv10dkDsZrqlXNFZxwLok0M+IgEdDAFX4zy8j82wB14+q4LUtklWmiRl aNFGwK1HN8LKpLr32SLt/zBm88ggaaRVoc39DnCblKRUtuRikCX09dxpbF8Qf318KfSa s5Lu0xkLsQeJavhGPqLBxmNs6SofCIJI4qMN52BaECJtRCaDPGPVDPBtYIdIghDmfkHF LhNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:delivered-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=+J/I/cshNjN4Cnbv/HPnUP88sIOe6a5ieO2K7ae/0ho=; b=cL/qpkgAHppArIIVEQfTLVWm82QHdSO52UVG7hcyVSzgpE041LN5+54NJ4+ifxBCgL lgMPxeKKqDLWy0u1t63gQTLcIeZvY1A/67sREwRiCMnhBIgwow6YfF4aLyhrYMc5ApSI li/xYtdY5gfc/s5lrlgoVNEscYon/+hHSPHaNdERalJAl9pwukp+5wm55OJ0NrX1ucMw PCHZ0h788FiNCZMHP2P6u4LFhHRasdbSWO6G84eJPLoUtwvhlRL5ZSwpPjHuFIqo3Xvg OzDUkN+iw65S58T9p8CmneyygGfM1z0PhadOoWFN6mIIOw/ykSDIHT6IQ5CSoeYhJKOk GdTA== X-Gm-Message-State: AA6/9Rl/LLFIFT+Rqw6SfGgTz6OwncokV6ZB0kbVpmenwg9MpjF/X3jlrJ/1K5ArDdhjcw== X-Received: by 10.28.126.81 with SMTP id z78mr1512761wmc.13.1474617175404; Fri, 23 Sep 2016 00:52:55 -0700 (PDT) Original-Received: from localhost ([89.204.137.24]) by smtp.gmail.com with ESMTPSA id w71sm1755354wmw.17.2016.09.23.00.52.54 for <24514@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 00:52:55 -0700 (PDT) Resent-From: Vasilij Schneidermann Resent-Date: Fri, 23 Sep 2016 09:52:37 +0200 Resent-Message-ID: <20160923075237.GB612@odonien.localdomain> Resent-To: 24514@debbugs.gnu.org Original-Received: by 10.103.103.199 with SMTP id b190csp314682vsc; Thu, 22 Sep 2016 19:22:20 -0700 (PDT) X-Received: by 10.194.191.162 with SMTP id gz2mr4500049wjc.182.1474597340201; Thu, 22 Sep 2016 19:22:20 -0700 (PDT) Original-Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.10]) by mx.google.com with ESMTPS id kc2si5274334wjc.61.2016.09.22.19.22.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2016 19:22:20 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning clement.pit@gmail.com does not designate 212.227.17.10 as permitted sender) client-ip=212.227.17.10; Original-Received: from [18.189.53.55] ([18.189.53.55]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0LtG3f-1aqf8S1r4d-012oua for ; Fri, 23 Sep 2016 04:22:19 +0200 In-Reply-To: <20160922231447.GA3833@odonien.localdomain> X-Provags-ID: V03:K0:wl5/Io5oRtTvMBkXz8TNzYaDDjeZWf3DC+Tkis/YxSRcP30PI9o fn0Q6U9LpMfHOBcfIaNUYmiujAtXUgPzEe5oWC0xsQ+l7ZoDKfC50Ch42ZVugRg+TNPR1Wh ZqNBvTNFisaZ7jWi6rOFLL84Ppy2M1fk4K3BZjhr1KbuLYjiTY0qaQ9M20ffQTDaCzAVvLK Xqyo+Yy+F7SIyUy8S2Ptw== X-UI-Out-Filterresults: notjunk:1;V01:K0:C+7wQGNQZaA=:A60LU48N5wUNf6gFeiq/B/ Zt6/yqhNApIUh3JCg7k2Yu0ZlATWhzlLK+Ztlm/i+Jg2xEYVS4wz/HCvjEnXomeyDF1LJ54gd yycuUCGNuF7qxI8GmqT4nrk/Li+Lsr8Mnb503MJFIzXpLSRdkd1cJFOvwWbpxnk5tqpiwnfk0 orCmhKJ5fC8h1AWVfY+hDtDeuP3cqr/n/CcTPwgfACnnRHr0nsAfe/f7noeIqdz2K/BdG/2cg 03ESuLnH+AaRrp5ZilwnJ93cJlUEpwI/noscO40Vve9LJALFULqXVHmNI5j0h7x93mfoy/LMn JtumSflfmPH0owLRhwp3+WE8POwcLyM+PfS3y6S/PDbFcGq334nBJMy5+AZlnE7PR9Yy0K2Ts 70hlErn67NIg/LCK5l2RDGxj7ui1D6WrUFSTQKrNQM5YDWPqjSiMfiI3sLLz6IQFIqIvh2o73 RCbkkNDQqpLbB22ZAtaauSGWKO7O+1awa1bBwhLtGDq8Vd2nneosrntCrd44C2wDMFCgrI8j0 IabbiOeM449xIO1ssQW0aABO6RO0taH76GBlzlzNOavdGRT9z5ZUP8Pm18BZxhtI3P8gBSvKy lCF7AqYrWstqA1JyeJBqv+EPxlWCfaZ4+EvFubuPc9AL6gGLYlf/KiLyiKn6ocubr2hyKmXBT 24LDcwIF4Ya8jGwkHnjYPgTlsjjnsi/4qT8mccwjL3+SflDmOglOXgSCtMzFsVCHcXK0= X-TUID: h12R7O2Hf7Z1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123587 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --52FwUwOAkXBg3MEvS2l8nr4D3NJNOeMIX Content-Type: multipart/mixed; boundary="jjpc0sEhx6ogM41N7HK88GTpu7F005DQ8"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Vasilij Schneidermann Message-ID: <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> Subject: Re: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces References: <20160922231447.GA3833@odonien.localdomain> In-Reply-To: <20160922231447.GA3833@odonien.localdomain> --jjpc0sEhx6ogM41N7HK88GTpu7F005DQ8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable This looks great! I love it. And the patch looks very clean, too. But it scares me a bit. Some tools do depend on e.g. trimming a backtrac= e after printing it. Does edebug work with your patch, for example? I'm not sure what the right way to transition is. Maybe Emacs should let= Lisp programs access the backtraces in a structured way, and then backtr= ace printing would only be a user-facing facility (programs wouldn't use = the textual representation). Cheers, Cl=C3=A9ment. On 2016-09-22 19:14, Vasilij Schneidermann wrote: > I wrote a minimal patch that increases the overall consistency in a > backtrace buffer by printing the call stack frames as S-Expressions. >=20 > Before: >=20 > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t= ) > +(1 t) > eval((+ 1 t) nil) > eval-expression((+ 1 t) nil) > call-interactively(eval-expression nil nil) > command-execute(eval-expression) >=20 > After: >=20 > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t= ) > (debug error (wrong-type-argument number-or-marker-p t)) > (+ 1 t) > (eval (+ 1 t) nil) > (eval-expression (+ 1 t) nil) > (funcall-interactively eval-expression (+ 1 t) nil) > (call-interactively eval-expression nil nil) > (command-execute eval-expression) >=20 > Now, this patch isn't perfect. For some reason there's an extra debug > line in the second version, I've yet to investigate into the reason for= > this. The other problem is that while I can't imagine any reason to go= > back to the original view of the backtrace, I cannot rule out that this= > change might break other tools relying on it. I'd appreciate any > feedback on this. >=20 --jjpc0sEhx6ogM41N7HK88GTpu7F005DQ8-- --52FwUwOAkXBg3MEvS2l8nr4D3NJNOeMIX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX5JHaAAoJEPqg+cTm90wjRXcP/1dK4WyvnAzCuN41Dn5HHFjq fXqE3UMXUjOd1faZfTALJIZ8sBx4svMaTLIjl5HetUJ8+RVwBuXhs1rkevdVHvSi +t1I6y5ubp+12vpOdeVbn8PX8baDBNf4c1CTzHc2agksqJXSwPN2UaJSjgHpxLTf 2r7pv2jSX6d4z+SgVAxD1r8rAhgawpVcFP1xzxZ2ibBRGI1Stt3c51y7RmBeIpSL QAAwAbPMDKUcmeA2TT4OrBoggqcc1YI2pQFklfkTcN3d2cDK/R7599/Sw+p9z8Rf ZiijVbFHOz8dB2bdfLWmiy2RwMUBMlxdDloezGDyEfyxaK1X2OckE/ZSfF1FqgOW sao692T362ln24tsDhahxa98dDNCTYYOgsmJtk1Gl6qLMgCweQ5RXKYZZ/93MbXV 4BoE/b0k/KLN+8A6GyJ6cWQIYupWe/KN78rbpP3zmr/zt1TX2z/zZmrlojz4hCVu xWeqpkgIBk/2PghEDRgvrC8o4AkcYnsKf2qsA18V+hbspZJK854spYTamUTlp3Ly eohZrp2zPPfqVIi4sg3NhUR5JFglqWgFD8AbuHgDoUYxdT0jdtzz1Jtp38MzDxUR C0+83YiiNEDm2u6ROzok7rXZK/YYB4AJ32vYfX53w0v6IWUNqbjhZGZVzeKCIMWu qClFgVVi9Px5I9tF14zq =SRcr -----END PGP SIGNATURE----- --52FwUwOAkXBg3MEvS2l8nr4D3NJNOeMIX--