* bug#14041: XTring_bell() does not work in some Linux distributions
@ 2013-03-23 10:38 PV
2013-03-25 18:01 ` Jan Djärv
0 siblings, 1 reply; 4+ messages in thread
From: PV @ 2013-03-23 10:38 UTC (permalink / raw)
To: 14041
Hi,
In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
but the function gdk_beep() is not,
thus I suggest to modify XTring_bell () in xterm.c in the following way:
/* Make audible bell. */
void
XTring_bell ()
{
struct frame *f = SELECTED_FRAME ();
if (FRAME_X_DISPLAY (f))
{
#if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
if (visible_bell)
XTflash (f);
else
#endif
{
BLOCK_INPUT;
#ifdef USE_GTK // P.VINCENT
gdk_beep (); // P.VINCENT
#else // P.VINCENT
XBell (FRAME_X_DISPLAY (f), 0);
XFlush (FRAME_X_DISPLAY (f));
#endif // P.VINCENT
UNBLOCK_INPUT;
}
}
}
Best regards,
Patrick VINCENT
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#14041: XTring_bell() does not work in some Linux distributions
2013-03-23 10:38 bug#14041: XTring_bell() does not work in some Linux distributions PV
@ 2013-03-25 18:01 ` Jan Djärv
2013-03-26 13:07 ` Petr Hracek
0 siblings, 1 reply; 4+ messages in thread
From: Jan Djärv @ 2013-03-25 18:01 UTC (permalink / raw)
To: PV; +Cc: 14041-done
Hello.
This has been fixed in the trunk in another way.
Jan D.
23 mar 2013 kl. 11:38 skrev PV <frerot13@gmail.com>:
> Hi,
>
> In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
> Windowing system distributor `The X.Org Foundation', version 11.0.10707000
>
> The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
> but the function gdk_beep() is not,
> thus I suggest to modify XTring_bell () in xterm.c in the following way:
>
>
> /* Make audible bell. */
>
> void
> XTring_bell ()
> {
> struct frame *f = SELECTED_FRAME ();
>
> if (FRAME_X_DISPLAY (f))
> {
> #if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
> if (visible_bell)
> XTflash (f);
> else
> #endif
> {
> BLOCK_INPUT;
> #ifdef USE_GTK // P.VINCENT
> gdk_beep (); // P.VINCENT
> #else // P.VINCENT
> XBell (FRAME_X_DISPLAY (f), 0);
> XFlush (FRAME_X_DISPLAY (f));
> #endif // P.VINCENT
> UNBLOCK_INPUT;
> }
> }
> }
>
> Best regards,
> Patrick VINCENT
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#14041: XTring_bell() does not work in some Linux distributions
2013-03-25 18:01 ` Jan Djärv
@ 2013-03-26 13:07 ` Petr Hracek
2013-03-26 14:52 ` Jan Djärv
0 siblings, 1 reply; 4+ messages in thread
From: Petr Hracek @ 2013-03-26 13:07 UTC (permalink / raw)
To: 14041, jan.h.d, frerot13
Hello Jan,
we have already emacs version 24.2 in which that patch included
especially function XTring_bell() (xterm.c) in another way.
What is a bug number for that case?
Where there any another files modified?
best regards
Petr
On 03/25/2013 07:01 PM, Jan Djärv wrote:
> Hello.
>
> This has been fixed in the trunk in another way.
>
> Jan D.
>
> 23 mar 2013 kl. 11:38 skrev PV <frerot13@gmail.com>:
>
>> Hi,
>>
>> In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
>> Windowing system distributor `The X.Org Foundation', version 11.0.10707000
>>
>> The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
>> but the function gdk_beep() is not,
>> thus I suggest to modify XTring_bell () in xterm.c in the following way:
>>
>>
>> /* Make audible bell. */
>>
>> void
>> XTring_bell ()
>> {
>> struct frame *f = SELECTED_FRAME ();
>>
>> if (FRAME_X_DISPLAY (f))
>> {
>> #if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
>> if (visible_bell)
>> XTflash (f);
>> else
>> #endif
>> {
>> BLOCK_INPUT;
>> #ifdef USE_GTK // P.VINCENT
>> gdk_beep (); // P.VINCENT
>> #else // P.VINCENT
>> XBell (FRAME_X_DISPLAY (f), 0);
>> XFlush (FRAME_X_DISPLAY (f));
>> #endif // P.VINCENT
>> UNBLOCK_INPUT;
>> }
>> }
>> }
>>
>> Best regards,
>> Patrick VINCENT
>>
>>
>
>
>
--
S pozdravem / Best regards
Petr Hracek
Red Hat Czech s.r.o.
BaseOS Core Services Brno
Email: phracek@redhat.com
Web: www.cz.redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#14041: XTring_bell() does not work in some Linux distributions
2013-03-26 13:07 ` Petr Hracek
@ 2013-03-26 14:52 ` Jan Djärv
0 siblings, 0 replies; 4+ messages in thread
From: Jan Djärv @ 2013-03-26 14:52 UTC (permalink / raw)
To: Petr Hracek; +Cc: frerot13, 14041
Hello.
26 mar 2013 kl. 14:07 skrev Petr Hracek <phracek@redhat.com>:
> Hello Jan,
>
> we have already emacs version 24.2 in which that patch included
> especially function XTring_bell() (xterm.c) in another way.
> What is a bug number for that case?
>
> Where there any another files modified?
>
I don't understand what you are trying to say.
24.2 does not have any patch to XTring_bell.
Files modified can be seen by browsing the bzr repository, in this case http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/112131.
Jan D.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-26 14:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-23 10:38 bug#14041: XTring_bell() does not work in some Linux distributions PV
2013-03-25 18:01 ` Jan Djärv
2013-03-26 13:07 ` Petr Hracek
2013-03-26 14:52 ` Jan Djärv
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).