From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73407: 31.0.50; Add diff-discard-hunk Date: Tue, 24 Sep 2024 01:52:13 +0300 Message-ID: <98752a7f-d4cd-4397-ad43-0807e29f7803@yandex.ru> References: <87jzf58g2t.fsf@zephyr.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24565"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: juri@linkov.net To: Sean Whitton , 73407@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 24 00:53:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssrvP-0006CT-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Sep 2024 00:52:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssrv8-0005Y9-5U; Mon, 23 Sep 2024 18:52:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssrv5-0005Xu-4Z for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 18:52:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssrv4-0005G8-RY for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 18:52:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=rbAcYJEsW3MTUagjtoEdww7s+NCgB13tNjP6yV3a+RI=; b=uZlnhwg588DHZlbcNoUaoaQcroVQNqRWhknmBuNBboYFZIQCaOuHpplQVAjAgS0WLJzLUynOmD4nyvjVVChgX6iTPnNLLQmVL4tVyJ3QUd1KjpGBMy+dKj5gmByZSek3AhPmCN2MbMcC37Vol6G3bUdexBaztYGrkt0hDjIq/R4tNzRZEL2NeJslbb9UtJxHVzflKLzoL9cEXf+NrYLo0PZdn4DdleUH8Tkk2VlShKghVlhNB+Y6nv1noMkOdOIiqxy9eRCtcM065ox1nmXIOovn5w9zl9MYEPV08S9nb7iMnuRtv1YTbN97MM5tLn1rjqQIz1xLUfO5SdMzDJya+Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ssrvS-0003e4-BS for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 18:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Sep 2024 22:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73407 X-GNU-PR-Package: emacs Original-Received: via spool by 73407-submit@debbugs.gnu.org id=B73407.172713196913982 (code B ref 73407); Mon, 23 Sep 2024 22:53:02 +0000 Original-Received: (at 73407) by debbugs.gnu.org; 23 Sep 2024 22:52:49 +0000 Original-Received: from localhost ([127.0.0.1]:44903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssrvE-0003dQ-Jd for submit@debbugs.gnu.org; Mon, 23 Sep 2024 18:52:48 -0400 Original-Received: from forward500a.mail.yandex.net ([178.154.239.80]:40082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssrvC-0003dH-94 for 73407@debbugs.gnu.org; Mon, 23 Sep 2024 18:52:47 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-90.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-90.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:29aa:0:640:d0e8:0]) by forward500a.mail.yandex.net (Yandex) with ESMTPS id 292446116E; Tue, 24 Sep 2024 01:52:21 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-90.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id IqbsUaUOga60-ccOU0M0H; Tue, 24 Sep 2024 01:52:20 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1727131940; bh=rbAcYJEsW3MTUagjtoEdww7s+NCgB13tNjP6yV3a+RI=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=r+6SJ638KaGaBjL6bGzerAOYAVbHsAkOcM4WpB0zm5k9pjmnqTb3EdyeJ6FVhO7qN JM/egc+W05cXuV0UId+dkZpbMiC8luNqqqGvesBj7PT1Z2I/+6UZZ0xEVv0uopM4Nu K5hpExYbuSOMaM5Lth2rngbB2Mtceckd9iGf+8j4= Authentication-Results: mail-nwsmtp-smtp-production-main-90.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfauth.phl.internal (Postfix) with ESMTP id 16D331200070; Mon, 23 Sep 2024 18:52:17 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Mon, 23 Sep 2024 18:52:18 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddttddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvgigrd hruheqnecuggftrfgrthhtvghrnhepiefhjeeuveetffffvdefteffffekhfeuudejieeh heeiudelgfehgffffeduffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqddufeeffeelleehhedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnhguvg igrdhruhesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtthhopeefpdhmohguvgep shhmthhpohhuthdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrd hnrghmvgdprhgtphhtthhopeejfeegtdejseguvggssghughhsrdhgnhhurdhorhhgpdhr tghpthhtohepjhhurh X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 Sep 2024 18:52:16 -0400 (EDT) Content-Language: en-US In-Reply-To: <87jzf58g2t.fsf@zephyr.silentflame.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292298 Archived-At: Hi! On 21/09/2024 13:19, Sean Whitton wrote: > X-debbugs-cc: dgutov@yandex.ru, juri@linkov.net > > These patches add a new command, diff-discard-hunk, inspired by some > functionality from Magit. It nicely complements a workflow based around > committing with C-x v v from C-x v D. I have been using it every day > for a year or so, and I think others will find it useful, too. I'd like to clarify one thing first: for 'C-x v v' to work correctly in a diff buffer (such as one produced by 'C-x v D') you don't have to synchronize any changes in that buffer back to disk before making the commit. In fact, we went to some effort to make this a non-requirement. So when you just want to edit the patch before the commit, you can do so already, for example using 'M-k' (diff-hunk-kill) - or just 'k' if the buffer is read-only. But of course if the idea is to really "discard" some changes, that works.