From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23769: 25.0.95; Mode Line breakage in vc-git Date: Thu, 16 Jun 2016 00:02:12 +0300 Message-ID: <9856a1e4-be41-d781-bfbd-22bac360d18b@yandex.ru> References: <87a8ioyq9o.fsf@russet.org.uk> <87wplr1z4z.fsf@russet.org.uk> <91e61a46-b3bb-c4d9-cb30-bbfa90135d69@yandex.ru> <877fdqkwki.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1466024612 1355 80.91.229.3 (15 Jun 2016 21:03:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2016 21:03:32 +0000 (UTC) Cc: 23769@debbugs.gnu.org To: Phillip Lord Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 15 23:03:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDHxz-0001B1-NH for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jun 2016 23:03:15 +0200 Original-Received: from localhost ([::1]:45090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDHxy-0007SQ-Tn for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jun 2016 17:03:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDHxr-0007S9-V5 for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 17:03:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDHxm-0005jk-UN for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 17:03:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDHxm-0005jf-Qs for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 17:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDHxm-0001V4-Dg for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 17:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2016 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23769-submit@debbugs.gnu.org id=B23769.14660245435718 (code B ref 23769); Wed, 15 Jun 2016 21:03:02 +0000 Original-Received: (at 23769) by debbugs.gnu.org; 15 Jun 2016 21:02:23 +0000 Original-Received: from localhost ([127.0.0.1]:42643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDHx8-0001UA-RJ for submit@debbugs.gnu.org; Wed, 15 Jun 2016 17:02:23 -0400 Original-Received: from mail-wm0-f47.google.com ([74.125.82.47]:37677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDHx6-0001Ty-PT for 23769@debbugs.gnu.org; Wed, 15 Jun 2016 17:02:21 -0400 Original-Received: by mail-wm0-f47.google.com with SMTP id a66so29947721wme.0 for <23769@debbugs.gnu.org>; Wed, 15 Jun 2016 14:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=xqDtoba8/Tqj3D/+1udT+EIAGDS6bRFASeWb20kaBpI=; b=L7/jXK5rWkPBjxQXfHSURXYQDrVYrNnKrZA2Z5D3x7S8uy3y4N8cX/Iwc8hyM4Dx3H oXobCXjiih7/n4P3AsYTDKtj+Bn8/4UDoKaa+paPnt+j0EjWBsOHEFb5wTyG6xsDkcX1 tlrhyn8JeUXru2/OkMNoBfhU0qD0TayZJYBzFSwv7SeZvjVlyWpznBdupPrOqc47msGV xKTz+FR/29Jqu95qtNGB98iD96YRSJBKs2kAZvtoXwk3Se57vHI/U76tuCbueofB/fXB VeHD7fMIwb2h2wAVjom7OTZH/8Bh45ItpgCpu1g+bLZEX2DiL3mpouhEPlQm7pFJh9vk cGAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xqDtoba8/Tqj3D/+1udT+EIAGDS6bRFASeWb20kaBpI=; b=DMMRKHdFFSnoIgBRRlmJTb9GDKg3R//YYQlJUC+4IGm2eeCwfc+qmgtxxca5jgiP+7 0fyFlbMl98pMXHYnK4J097lPzso9qrrSBAETIhHvSB//R6+OQ6rQQYqCPiifrcVuXnoY FH36tYGMEbIShhSkkiwQe8gibTLAtvm7cicDN+FBwwpRTZRnjxANmTjZ+8YfuWTvxf8E Kxbbf7sY8+ixBQQM0QCvlpI/+tAHvFl3ZUm2wzkgEI2oMIA9BTFZSH38N7TIkOyDF5FM JxVo3aBjqQkt6ioexrQz+wPn3Ow9mKzW34RrEFSMwPosBsJ+GZzhGsG6W1vEi4ZKLngs Lubw== X-Gm-Message-State: ALyK8tJOgygjzdXOtwXOOTyUEmifDn7//v4syectlGicqtq4sf+20SVcDaGLQIfZd/fUuQ== X-Received: by 10.194.150.130 with SMTP id ui2mr544713wjb.11.1466024534912; Wed, 15 Jun 2016 14:02:14 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id db6sm40235189wjb.2.2016.06.15.14.02.13 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Jun 2016 14:02:14 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 In-Reply-To: <877fdqkwki.fsf@russet.org.uk> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119602 Archived-At: On 06/15/2016 11:48 PM, Phillip Lord wrote: > I've noticed from instrumenting vc-git that it's not just the > symbolic-ref command that returns 128, but several others. So, it might > be that the best long term solution would be to make change vc-git--call > to set the default directory to the root, which would make GIT_DIR=.git > always correct. The patch looks wrong. Why does the problem script set GIT_DIR to '.git'? In all examples I've found, this variable is set to an absolute value. In general, its purpose, it seems, is to point to the '.git' directory when it's named otherwise and/or is situated somewhere outside of the current directory tree. The latter situation will break vc-git-root. As such, the submitted patch is only likely to work in the tautological case you've descried. And it will add some performance penalty to each call, because vc-git-root, though usually fast, is not free. > At the moment, though, I've noticed some git commands are called with > simple file names, and some full, so this would probably require more > changes. Indeed.