From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Mon, 18 Nov 2024 18:10:02 +0200 Message-ID: <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="941"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 18 17:11:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tD4LW-000Ac6-Qa for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Nov 2024 17:11:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tD4LB-00057s-9L; Mon, 18 Nov 2024 11:11:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD4L8-00057L-MP for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 11:11:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tD4L8-00018d-Dd for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 11:11:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=vXSmgIi/v1IwbLQ///K57Kmw3/1C4Eb5m70+VFKnbak=; b=NxERO8y0TPNZq65Twah/qLhfahu3UIMIKgsaBahzW0tyYn+Lce1bzKZsnXlS/TM6tXioZPEgkcG3CrkZElelHvs04QFefdviiMwhvHCZUUrI5JzeNoO6+jIDFoDReNMdx/i/C8TBmB9Qed9OERYnQ7ZWQ3sGcndPgOiW/hDD2WjuMKrIRxkXAzOmWpkBlB12cALCgA/OZsQ+q+UfKI0wm/Vgt7+K0QnOzspf6GfFUjAtNboj03nAHoIt9t5GoUUno6zSRQKEr3zQ6Nlw79ERwJ5MfHaTLfbdI+TUc05sWx6BvHHCZkNcgGp5lx5Fh0pS39T0y4lJHg+YemhuXerYTA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tD4L7-000241-V2 for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 11:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2024 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.17319462177858 (code B ref 74361); Mon, 18 Nov 2024 16:11:01 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 18 Nov 2024 16:10:17 +0000 Original-Received: from localhost ([127.0.0.1]:34908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD4KO-00022e-Cy for submit@debbugs.gnu.org; Mon, 18 Nov 2024 11:10:16 -0500 Original-Received: from fout-a3-smtp.messagingengine.com ([103.168.172.146]:48015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD4KJ-0001y8-ML for 74361@debbugs.gnu.org; Mon, 18 Nov 2024 11:10:13 -0500 Original-Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id ADC7913806D5; Mon, 18 Nov 2024 11:10:05 -0500 (EST) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Mon, 18 Nov 2024 11:10:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1731946205; x=1732032605; bh=vXSmgIi/v1IwbLQ///K57Kmw3/1C4Eb5m70+VFKnbak=; b= syGyMDn4eLtRpB3NX+f/EnzCvzBGfyTit31ZBM78tVI2d06TvRNxRRQO1dCImtIz HbwpPS/jkMU1JYIptedxq4cjQ77s3jLOSie4dZS5FA7ChhFPz1BU3/SrcMCBr+1m TYmu49SYT81HxOkUsRjOuwvqvO+V3GSY8fOl7+u8cwwP/0YHehFTijyOY+UGonTL U9yNFpaot7scgNFe2HQn4jr8IEZs+o742gvJQzDSmfgWSrRQAiChDoQR++rR8DnV X9RzIIixjwtBM7TCG1FoF8W9CFCJpz9Jf7naVYdcHNZYn0VUQ3+5cXdHSYuTujLm 98OA/em9AEjtagAqCjnnSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731946205; x= 1732032605; bh=vXSmgIi/v1IwbLQ///K57Kmw3/1C4Eb5m70+VFKnbak=; b=g gkAep67YmA7jsm2zd5+LIREK9LQRfiS3I+rffhEdEsJ/F4Dq56ofrc1crgpppCYN 9+Sd2NTl2luGTrVi8bY8hY2GVjNnR8TFpb7QhqdTkR9laRt0cGhoRoSSwVpeUGoM PcaqPe4mSp6QNgJJ1xmPZbzdQo6pytA5ZLuyF5KozeumGpst42QeGXEDH6ByyJeG ytR+yb/WQsij+HgTATl/5lRBsdOZ2M6oBgls+MYxmMIVN5byB2Bvjv0jcoh/btHO oyUgHHTq1d2RyqRwbZh5pY2xdYHuXnxBp+yTCNjQPqVoGAXwuSIFOy/50yv4evoC 1nSYs3hhVekVHBEJzq74w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrfedtgdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeen ucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvg hvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedt vddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohep gedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpd hrtghpthhtoheprhhuuggrlhhitghssehgmhigrdgrthdprhgtphhtthhopeejgeefiedu seguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjhhurhhisehlihhnkhhovh drnhgvth X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Nov 2024 11:10:03 -0500 (EST) Content-Language: en-US In-Reply-To: <86ikskvie0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295601 Archived-At: On 18/11/2024 14:25, Eli Zaretskii wrote: >> Date: Mon, 18 Nov 2024 03:42:34 +0200 >> Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net >> From: Dmitry Gutov >> >> On 16/11/2024 10:43, Eli Zaretskii wrote: >>>> That's the term I would use both both, but maybe there could be better >>>> wording. If xref-find-definition is not a navigation command, is it a >>>> "search command"? >>> Let me turn the table and ask: which Xref commands will NOT use this >>> action, if we exclude commands like >>> xref-find-definitions-other-window, which specify the window/frame to >>> use? >> >> xref-query-replace-in-results will not (or its twin >> xref-find-references-and-replace). I suppose not many people would >> expect them to. > > This seems to indicate that my proposal is actually okay, since the > above two commands do not "show results of Xref commands"? IIUC your suggestion was: If non-nil, the `display-buffer' action for showing results of Xref commands. And those are commands belonging to the package (for the moment), and as such fitting the description. >> Also, there is a nuance: when the Xref buffer itself is shown (i.e. when >> there are multiple locations matching a xref-find-definitions search), >> we're not going to pass (category . xref) to display-buffer either - it >> is reserved for displaying the buffers of destination locations. > > And this is a separate issue, not related to the doc string? Still about the doc string. If we say "showing results of Xref commands", then the Xref buffer with the list of locations also matches that description, doesn't it? Or rather it might be the first thing a user would think of - but our customization wouldn't apply to it immediately. Note that this subthread might seem moot if we don't introduce a new option anyway, but somewhere we'd probably want to enumerate the cases which the 'xref' category applies to, and those would be the same.