From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47012: xref copies keymap properties to minibuffer Date: Sat, 3 Apr 2021 02:50:52 +0300 Message-ID: <977f95e6-4e83-c376-54b2-76bc64ef32b0@yandex.ru> References: <87czw9tnu9.fsf@mail.linkov.net> <3aad442a-7319-5db5-2fc6-560bb032c34d@yandex.ru> <87a6r9v24b.fsf@mail.linkov.net> <87sg4kb839.fsf@mail.linkov.net> <871rc3bls6.fsf@mail.linkov.net> <871rc2ly7x.fsf@mail.linkov.net> <4228b128-039c-2bcd-002c-5ac830d7a4d3@yandex.ru> <87pmzgtr80.fsf@mail.linkov.net> <186b46fa-3716-a76d-db85-09638d7805c7@yandex.ru> <87v99745jj.fsf@mail.linkov.net> <87zgyiv03f.fsf@mail.linkov.net> <4d3edf81-97d8-4e0e-51c0-7b2d71b57889@yandex.ru> <87o8exsv1p.fsf@mail.linkov.net> <83o8exg6za.fsf@gnu.org> <83blaxfcbb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20055"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: 47012@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 03 01:52:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSTaN-00057E-5s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Apr 2021 01:52:19 +0200 Original-Received: from localhost ([::1]:59266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSTaM-0007OS-7t for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Apr 2021 19:52:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSTa8-0007O7-Sn for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 19:52:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSTa6-0001ft-4t for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 19:52:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSTa6-0007uB-22 for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 19:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Apr 2021 23:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47012 X-GNU-PR-Package: emacs Original-Received: via spool by 47012-submit@debbugs.gnu.org id=B47012.161740746230316 (code B ref 47012); Fri, 02 Apr 2021 23:52:02 +0000 Original-Received: (at 47012) by debbugs.gnu.org; 2 Apr 2021 23:51:02 +0000 Original-Received: from localhost ([127.0.0.1]:33019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSTZ8-0007st-CU for submit@debbugs.gnu.org; Fri, 02 Apr 2021 19:51:02 -0400 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:55906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSTZ6-0007sQ-Fb for 47012@debbugs.gnu.org; Fri, 02 Apr 2021 19:51:00 -0400 Original-Received: by mail-wm1-f47.google.com with SMTP id 12so3103820wmf.5 for <47012@debbugs.gnu.org>; Fri, 02 Apr 2021 16:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=d+7v85WHyEMRUs0+pTjqU5fh3LKq80SJHOU4UAGAxHU=; b=P7Jp9AzKYJoxBnZiSVg7mS78UC2UzUofFJW7sHt11x5+VcVRePOWf2mI7Zw+nmKWu2 Lme4KK/HfyuQxSlU/mzGWSuWOmzAYF6u6JbBvvnINpn0yHpqN6IHJZB6E34U13CxNp6N 6AlLFwZ+vZLt4nYXHcnP64LNFpqK567qJY4ibZExqk2TtkWv7wyZrElGIF7IDU80NeH3 7jPSv/GtZM/nLlf30lSWtNcmLoba/6tuosnu6QYlPsJUCaUSPY3ndzw2rZAjNJyZVOMq 2IymdiDR5BvGwxBWpWVMIhNrO8QOdMUEeR2E06ixi0cZRt5EJxDuB+p1nXUtdb7Cty5q zqlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d+7v85WHyEMRUs0+pTjqU5fh3LKq80SJHOU4UAGAxHU=; b=qzy33CM39GsZCjAd3ZHri4cKaa34+uYxxFPhcxUNiLYDEopwqCLWPfHCUH4Dq7Fajt jcwLZ6t7yyZ9Tl2pnHdY6ymx3UWa1ki+/wcNabSvdmAFYz+v7sxCDUV/G6CrDRNiPvPR zv+Fjk1PW2nuBjLNaZX660S+k8t2qJKeZbX9/xk+SNsMC+ClaxP6IhKhWiiu2WhB5pvT OdrUqEWXbX3fpb13bv2djyw8B2bgTFNIZ8ngoPdeoJpiGJjZtTqZh8nQDY0BP+xilp1y H+SsbeX6Hf5z59qxYaq0ieGPpsGY95+TnAbqg5iAmIg+HvaAIkOStV0MugkqLws26xK+ sNsg== X-Gm-Message-State: AOAM530RuX3kN3iLOnq1V/1Z/YiHh4V1weYFTDx1eV3XXCqnBWF8v20h p0DabqKTlnbcbYl6bFa2msI= X-Google-Smtp-Source: ABdhPJx1JoNFlguglAuqvYWZ3PmcuXibksBhM3DpS+VoQheju+tkbWpIfR2xDBw9vAP0zCuZTj+Hxw== X-Received: by 2002:a05:600c:2312:: with SMTP id 18mr14573599wmo.8.1617407454490; Fri, 02 Apr 2021 16:50:54 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o7sm16521516wrs.16.2021.04.02.16.50.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Apr 2021 16:50:54 -0700 (PDT) In-Reply-To: <83blaxfcbb.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203482 Archived-At: On 02.04.2021 09:08, Eli Zaretskii wrote: >> Did you like any of the options I suggested? > > I didn't try them, and re-reading the thread now I don't think I > understand which options are you referring to here. There was one > suggestion, to add the bold attribute to the existing face, which you > later retracted because that face is already bold, but I see no other > concrete suggestions for changes in that face. What am I missing? > Could you please list those options for which you'd like my opinion? See bug#47574 for a self-contained explanation. >>> In general, when discussing faces used by some feature (in this case >>> Xref and project.el), please don't change the defaults of unrelated >>> faces, let alone more general ones. >> >> I agree it should be a separate change/discussion. >> >> Should we continue that in a new bug report or on emacs-devel? > > If it's an important issue, probably the latter. Important enough for me to file a bug, but not to spend much time fighting over it. > If it's just a tool > to fix some other face, I'd prefer not to change Occur faces at all, > and instead find an independent way of doing TRT with Xref and/or > project.el faces. Yes, of course. I'm suggesting to change the 'match' face definition because I think all its uses will benefit from it (including Occur and Grep which I made sure to try with all proposed colors). 'xref-match' face is customizable separately, but I don't think it will be productive to change only it but not 'match'. The faces are used similarly enough, so it's hard to justify making them look different in the default configuration.