From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Mark Hepburn" Newsgroups: gmane.emacs.bugs Subject: bug#72681: 31.0.50; visual-wrap-prefix-mode interacts badly with plain lists in org-mode Date: Sun, 18 Aug 2024 10:02:57 +1000 Message-ID: <976ffa0e-fff3-42c4-951e-f82c91e81754@app.fastmail.com> References: <6aa9c901-b469-4d19-b86e-60ccccdf95fb@app.fastmail.com> <8634n362gv.fsf@gnu.org> <418fb258-c318-9aa2-8bd1-73b34611fb32@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=083ed6730d5d4157b74159aa195fe8f6 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10013"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72681@debbugs.gnu.org To: "Jim Porter" , "Eli Zaretskii" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 18 02:04:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfTPe-0002Sp-3W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Aug 2024 02:04:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfTPH-0000LC-8O; Sat, 17 Aug 2024 20:04:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfTPE-0000AI-Sk for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 20:04:25 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfTPE-0001v9-JR for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 20:04:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:MIME-Version:To:Subject; bh=czQu/jHWOkLRYK8mm2683lnR+qDSRUcSPOnCXVpkFm0=; b=brThB8VPyXXx3f2Iketa3aCRyW5thDGX/48FQpxuPD5ibfmeFouIlE9j6DP+DR6TnEDBvMUej7kCw3qWfRiKxWX7A1tw+m60YSCSLBqUT5Q5xBrKhmCFQ54kVkb+N2aRDdfScA//ncVm8TlmH5jxMvumFYqtlMFMxtU5lNiMY6ncsu+TQLFkzfg1cM0e9UnuQlJWTnetlF9STfcq9Uj0TjTg+8DHhzbkmYbBj7VTjgmOprRZ7hVe8gWHxdJisF7xy9SaLB/Zbt8HglXxNecZSFIY0B0nfdg4M+dgbFyvQ4aysuzWL0BYatfaUSuy6o8O3rgnAC245Ho51P4sz4j1HA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfTPq-0000v5-JB for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 20:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Mark Hepburn" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2024 00:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72681 X-GNU-PR-Package: emacs Original-Received: via spool by 72681-submit@debbugs.gnu.org id=B72681.17239394463458 (code B ref 72681); Sun, 18 Aug 2024 00:05:02 +0000 Original-Received: (at 72681) by debbugs.gnu.org; 18 Aug 2024 00:04:06 +0000 Original-Received: from localhost ([127.0.0.1]:55089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfTOv-0000th-RQ for submit@debbugs.gnu.org; Sat, 17 Aug 2024 20:04:06 -0400 Original-Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]:33489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfTOt-0000t6-Io for 72681@debbugs.gnu.org; Sat, 17 Aug 2024 20:04:04 -0400 Original-Received: from phl-compute-06.internal (phl-compute-06.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id D98001140154; Sat, 17 Aug 2024 20:03:18 -0400 (EDT) Original-Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-06.internal (MEProxy); Sat, 17 Aug 2024 20:03:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=markhepburn.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1723939398; x= 1724025798; bh=czQu/jHWOkLRYK8mm2683lnR+qDSRUcSPOnCXVpkFm0=; b=i J3K9lfODWYd3RHDmwAab2AVn7UUOzsalLfcBJ1lAcHAJeBfpaL4n7bNB5KGPH8sj qIX64R815dMmOkL0Mpvy56cDAew72b/KYPT/f5plXiZpXaAOlkfaI9OHfh7Kbnc1 m2BKwXRojZaCFG3lRsmjICP8Ai7Vk97L404cD+LENgqDQ3fvq0k4jCdKaryWKTfE 3VKZl0lBfBTCpp4GecUK2W16S9Z8b3im+djJnqSxvDz4LpQoZOZEMQSz1dMOgnoS ewnrxfetL5zMFIYlbhnEkXPTEdb1kLe3Ho7GBWitjL2oZqwCF76NLMj0zDeMjHpk j5apVYNoQ0ZrkAEjKxk8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1723939398; x=1724025798; bh=czQu/jHWOkLRYK8mm2683lnR+qDS RUcSPOnCXVpkFm0=; b=O+pbYSlHOz8HFDu3vYdKgEzIewZKWghY9K20DdJseXif 7fm8t8eJuAPnNIgMLfIx8wNWUBbZI1UpjZVS9aiBU4v5OtZXgi3uNefK7Q0n0CNB V716TrBwQVDfN0+J2frfwdjsjzH+cldRg5JUUVLYiniCSgzVh4L9YKz/rdACeO4K dTlUTYSLEhbsT7oGU+z1owRidTfSjtxU7s3F7/q0SrM4RkuFlmkNUuaow5/GSQw4 zTT8dRz87pxzcP7ZPhY9njY3skhmN6Ahgl0g8Ef+RL/IUno/dP8D4ifZWXoy5HA1 huyDG+7cRckvB0Vv6ek/FlRrarMeZk8waBKwX+kB2w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudduuddgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgesrgdtreerredttden ucfhrhhomhepfdforghrkhcujfgvphgsuhhrnhdfuceomhgrrhhksehmrghrkhhhvghpsg hurhhnrdgtohhmqeenucggtffrrghtthgvrhhnpeejkeejteduleevhedujeevgeelhfdt teekkeefheetffetleetkeeggfduhefhgeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrghrkhesmhgrrhhkhhgvphgsuhhrnhdrtghomhdp nhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjedvie ekudesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehjphhorhhtvghrsghu ghhssehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: id27146ce:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6EBD31C4005E; Sat, 17 Aug 2024 20:03:18 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <418fb258-c318-9aa2-8bd1-73b34611fb32@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290287 Archived-At: --083ed6730d5d4157b74159aa195fe8f6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks Jim, nice work -- yes that seems to work perfectly again for all = the problematic files I had before. Cheers, Mark. On Sun, Aug 18, 2024, at 6:29 AM, Jim Porter wrote: > On 8/17/2024 12:19 AM, Eli Zaretskii wrote: > > Jim, could you please look into this? Is visual-wrap-prefix-mode at > > all supposed to be used in Org buffers? >=20 > Yes, I think 'visual-wrap-prefix-mode' should support Org buffers. It'= s=20 > probably one of the more useful text-based modes where=20 > 'visual-wrap-prefix-mode' would be convenient. >=20 > It looks like this was just a small corner case in the visual-wrap cod= e=20 > for aligning prefix lines that didn't account for Org-Mode's custom=20 > 'adaptive-fill-function'. I've fixed this by being more careful to onl= y=20 > apply the 'min-width' display property to a single logical line. >=20 > Mark, does the attached patch fix things for you? It looks like it wor= ks=20 > in my tests, but maybe you have some more complicated test cases you'd=20 > like to try to verify this. >=20 > *Attachments:* > =E2=80=A2 0001-Be-more-careful-about-aligning-prefix-lines-in-visua.p= atch --083ed6730d5d4157b74159aa195fe8f6 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
Thanks Jim, nic= e work -- yes that seems to work perfectly again for all the problematic= files I had before.

Cheers, Mark.

On Sun, Aug 18, 2024, at 6:29 AM, Jim Porter wrote:=
On 8/17/20= 24 12:19 AM, Eli Zaretskii wrote:
> Jim, could you plea= se look into this?  Is visual-wrap-prefix-mode at
>= ; all supposed to be used in Org buffers?

Y= es, I think 'visual-wrap-prefix-mode' should support Org buffers. It's&n= bsp;
probably one of the more useful text-based modes wher= e 
'visual-wrap-prefix-mode' would be convenient.
=

It looks like this was just a small corner cas= e in the visual-wrap code 
for aligning prefix lines = that didn't account for Org-Mode's custom 
'adaptive-= fill-function'. I've fixed this by being more careful to only 
<= /div>
apply the 'min-width' display property to a single logical lin= e.

Mark, does the attached patch fix things= for you? It looks like it works 
in my tests, but ma= ybe you have some more complicated test cases you'd 
= like to try to verify this.

Attachments:=
  • 0001-Be-more-careful-about-aligning-prefix-lines-i= n-visua.patch

--083ed6730d5d4157b74159aa195fe8f6--