From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51665: 28.0.50; [PATCH] Get electric-tests to pass Date: Sun, 7 Nov 2021 10:31:50 -0800 Message-ID: <975de290-b8d7-b40a-715e-afe544623a93@gmail.com> References: <877ddk9bve.fsf@dick> <87o86wexxj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------A91649C1AE5D89708E24F7D2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4597"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51665@debbugs.gnu.org To: Lars Ingebrigtsen , dick.r.chiang@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 07 19:32:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjmxf-0000ui-6q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 19:32:11 +0100 Original-Received: from [::1] (port=52050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjmxd-0008Ml-9i for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 13:32:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjmxX-0008MP-2Q for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 13:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43154) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjmxW-0005F7-Px for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 13:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjmxW-0007oa-Dc for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 13:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Nov 2021 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51665 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51665-submit@debbugs.gnu.org id=B51665.163630992130031 (code B ref 51665); Sun, 07 Nov 2021 18:32:02 +0000 Original-Received: (at 51665) by debbugs.gnu.org; 7 Nov 2021 18:32:01 +0000 Original-Received: from localhost ([127.0.0.1]:54700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjmxU-0007oJ-MX for submit@debbugs.gnu.org; Sun, 07 Nov 2021 13:32:00 -0500 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:54872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjmxS-0007o3-8V for 51665@debbugs.gnu.org; Sun, 07 Nov 2021 13:31:59 -0500 Original-Received: by mail-pj1-f47.google.com with SMTP id np3so6518252pjb.4 for <51665@debbugs.gnu.org>; Sun, 07 Nov 2021 10:31:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=UWrQV/gpK06tp6ht3SGsQhjern4apqzECKe3CJI+uk0=; b=KLcTb0M8TlpQtESsh1ll3NP+buA6FgBsFx7YoMpr4Av9ucflYO36zpcWx8/H2seQt4 9emL6+YuUk0QR3QphlddJHocVsRh+wYj2SDFl1y61eBR17DPFcxEv522ymxA6/4LSaZs Yirp3IEw1FMrtUhZdn/H0jUTU0oQ+D7Zskrlr8dUailEgpbqgfBmGBeNLe/xJZsAyerZ ckL+NfReh8YW6swejJ+fxk6k/XwrCUNEXtbplFbQcvQ0pv/Di5wSYnfgj3q8hSJkWC7y 48cCobIp/HN/9pzfaOLJt8+e7GNkrUdnUfXVltCTMX/5yO/xa9da/BGUcKxb8d2aLsf8 N5gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=UWrQV/gpK06tp6ht3SGsQhjern4apqzECKe3CJI+uk0=; b=XE4Ki3YW6axscufGDYJmWfx4mxwYsga8KWL2JnZWLiLAz0ekF4YXc23osflZPzQiP2 GY014OyVzlw10bRLKMLx7InJazAeVljry3PS0bD1LjwUjcPX/LtDi8tp/t4sp8N+0fiF P8X60QoF16tUaLJBkHow9CibgC/hEtgwX9Q4ZwZ9YsXT09P7hY3VJyA29QK/y/h25sOq FK9hdTbL7W+T0gSzRkq8GG7lTpnhfECfM762kqU4+ot45kibjcdtBoUR0mFnE51iNlmI 7BOY8OtmfemNq7wIp8ZnyXgDdf8n+etlA6C5sYF+5xq2+7u3jTC7edqvphecb8WZfUKJ B/Mw== X-Gm-Message-State: AOAM531aVSbTgHhCTINW6gAtwW9zTAfKbHZ2nxyRt7Zu+4b20OPXeUEi 6Fa1GcPEq1HMO1N8mk4dgXijQnGzTIE= X-Google-Smtp-Source: ABdhPJynebbWBb5DfFm7VG0yMWky6Y5EH980udj3fg+4CRfQUIOwTaowyQv584G2Yj4dlrzQpyIXDA== X-Received: by 2002:a17:90a:4e02:: with SMTP id n2mr41955645pjh.170.1636309912313; Sun, 07 Nov 2021 10:31:52 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id y130sm7744871pfg.202.2021.11.07.10.31.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Nov 2021 10:31:51 -0800 (PST) In-Reply-To: <87o86wexxj.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219277 Archived-At: This is a multi-part message in MIME format. --------------A91649C1AE5D89708E24F7D2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 11/7/2021 8:24 AM, Lars Ingebrigtsen wrote: > dick.r.chiang@gmail.com writes: > >> Subject: [PATCH] electric-tests can no longer by byte compiled > > Isn't that the bug, though? We've been trying to find out why. I've been tinkering with this and I *think* the issue is with the hook I added at global scope: (add-hook 'c-mode-hook (lambda () (c-toggle-comment-style -1))) In the attached patch, I moved this into a fixture function for the `whitespace-chomping-dont-cross-comments' test and it works for me (i.e. electric-tests pass both with and without byte-compilation). Hopefully this resolves the issue, though I'm unclear on *why* this was occurring in the first place; maybe there's a bug in the byte-compiler...? (As an aside, I vaguely recall adding that hook at global scope because multiple tests failed without it, but it was a while since I wrote that patch and I may be misremembering. In any case, it seems that at least today, changing the comment style is only needed for that one test, so I think it makes sense to do it in a fixture solely for that test.) --------------A91649C1AE5D89708E24F7D2 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-electric-tests.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-electric-tests.patch" RnJvbSA2ZGYwNDc1MTgxNmYyNjgxMjRiM2ZhYjE5ZWY1YzlkMmNkOTgzMDAyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgNyBOb3YgMjAyMSAxMDoyMjo1NCAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIDsgRml4IGVsZWN0cmljLXRlc3RzCgoqIHRlc3QvbGlzcC9lbGVjdHJpYy10ZXN0cy5l bAood2hpdGVzcGFjZS1jaG9tcGluZy1kb250LWNyb3NzLWNvbW1lbnRzKToKTW92ZSAnYy10 b2dnbGUtY29tbWVudC1zdHlsZScgdG8gaGVyZS4KLS0tCiB0ZXN0L2xpc3AvZWxlY3RyaWMt dGVzdHMuZWwgfCA3ICsrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyks IDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VsZWN0cmljLXRlc3Rz LmVsIGIvdGVzdC9saXNwL2VsZWN0cmljLXRlc3RzLmVsCmluZGV4IDY4NjY0MWMxYjMuLjFl MzJkYmZiNjAgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lbGVjdHJpYy10ZXN0cy5lbAorKysg Yi90ZXN0L2xpc3AvZWxlY3RyaWMtdGVzdHMuZWwKQEAgLTMyLDkgKzMyLDYgQEAKIChyZXF1 aXJlICdlbGVjLXBhaXIpCiAocmVxdWlyZSAnY2wtbGliKQogCi07OyBXaGVuIHJ1bm5pbmcg dGVzdHMgaW4gYy1tb2RlLCB1c2Ugc2luZ2xlLWxpbmUgY29tbWVudHMgKC8vKS4KLShhZGQt aG9vayAnYy1tb2RlLWhvb2sgKGxhbWJkYSAoKSAoYy10b2dnbGUtY29tbWVudC1zdHlsZSAt MSkpKQotCiAoZGVmdW4gY2FsbC13aXRoLXNhdmVkLWVsZWN0cmljLW1vZGVzIChmbikKICAg KGxldCAoKHNhdmVkLWVsZWN0cmljIChpZiBlbGVjdHJpYy1wYWlyLW1vZGUgMSAtMSkpCiAg ICAgICAgIChzYXZlZC1sYXlvdXQgKGlmIGVsZWN0cmljLWxheW91dC1tb2RlIDEgLTEpKQpA QCAtNDMxLDcgKzQyOCw5IEBAIHdoaXRlc3BhY2UtY2hvbXBpbmctZG9udC1jcm9zcy1jb21t ZW50cwogICA6YmluZGluZ3MgJygoZWxlY3RyaWMtcGFpci1za2lwLXdoaXRlc3BhY2UgLiBj aG9tcCkpCiAgIDp0ZXN0LWluLXN0cmluZ3MgbmlsCiAgIDp0ZXN0LWluLWNvZGUgbmlsCi0g IDp0ZXN0LWluLWNvbW1lbnRzIHQpCisgIDp0ZXN0LWluLWNvbW1lbnRzIHQKKyAgOmZpeHR1 cmUtZm4gKGxhbWJkYSAoKSAod2hlbiAoZXEgbWFqb3ItbW9kZSAnYy1tb2RlKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGMtdG9nZ2xlLWNvbW1lbnQtc3R5bGUgLTEpKSkpCiAK IChkZWZpbmUtZWxlY3RyaWMtcGFpci10ZXN0IHdoaXRlc3BhY2Utc2tpcHBpbmctZm9yLXF1 b3Rlcy1ub3Qtb3V0c2lkZQogICAiICBcIiAgXCIiICJcIi0tLS0tIiA6ZXhwZWN0ZWQtc3Ry aW5nICJcIlwiICBcIiAgXCIiCi0tIAoyLjI1LjEKCg== --------------A91649C1AE5D89708E24F7D2--