From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable'? Really? Date: Mon, 13 Sep 2021 09:11:11 +0000 Message-ID: <97113ce8badac94c846f@heytings.org> References: <97d3ff2c-9e72-4004-88a9-08130ac99a74@default> <87v93avtoe.fsf@gnus.org> <87r1dyvtav.fsf@gnus.org> <87mtolx6de.fsf@gnus.org> <87ilz9x5c8.fsf@gnus.org> <87y284rb1z.fsf@gnus.org> <0d48a23084a8b0435f37@heytings.org> <83h7eqf9wx.fsf@gnu.org> <0d48a230848de1d1b255@heytings.org> <83ee9uf82a.fsf@gnu.org> <0d48a23084cf7a569554@heytings.org> <83czpef6hj.fsf@gnu.org> <0d48a2308486fe146f77@heytings.org> <87a6khj6s5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18623"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 21695@debbugs.gnu.org, hmelman@gmail.com, rms@gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 13 11:12:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPi0Z-0004aU-B3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 11:12:11 +0200 Original-Received: from localhost ([::1]:50366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPi0X-00051D-OM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 05:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPi0Q-000514-TZ for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 05:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPi0Q-00081k-Lo for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 05:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPi0Q-00038H-86 for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 05:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Sep 2021 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21695 X-GNU-PR-Package: emacs Original-Received: via spool by 21695-submit@debbugs.gnu.org id=B21695.163152427711976 (code B ref 21695); Mon, 13 Sep 2021 09:12:02 +0000 Original-Received: (at 21695) by debbugs.gnu.org; 13 Sep 2021 09:11:17 +0000 Original-Received: from localhost ([127.0.0.1]:44369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPhzh-000376-0Q for submit@debbugs.gnu.org; Mon, 13 Sep 2021 05:11:17 -0400 Original-Received: from heytings.org ([95.142.160.155]:58450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPhzc-00036u-Ol for 21695@debbugs.gnu.org; Mon, 13 Sep 2021 05:11:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1631524271; bh=HuC2zNl2ed5BR+YQlziqWsCo5l+JJ2s1y2i/x+m4FRo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=AW+/fFaNggxEPhpp46n+2D6pwEl0gPay0MiJOl4XTvYMPGTRILv9VCm9VmyhKKb2h G85p/bvbsF/RmxGN7uf5j7UYkG+HdtGdVr3WfogYxfgKQO3pZt9K3oOe5ctMHgDles 4vk/mLp/i1ELodBzomGoCOE2n21rKYG1B84j0P1X0YguZI8/ca2fcdR/Mbuf8olhwX +m7G2puLgDuuFAGV/oBj+WCJ1Rs/KPrAXH0Ttdwz3xaxqntTBevIIHPQEpyQWDh0Qe qvlKqfrHPZ1m/qfFamKNU1p/PXjiJbwIcV6B2Wq2Wfst48oNNMGMHDlFWQtVoA35lL D8r6d/UeD+Cdw== In-Reply-To: <87a6khj6s5.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214207 Archived-At: >> + if (!EQ (plist, Qnil) && !NILP (Fplist_get (plist, Qcustom_set))) >> + safe_call2 (Qdisplay_warning, Qsetq, >> + CALLN (Fformat, >> + build_string >> + ("`%s' should be set with `customize-set-variable'"), >> + sym)); > > I haven't tried the patch, but won't this be triggered by the code > that's handling the variables? For instance, `latin1-display' has a > :set, but the file itself does `(setq latin1-display t)' etc. (This is > a very common pattern.) > No, (latin1-display 'latin-2) does not raise a warning with the patch, because latin1-disp.el is bytecompiled, and Fsetq is not used when bytecompiled code is executed (bytecompiled code only uses Fset). That being said, I would say that using (setq latin1-display t) when latin1-display has a :set is always a bug, in the init file, interactively, or in built-in code (bytecompiled or not), and that (set 'latin1-display t) should be used instead. WDYT?