From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Sat, 21 Aug 2021 02:31:53 +0300 Message-ID: <970df21b-c9ab-94fb-bfed-ab8df1fb82e6@yandex.ru> References: <74BC00E9-2509-47DA-9428-1523FF7F3B33@acm.org> <87v942pvcj.fsf@mail.linkov.net> <004A628A-99CC-4C62-8AE2-921C4C38D42A@acm.org> <87h7fkh8z8.fsf@mail.linkov.net> <254C8F2C-423D-4DBE-9836-A92BD63827D7@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38576"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Cc: 50067@debbugs.gnu.org, Tak Kunihiro , tkk@misasa.okayama-u.ac.jp, Lars Ingebrigtsen , Alan Third To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 21 01:33:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHE0u-0009sW-5B for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Aug 2021 01:33:28 +0200 Original-Received: from localhost ([::1]:58066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHE0s-0004iy-42 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Aug 2021 19:33:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHE0U-0004iY-Hx for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 19:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52364) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHE0U-0003dh-8M for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 19:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHE0T-0004Ml-TA for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 19:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Aug 2021 23:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.162950232416719 (code B ref 50067); Fri, 20 Aug 2021 23:33:01 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 20 Aug 2021 23:32:04 +0000 Original-Received: from localhost ([127.0.0.1]:35677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHDzX-0004Lb-Kr for submit@debbugs.gnu.org; Fri, 20 Aug 2021 19:32:03 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:39426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHDzV-0004L5-JQ for 50067@debbugs.gnu.org; Fri, 20 Aug 2021 19:32:01 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id z4so720843wrr.6 for <50067@debbugs.gnu.org>; Fri, 20 Aug 2021 16:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UuL3tu3a6N8bd2HxF4WDFLutH7iLCB0Ub5gE08wcsuI=; b=Hcd5fD5pwJ6MTs4xW8nE4aED1hEgp9nINhlyJWXS+2S1sTHdhYwSrckuvABTjDR04e L7gIZ8A6reItomv/nhXYzkPhiATLutqEU56u+diHnIMrSDerCcuUeqVwaX7xVNAgb7wI Yjhdvmxg+GJMyt+pvQUy1vDtOJ1qXYqjsprEvloVD2hfozwwHTu3w/O9Ya7noLLZ/J15 GxvSemTUV3mVJZdJkzJTlzoWvcObO4dfMVk9k5mJ4k8s9EEcshWwJbvkq1hsRa+MGiDd /J7gKHSrBfVoibpev4lXQ9CdsN8N2IkLCeU8COfNaFcnfh88KVrtlUfA2CzQDNRxAw/O +HWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UuL3tu3a6N8bd2HxF4WDFLutH7iLCB0Ub5gE08wcsuI=; b=RKrdLjt7Ji1pcI0dIoHibsoXQ0X80GlSUGfipv+AtQicXZAGxaQClNHF/k/zfHcB4R 3WBOjNagP3jnf7bNVVM20bOfDsMoGtFKm56AkQ0IoTrDgfy8BOF/couKwi050IOI7wLP E+QC76xs+yUdTzx2GfEsrEBc5ZjZYfxYEPNjVdZo+7xMKtwzhgJ8q0v6XEhMAjlRqruL t73iUK6TyInqwfppAKj8nwjdcjvZDgDmBYfeNATi23qjAQIvgComP6DmJ+vkTeURKz5M yHp+t2djX04lO4duASwbiDdKxKpmEOO2tNPrcryyk3P4z4UrWF5rKjJHL7exmXgDe7aH E9bw== X-Gm-Message-State: AOAM53023i0Z1XBpb9ezWMcQrtN8UFhBDt195EZ85YfAU3tEnl31Pa+W koJ6fpg8mGrtSBWCD+bwESg= X-Google-Smtp-Source: ABdhPJwz+tm4hP7ZMMKAeshFvFEX3qlumiMLo2mVMntO9KAKOu1XARGk06aFVYUFbvi9nHiCrM8SEg== X-Received: by 2002:a5d:4a8d:: with SMTP id o13mr1200075wrq.156.1629502315807; Fri, 20 Aug 2021 16:31:55 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h126sm11947783wmh.1.2021.08.20.16.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Aug 2021 16:31:55 -0700 (PDT) In-Reply-To: <254C8F2C-423D-4DBE-9836-A92BD63827D7@acm.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212308 Archived-At: Hi Mattias! On 20.08.2021 20:06, Mattias Engdegård wrote: > * If I start emacs -Q and enable context-menu-mode, right-clicking on an identifier in an elisp buffer still doesn't produce the Find Definition entry, presumably because xref hasn't been loaded. Shouldn't it be arranged to be autoloaded somehow, which is how xref works when invoked by keystrokes? I wonder what could be the reason for that. It would seem the menu should handle autoloaded commands fine. Even the visibility predicate should work: xref-find-backend is autoloaded as well. Try rewriting it with a let, to ensure that xref-find-backend is called first: (let ((backend (xref-find-backend))) (xref-backend-identifier-at-point backend)) > * `xref-make-match` requires (contrary to its doc string) its LOCATION argument to be of type `xref-file-location`, but some backends may only be able to make an `xref-buffer-location`. Would anyone object to changing the :location slot of `xref-match-item` to have type `xref-location`? I don't see how it could hurt. Makes sense to me, seems like an accident. I've done this change locally, no obvious bugs fell out.