From: Dmitry Gutov <dgutov@yandex.ru>
To: Sean Whitton <spwhitton@spwhitton.name>,
sbaugh@catern.com, 53626@debbugs.gnu.org
Subject: bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects
Date: Wed, 23 Feb 2022 03:45:34 +0200 [thread overview]
Message-ID: <96dded16-dda7-fa22-ba67-aea86fb3ebb0@yandex.ru> (raw)
In-Reply-To: <8735kawlbm.fsf@melete.silentflame.com>
On 23.02.2022 01:09, Sean Whitton wrote:
>> The timer-based solution is hacky, but it affects only one place (the
>> xref buffer and the variable in it), so it's easier to verify that it
>> has the intended effect, and no external callers will need to bother
>> with additional knowledge (hopefully, of course).
> Is there no chance of any concurrency issues with this, btw?
Probably not, or not currently: the fetching of the list of xrefs is
synchronous, and in all cases (so far) (I think) does not depend on the
value of default-directory. It only affects the subsequent interaction
with the buffer (jumping to locations), so deferring the assignment of
the value of dd seems fine.
FETCHER is also called in the current buffer (before the
with-current-buffer form), so even depending on the dynamic value of
default-directory should be fine. At least until we get to
asynchronous/chunked fetchers someday, but that's a bigger challenge
with its own major changes.
next prev parent reply other threads:[~2022-02-23 1:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 19:11 bug#53626: 28.0.91; project-find-regexp (C-x p g) twice results in searching different projects sbaugh
2022-01-30 6:28 ` Sean Whitton
2022-02-03 14:00 ` Dmitry Gutov
2022-02-03 15:19 ` Sean Whitton
2022-02-03 15:41 ` Dmitry Gutov
2022-02-03 23:16 ` Sean Whitton
2022-02-04 2:07 ` Dmitry Gutov
2022-02-04 2:32 ` Dmitry Gutov
2022-02-04 5:32 ` Sean Whitton
2022-02-07 3:12 ` Dmitry Gutov
2022-02-21 1:55 ` Dmitry Gutov
2022-02-21 23:00 ` Sean Whitton
2022-02-21 23:14 ` Dmitry Gutov
2022-02-22 23:09 ` Sean Whitton
2022-02-23 1:45 ` Dmitry Gutov [this message]
2022-02-23 1:55 ` Dmitry Gutov
2022-02-23 5:36 ` Sean Whitton
2022-02-23 11:41 ` Dmitry Gutov
2022-02-03 3:15 ` Dmitry Gutov
2022-02-03 13:28 ` Spencer Baugh
2022-02-03 13:58 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96dded16-dda7-fa22-ba67-aea86fb3ebb0@yandex.ru \
--to=dgutov@yandex.ru \
--cc=53626@debbugs.gnu.org \
--cc=sbaugh@catern.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).