From: "Clément Pit--Claudel" <clement.pit@gmail.com>
To: Vasilij Schneidermann <v.schneidermann@gmail.com>, 24514@debbugs.gnu.org
Subject: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces
Date: Fri, 23 Sep 2016 09:22:15 -0400 [thread overview]
Message-ID: <9682182c-2575-4827-2a22-ead1071c26d7@gmail.com> (raw)
In-Reply-To: <20160923075116.GA612@odonien.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 1782 bytes --]
On 2016-09-23 03:51, Vasilij Schneidermann wrote:
>> This looks great! I love it. And the patch looks very clean, too.
>
> Thanks! I've updated the patch after a bit more testing. The extra
> debug line happened because the search in debug.el did actually
> search for a `debug' call, so `(search-forward "\ (debug")` would
> match a call to `debug-foo` as well. Assuming there will always be
> extra args, this can be solved by appending a space to the search
> string.
Could it just search for the first occurence only?
>> But it scares me a bit. Some tools do depend on e.g. trimming a
>> backtrace after printing it. Does edebug work with your patch,
>> for example?
>
> Yes, it does. … The only thing other than `debug.el`
> manipulating them is `edebug-backtrace' which I've never heard of
> before.
This is the one I was scared about. You can get a backtrace while edebugging by pressing t IIRC. I have a faint memory of this code doing nasty things to remove edebug instrumentation from the backtrace before displaying it.
>> I'm not sure what the right way to transition is. Maybe Emacs
>> should let Lisp programs access the backtraces in a structured way,
>> and then backtrace printing would only be a user-facing facility
>> (programs wouldn't use the textual representation).
>
> There is actually a way to do this, simply use `backtrace-frame' with
> an increasing integer argument until it returns nil:
>
> (let ((frame t) ; dummy value to kick-start the loop (i 0)) (while
> frame (setq frame (backtrace-frame i)) (message "%S" frame) (setq i
> (1+ i))))
Neat! Didn't know about this. I think it would be great to add a pointer to this in the documentation of `backtrace'.
Great work :)
Clément.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-23 13:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 23:14 bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Vasilij Schneidermann
2016-09-23 2:22 ` Clément Pit--Claudel
2016-09-23 7:51 ` Vasilij Schneidermann
2016-09-23 13:22 ` Clément Pit--Claudel [this message]
2016-09-23 8:12 ` Vasilij Schneidermann
2016-09-23 9:44 ` Eli Zaretskii
2016-09-23 9:55 ` bug#24515: " Vasilij Schneidermann
2016-09-23 10:06 ` Eli Zaretskii
2016-09-23 13:25 ` Clément Pit--Claudel
2016-09-23 16:33 ` John Wiegley
[not found] ` <mailman.2864.1474586229.22741.bug-gnu-emacs@gnu.org>
2016-09-23 18:47 ` Alan Mackenzie
2016-09-23 20:43 ` Richard Stallman
2016-09-27 19:16 ` Vasilij Schneidermann
2016-09-28 15:28 ` Eli Zaretskii
2016-09-30 10:29 ` Vasilij Schneidermann
2016-09-30 13:26 ` Eli Zaretskii
2016-10-12 15:34 ` Vasilij Schneidermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9682182c-2575-4827-2a22-ead1071c26d7@gmail.com \
--to=clement.pit@gmail.com \
--cc=24514@debbugs.gnu.org \
--cc=v.schneidermann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).