From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, 54001@debbugs.gnu.org
Cc: Daniel Mendler <mail@daniel-mendler.de>
Subject: bug#54001: 29.0.50; abbreviate-file-name has side-effects
Date: Mon, 14 Feb 2022 09:52:32 -0800 [thread overview]
Message-ID: <96603590-acc9-65d1-4086-7e2f114f9441@gmail.com> (raw)
In-Reply-To: <jwvee45xt4y.fsf@iro.umontreal.ca>
On 2/14/2022 9:19 AM, Stefan Monnier via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
> Package: Emacs
> Version: 29.0.50
>
>
> Since:
>
> commit bf505a63f98ed61934a8fb81ec65c96859606b6e
> Author: Jim Porter <jporterbugs@gmail.com>
> Date: Mon Nov 15 13:33:07 2021 +0100
>
> Support abbreviating home directory of Tramp filenames
>
> `abbreviate-file-name` has significantly changed in its behavior:
> - it's slower (because it goes through file-name-handlers)
> - it can have very visible side effects like prompting the user for a password.
>
> I haven't measured the slowdown, so I'll assume it's acceptable, but
> asking for a password (or contacting a remote host) is not.
Sorry about that. I did what I could to minimize the slowdown (including
some more general optimizations to make Tramp faster). There are some
benchmarks in the original bug here (these are with 1000 iterations;
you'll want to compare the first section with the last):
<https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-11/msg01293.html>.
> I suggest we take a step back and think of how to get that feature
> without having to contact any remote host during `abbreviate-file-name`.
> Maybe we can do that by making Tramp opportunistically add entries to
> `directory-abbrev-alist` when it performs expansion?
I think Michael Albinus suggested doing that in the original bug,
although I was concerned about modifying defcustoms invisibly like that.
Is that ok to do? Another option might be to store the abbreviations for
a given file-name-handler somewhere internally and consult that when
calling that file-name-handler's implementation of `abbreviate-file-name'.
Maybe this patch should be backed out for now; it shouldn't be
interrupting the user. (I thought I'd tested that, but maybe it was on
an earlier revision of the patch.) I'll probably have time to look into
a new solution in a few weeks, but anyone else who's interested should
feel free to fix it in the meantime.
next prev parent reply other threads:[~2022-02-14 17:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 17:19 bug#54001: 29.0.50; abbreviate-file-name has side-effects Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-14 17:52 ` Jim Porter [this message]
2022-02-14 19:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-14 20:52 ` Jim Porter
2022-02-14 21:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-14 21:38 ` Jim Porter
2022-02-14 21:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-15 8:52 ` Michael Albinus
2022-02-15 13:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-15 13:26 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96603590-acc9-65d1-4086-7e2f114f9441@gmail.com \
--to=jporterbugs@gmail.com \
--cc=54001@debbugs.gnu.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).