From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#75141: [PATCH] Add button navigation to treesit-explorer Date: Sat, 4 Jan 2025 12:02:46 -0800 Message-ID: <965F4039-B541-4FD8-98D0-E34ACAAE4FA0@gmail.com> References: <87msgh5j0j.fsf@disroot.org> <868qrqeqps.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38689"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75141@debbugs.gnu.org, Gabriel Santos To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 21:03:18 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUAMg-0009wh-0P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 21:03:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUAMT-0005pa-6e; Sat, 04 Jan 2025 15:03:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUAMQ-0005pE-PO for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 15:03:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUAMQ-0000Xa-GL for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 15:03:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=c2RcD6Lae6EkQgqkzhxQCwktHtjaOLtHSHeZ4rYG+98=; b=b5XNXfkVtwlcrF7VVitI8Dr6I/GhrPbEAYHGbQ3z5uVxmsJRCIzXUdEzYvnhy3Y5mppdIu7e4rcXrPFVV6W+PGGPMrbq6QtxgPskGKZoFfH2Cthd5bfJhLs4IAFGCeG7lh0bl9aFXm+IlbkHcV/dJtBKHt7Bc3sh3oqPTKzGAZB6QURjpgUYnTZr5gbWsXxFz5hxofV0+gYLW5Ho9HaOuHUNEPtCspL3v7MOXLa6+gOy9s5F6KCvS9xncTBJYW0ahoOTgjl1zgox4d7Req7wSAbeyJqTg7CDQslXzUm6E4+pZcsBAcQWdRQKrz3RUfphLS5irf9of418Ihngth/SXQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUAMQ-00026p-8q for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 15:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75141-submit@debbugs.gnu.org id=B75141.17360209818101 (code B ref 75141); Sat, 04 Jan 2025 20:03:02 +0000 Original-Received: (at 75141) by debbugs.gnu.org; 4 Jan 2025 20:03:01 +0000 Original-Received: from localhost ([127.0.0.1]:57518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUAMP-00026b-AM for submit@debbugs.gnu.org; Sat, 04 Jan 2025 15:03:01 -0500 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:46433) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUAMN-00026P-Ix for 75141@debbugs.gnu.org; Sat, 04 Jan 2025 15:03:00 -0500 Original-Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-21649a7bcdcso181095535ad.1 for <75141@debbugs.gnu.org>; Sat, 04 Jan 2025 12:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736020978; x=1736625778; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c2RcD6Lae6EkQgqkzhxQCwktHtjaOLtHSHeZ4rYG+98=; b=FkU94321dHzxBMfxuw1QcHi1ioTHYdtQpVBTgRfU0afSAOKjc7OAPMQNGgcCRZGGNo cIZdkrL51+P6wr5yMpBFK7MZsmoxNQvnXYWkYmBYGvvxzlUFjyzEkuGKNAaSZaMMbrL8 BmFJMi7Zs5D+WSu5kuNmOMIt7j/oPeTUQrahaKJ9oOBQwbi03OHbr93lNEbUkPTYxdDY VOExvHHA7SRf5DRMD75lKnkqZDwzzeVve6LPffgz1kTE8hxRJR1kQAdqceISAcpGDWTL 7YhTF7aj9TNvbHUDCQWAfrv61+NSmFq11lMAN6vzUJ6rnynuwQ86lUMt/b80iBFIJ+Lh bJbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736020978; x=1736625778; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c2RcD6Lae6EkQgqkzhxQCwktHtjaOLtHSHeZ4rYG+98=; b=FbYW+okek8pWuS9uipl7LbshihY5oCTxfsBufT94N2Bg9uqXxDZrE1feElcmDg9b1A EJ8a7EMGQViXGPtYnjKzBsiRKHnrK37mo4Qw9O7MSn2N5P7s17zXVOrfxKx8hy3rx92l mbStUSrCvfBmtOtedjI5ZkCjlN5e23NPsZr7geT7tund1HcRsxBbsgf9pzGxF1+XcNUF Qjg5z6OiGL9aAOmYuIXHxbF8kGufePJTNg5gBdPvEqWzwRgMwntfvn26lIQ29lUVQfJe J4eO5IZu3CGW4tBaOyGYgZyDfXgYU2XNIdph4PiSse9HfvLcRZ/HvWAZrWp/1p1JfpGZ aXpw== X-Forwarded-Encrypted: i=1; AJvYcCXiV8jIwxoGQLMe6JS6F69HJwcIVT26BlaKCjiV1h48zWQDQBlJCnN4ruEQaI/eLPNEhcyxgg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzrlIkF4Ky4Nw4/rCoIay4QxxwNVc5lAY108TyMSXbbIevfPpm5 9AVBH9JGP1nr+BKD+7F+MsQzAja3xg8h7mjczmvZ1WCU20j5BPVj X-Gm-Gg: ASbGncvUNkQ4yJygBZkXCU0EhPFJ0bgBhdGfcFjI3cA7nXRSyJl7AUn3TWgUT7immnu 7Ig5sAUrVjglw0pr240EuGTIQHFsVWa6WsILPcu1LIvAD2TOjlJUFR12PPa5DOKenJI4GNiiGRc VQLV7F6PERdUcOPclx9RlHN3PRJo4bB2vjkLbcSFfTaTap72pDl+1mEf2/KleCWKVx+i72QHN+S rBQIooWGz5dhZzWND0NbplCEVXM4s1hA+olU+xaUepnx9340FR6Jb+dcUr/HAiIKujm5Jt//j9Q 5nCv X-Google-Smtp-Source: AGHT+IG+vCZYxUjS/bn8euYzijuj+HT27fMniOo7Tb/Nj7if6jlADyONwNawwhLA5As82DSuJipa7w== X-Received: by 2002:a17:902:d587:b0:216:5af7:eb2a with SMTP id d9443c01a7336-219e6ebb70bmr810909795ad.33.1736020978476; Sat, 04 Jan 2025 12:02:58 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:c496:8cdf:4c5d:3617]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96e94dsm266162685ad.67.2025.01.04.12.02.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Jan 2025 12:02:57 -0800 (PST) In-Reply-To: <868qrqeqps.fsf@gnu.org> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298465 Archived-At: > On Jan 4, 2025, at 3:57=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> Date: Fri, 27 Dec 2024 10:54:04 -0300 >> From: Gabriel Santos via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Greetings, >>=20 >> Currently, the only way to navigate through treesit-explorer is by = the >> use of C-n and C-p. Since this buffer is full of buttons, I decided = to >> add button navigation to it. >>=20 >> This patch adds button navigation to treesit-explorer, for the = following >> keys: >>=20 >> * forward-button >> - f >> - n >> - TAB >>=20 >> * backward-button >> - b >> - p >> - >>=20 >> * Points of discussion >>=20 >> Maybe that's too many keys? The only ones I think that don't really = fit >> that much are "f" and "b", because they can also go down, but there's = no >> harm in having extra keys. >=20 > Thanks. >=20 > Yuan, any comments? Sounds good! Though would using both f/b and n/p for the same thing a = bit wasteful? Maybe we can start with n/p TAB/? Yuan=