From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#70833: 29.2.50; project-current: allow control of the prompt string Date: Fri, 10 May 2024 04:57:23 +0300 Message-ID: <95e34431-8416-44b5-bcca-8dd6f6773756@gutov.dev> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------nLddiNVPsYcPLwfV97F5QTRz" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17931"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Spencer Baugh , 70833@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 10 03:58:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s5FWi-0004Qw-Bi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 May 2024 03:58:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5FWP-0008Q3-I6; Thu, 09 May 2024 21:58:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5FWO-0008Pl-DB for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 21:58:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5FWO-0007ZJ-4M for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 21:58:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5FWM-0004hq-GD for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 21:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2024 01:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70833 X-GNU-PR-Package: emacs Original-Received: via spool by 70833-submit@debbugs.gnu.org id=B70833.171530625218072 (code B ref 70833); Fri, 10 May 2024 01:58:02 +0000 Original-Received: (at 70833) by debbugs.gnu.org; 10 May 2024 01:57:32 +0000 Original-Received: from localhost ([127.0.0.1]:41469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5FVs-0004hQ-CQ for submit@debbugs.gnu.org; Thu, 09 May 2024 21:57:32 -0400 Original-Received: from wfout2-smtp.messagingengine.com ([64.147.123.145]:43997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5FVq-0004hE-Ax for 70833@debbugs.gnu.org; Thu, 09 May 2024 21:57:31 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id 264241C001AC; Thu, 9 May 2024 21:57:25 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 09 May 2024 21:57:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1715306245; x=1715392645; bh=l8JPAzGiUT 7xXNWvUv/aiorrgbOhxpIJn90uefi8f4g=; b=SqIsNUjq56SrEKFckuGMWlnlGh kU/4VSPeIkHc/U20LZ70jzYmtHuqTW77f/d4GoEDJnbIDU58gGNL7kKrRo6sWE+8 bgFt0CT2qIpDyO9HXW+zPW+LChTKlBDXr4NOAblz7S7R6KO6EAF98TFojT7UZ3t/ NzqKZGqkeQUjTIQvsAGFW+U12OQNKZnekLof02nNsnkWQYYCMcBJ+OpWkHmPygGL 8MsYD1haACwJAEVYJFTWNlbS22upJWOnSZ8LQFkKIFI9/IADpmytSKC9l3kGJaGl Ekd5+qWX5sj6xfgqk91D8HQlY3VKbDuQhsHHEGJy6u+xsQ004eAxtdW3Se2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1715306245; x=1715392645; bh=l8JPAzGiUT7xXNWvUv/aiorrgbOh xpIJn90uefi8f4g=; b=DBuZUuAOwF2F3zMUg8oVx0NMHa8T5F/lwnesebKgxYdC ghUKxnnn8zc3f3wfMmBZWmqwWhmRZ/uks6QKUrYSH/2arAJsBm50Pl1dR8mNELj9 G9w2kr6aCjO3+HnXA82DPJaikd2wR+5kdWIPqKQ5EuZgEYTg65NtKhrXUac5DWJz Yg5SPGVdMceyycepm9KEiuCM9mFzyNTk9QEpSm2XY+2ssUirl5kLKZxZJb7DkiAH VwREobg5VeKXLuQzdvcG21DDNz3oW4nowCd34BA6Pdwdgv+7yChNnMmscPsRu1bZ KElXkWGjWfX2bAENL1dkxxjhjoQRlSaURBbIYnPQkA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdefgedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfhfhfgjsehmtderredtvdejnecuhfhrohhmpeffmhhithhr hicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvg hrnhepkefhieejheehjefhhefhuddvteettedvgeelteeigeelueegheffueffleduvdff necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmih htrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 May 2024 21:57:24 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284790 Archived-At: This is a multi-part message in MIME format. --------------nLddiNVPsYcPLwfV97F5QTRz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Spencer, On 08/05/2024 17:05, Spencer Baugh wrote: > > It would be nice to be able to control the prompt string that > project-current uses when prompting for a project. Ideally, by passing > a string for the MAYBE-PROMPT argument. > > This is useful when using project-current in functions which should > operate on the current project normally, but which might be run outside > any project and in that case will prompt for a project. The user might > be uncertain about what the project they'll input will be used for, > exactly. It's useful for the prompt to remind them. > > The prompt could be passed down as an argument to project-prompter, or > bound in a defvar for compatibility - either seems fine to me. Aside from documentation changes, and the backward incompatibility pains, this looks easy enough to do. Why do you say that that the lexical argument is better than a dynamic one in this case? Just wondering if you see a particular reason. Also, I wonder if we perhaps should pass not the entire prompt but some "purpose hint". For example, the argument could look like "find-file", and then the prompt would be rendered as Select project [find-file]: or however else the prompter implementation decides (perhaps it uses some other different UI where another text arrangement would be better). Just a thought -- I'm probably over-complicating things. --------------nLddiNVPsYcPLwfV97F5QTRz Content-Type: text/x-patch; charset=UTF-8; name="maybe-prompt-prompt.diff" Content-Disposition: attachment; filename="maybe-prompt-prompt.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rl cy9wcm9qZWN0LmVsCmluZGV4IDUyZmU0ZGY5MDgwLi5iMzZjZDE5ODlmOSAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsCkBAIC0yMzUsNyArMjM1LDkgQEAgcHJvamVjdC1jdXJyZW50CiAgICAgIChwcikK ICAgICAgKCh1bmxlc3MgcHJvamVjdC1jdXJyZW50LWRpcmVjdG9yeS1vdmVycmlkZQogICAg ICAgICBtYXliZS1wcm9tcHQpCi0gICAgICAoc2V0cSBkaXJlY3RvcnkgKGZ1bmNhbGwgcHJv amVjdC1wcm9tcHRlcikKKyAgICAgIChzZXRxIGRpcmVjdG9yeSAoaWYgKHN0cmluZ3AgbWF5 YmUtcHJvbXB0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAoZnVuY2FsbCBwcm9qZWN0 LXByb21wdGVyIG1heWJlLXByb21wdCkKKyAgICAgICAgICAgICAgICAgICAgICAgIChmdW5j YWxsIHByb2plY3QtcHJvbXB0ZXIpKQogICAgICAgICAgICAgcHIgKHByb2plY3QtLWZpbmQt aW4tZGlyZWN0b3J5IGRpcmVjdG9yeSkpKSkKICAgICAod2hlbiBtYXliZS1wcm9tcHQKICAg ICAgIChpZiBwcgpAQCAtMTgxOSw3ICsxODIxLDcgQEAgcHJvamVjdC1mb3JnZXQtcHJvamVj dAogCiAoZGVmdmFyIHByb2plY3QtLWRpci1oaXN0b3J5KQogCi0oZGVmdW4gcHJvamVjdC1w cm9tcHQtcHJvamVjdC1kaXIgKCkKKyhkZWZ1biBwcm9qZWN0LXByb21wdC1wcm9qZWN0LWRp ciAoJm9wdGlvbmFsIHByb21wdCkKICAgIlByb21wdCB0aGUgdXNlciBmb3IgYSBkaXJlY3Rv cnkgdGhhdCBpcyBvbmUgb2YgdGhlIGtub3duIHByb2plY3Qgcm9vdHMuCiBUaGUgcHJvamVj dCBpcyBjaG9zZW4gYW1vbmcgcHJvamVjdHMga25vd24gZnJvbSB0aGUgcHJvamVjdCBsaXN0 LAogc2VlIGBwcm9qZWN0LWxpc3QtZmlsZScuCkBAIC0xODM3LDE0ICsxODM5LDE1IEBAIHBy b2plY3QtcHJvbXB0LXByb2plY3QtZGlyCiAgICAgICA7OyBJZiB0aGUgdXNlciBzaW1wbHkg cHJlc3NlZCBSRVQsIGRvIHRoaXMgYWdhaW4gdW50aWwgdGhleSBkb24ndC4KICAgICAgIChz ZXRxIHByLWRpcgogICAgICAgICAgICAgKGxldCAoaGlzdG9yeS1hZGQtbmV3LWlucHV0KQot ICAgICAgICAgICAgICAoY29tcGxldGluZy1yZWFkICJTZWxlY3QgcHJvamVjdDogIiBjaG9p Y2VzIG5pbCB0IG5pbCAncHJvamVjdC0tZGlyLWhpc3RvcnkpKSkpCisgICAgICAgICAgICAg IChjb21wbGV0aW5nLXJlYWQgKG9yIHByb21wdCAiU2VsZWN0IHByb2plY3Q6ICIpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY2hvaWNlcyBuaWwgdCBuaWwgJ3Byb2plY3Qt LWRpci1oaXN0b3J5KSkpKQogICAgIChpZiAoZXF1YWwgcHItZGlyIGRpci1jaG9pY2UpCiAg ICAgICAgIChyZWFkLWRpcmVjdG9yeS1uYW1lICJTZWxlY3QgZGlyZWN0b3J5OiAiIGRlZmF1 bHQtZGlyZWN0b3J5IG5pbCB0KQogICAgICAgcHItZGlyKSkpCiAKIChkZWZ2YXIgcHJvamVj dC0tbmFtZS1oaXN0b3J5KQogCi0oZGVmdW4gcHJvamVjdC1wcm9tcHQtcHJvamVjdC1uYW1l ICgpCisoZGVmdW4gcHJvamVjdC1wcm9tcHQtcHJvamVjdC1uYW1lICgmb3B0aW9uYWwgcHJv bXB0KQogICAiUHJvbXB0IHRoZSB1c2VyIGZvciBhIHByb2plY3QsIGJ5IG5hbWUsIHRoYXQg aXMgb25lIG9mIHRoZSBrbm93biBwcm9qZWN0IHJvb3RzLgogVGhlIHByb2plY3QgaXMgY2hv c2VuIGFtb25nIHByb2plY3RzIGtub3duIGZyb20gdGhlIHByb2plY3QgbGlzdCwKIHNlZSBg cHJvamVjdC1saXN0LWZpbGUnLgpAQCAtMTg3Miw3ICsxODc1LDggQEAgcHJvamVjdC1wcm9t cHQtcHJvamVjdC1uYW1lCiAgICAgICA7OyBJZiB0aGUgdXNlciBzaW1wbHkgcHJlc3NlZCBS RVQsIGRvIHRoaXMgYWdhaW4gdW50aWwgdGhleSBkb24ndC4KICAgICAgIChzZXRxIHByLW5h bWUKICAgICAgICAgICAgIChsZXQgKGhpc3RvcnktYWRkLW5ldy1pbnB1dCkKLSAgICAgICAg ICAgICAgKGNvbXBsZXRpbmctcmVhZCAiU2VsZWN0IHByb2plY3Q6ICIgdGFibGUgbmlsIHQg bmlsICdwcm9qZWN0LS1uYW1lLWhpc3RvcnkpKSkpCisgICAgICAgICAgICAgIChjb21wbGV0 aW5nLXJlYWQgKG9yIHByb21wdCAiU2VsZWN0IHByb2plY3Q6ICIpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdGFibGUgbmlsIHQgbmlsICdwcm9qZWN0LS1uYW1lLWhpc3Rv cnkpKSkpCiAgICAgKGlmIChlcXVhbCBwci1uYW1lIGRpci1jaG9pY2UpCiAgICAgICAgIChy ZWFkLWRpcmVjdG9yeS1uYW1lICJTZWxlY3QgZGlyZWN0b3J5OiAiIGRlZmF1bHQtZGlyZWN0 b3J5IG5pbCB0KQogICAgICAgKGxldCAoKHByb2ogKGFzc29jIHByLW5hbWUgY2hvaWNlcykp KQo= --------------nLddiNVPsYcPLwfV97F5QTRz--