From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18090: 24.4.50; `delete-selection-helper' logic changed for non-mouse region? Date: Wed, 23 Jul 2014 11:02:37 -0700 (PDT) Message-ID: <95e066b9-792c-4b38-8f4b-fd225578ed45@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1406138680 31102 80.91.229.3 (23 Jul 2014 18:04:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2014 18:04:40 +0000 (UTC) To: 18090@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 23 20:04:33 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XA0tz-0002cd-PV for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jul 2014 20:04:31 +0200 Original-Received: from localhost ([::1]:46368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA0tz-0006Rw-2i for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jul 2014 14:04:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA0tk-0006RJ-UX for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 14:04:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XA0tW-0008Kj-LC for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 14:04:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA0tW-0008KX-IG for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 14:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XA0tV-0004CD-OH for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 14:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jul 2014 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.140613860516041 (code B ref -1); Wed, 23 Jul 2014 18:04:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Jul 2014 18:03:25 +0000 Original-Received: from localhost ([127.0.0.1]:35851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XA0sr-0004AW-Ah for submit@debbugs.gnu.org; Wed, 23 Jul 2014 14:03:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48594) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XA0sl-0004A1-6A for submit@debbugs.gnu.org; Wed, 23 Jul 2014 14:03:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XA0sV-000883-H1 for submit@debbugs.gnu.org; Wed, 23 Jul 2014 14:03:09 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA0sV-00087z-DV for submit@debbugs.gnu.org; Wed, 23 Jul 2014 14:02:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA0sM-0006IJ-2x for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 14:02:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XA0sC-00086T-Pm for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 14:02:50 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:43356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA0sC-00086O-Ii for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 14:02:40 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s6NI2cXW006796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Jul 2014 18:02:39 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6NI2cGs029692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 23 Jul 2014 18:02:38 GMT Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6NI2cEw004032 for ; Wed, 23 Jul 2014 18:02:38 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91760 Archived-At: Prior to Emacs 23, the delsel.el code that handles a yank had this code: ;; Before a yank command, make sure we don't yank the ;; head of the kill-ring that really comes from the ;; currently active region we are going to delete. ;; That would make yank a no-op. (when (and (string=3D (buffer-substring-no-properties (point) (mark)) (car kill-ring))) (current-kill 1)) That code dates from the creation of delsel.el. In Emacs 23, these two sexps were appended to the `and' conditions, which completely changes the meaning/behavior (though the comment was not modified): (fboundp 'mouse-region-match) (mouse-region-match) This changed the behavior so that the yanking point is now rotated only when the mouse was used to set the region. This makes no sense to me, but perhaps I am missing something. Does this make sense to you? If it does make sense, then at least the comment should be updated to reflect the current behavior. --- BTW, I also think it would be better to use `while' instead of `when' in the code: (let ((tail kill-ring)) (while (and tail (string=3D (buffer-substring-no-properties (point) (mar= k)) (car tail)) (fboundp 'mouse-region-match) ; ???? (mouse-region-match)) ; ???? (current-kill 1) (setq tail (cdr tail)))) In GNU Emacs 24.4.50.1 (i686-pc-mingw32) of 2014-06-28 on ODIEONE Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/snapshot/trunk --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib 'CPPFLAGS=3D-DGC_MCHECK=3D1 -Ic:/Devel/emacs/include''