From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Hansen Newsgroups: gmane.emacs.bugs Subject: bug#55952: [PATCH] bindat (strz): Write null terminator after variable length string Date: Mon, 13 Jun 2022 17:48:15 -0400 Message-ID: <95d2ffc9-ac61-91fa-605e-f95507f81217@rhansen.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------Tu82aCDlzFwchq98eCF7Ylta" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4649"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: monnier@iro.umontreal.ca To: 55952@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 13 23:50:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0rwr-0000z1-HL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 23:50:14 +0200 Original-Received: from localhost ([::1]:39624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0rwq-0001Ez-A6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 17:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0rvi-00086i-Vu for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 17:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38513) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0rvi-0004S7-N2 for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 17:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0rvi-0007Fg-40; Mon, 13 Jun 2022 17:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Hansen Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2022 21:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55952 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca Original-Received: via spool by submit@debbugs.gnu.org id=B.165515690527829 (code B ref -1); Mon, 13 Jun 2022 21:49:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jun 2022 21:48:25 +0000 Original-Received: from localhost ([127.0.0.1]:60642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0rv6-0007En-UU for submit@debbugs.gnu.org; Mon, 13 Jun 2022 17:48:25 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:43082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0rv3-0007Ec-G0 for submit@debbugs.gnu.org; Mon, 13 Jun 2022 17:48:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0rv2-0006vb-W8 for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 17:48:21 -0400 Original-Received: from spork.scientician.org ([2600:3c03:e000:66::1]:56807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0rv0-0004Pe-Uo for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 17:48:20 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id D471F47F47 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1655156896; bh=6xJJTI9trGjLfLv5B25M5c+2G6d7SC3fgLPudarB4Gk=; h=Date:To:From:Subject:From; b=hgpy8tqw5YgszUMulSWHZnoNpQgrLaPkMvP94jFGubXRYJqXyXrL0+CeWKBNsOefE KrIpSTs6+8UCqcoxAd9f5GlIQykNVY33dF4I8mXTaGtIrWvwnYhP8YqyufxlawDs1d XPK7pRIW57H2p+zxsZ5Q1dUxoPau97eHqlFd8DX0= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id 479F020481 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1655156895; bh=6xJJTI9trGjLfLv5B25M5c+2G6d7SC3fgLPudarB4Gk=; h=Date:To:From:Subject:From; b=baiCYE5hSlyxE+WN5BZrOme5yGmg0fmNi+/EuZtVwh/3Uk2E8zQ5egU0aYlz84tW/ 92LzuZsm/feulwfJxNU32C39vburR0bvRzBptwDXh43KVEDARbRvDKnEl/bJ46+b1h pPV9QlSfu+KxH4PBndd8RR5Mg7xxciDhlFurPE1E= Content-Language: en-US Received-SPF: pass client-ip=2600:3c03:e000:66::1; envelope-from=rhansen@rhansen.org; helo=spork.scientician.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234447 Archived-At: This is a multi-part message in MIME format. --------------Tu82aCDlzFwchq98eCF7Ylta Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Debbugs-CC: monnier@iro.umontreal.ca Attached patch: * lisp/emacs-lisp/bindat.el (bindat--pack-strz): Explicitly write a null byte after packing a variable-length string to ensure proper termination when packing to a pre-allocated string. * doc/lispref/processes.texi (Bindat Types): Update documentation. * test/lisp/emacs-lisp/bindat-tests.el (bindat-test--str-strz-prealloc): Update tests. --------------Tu82aCDlzFwchq98eCF7Ylta Content-Type: text/x-patch; charset=UTF-8; name="0001-bindat-strz-Write-null-terminator-after-variable-len.patch" Content-Disposition: attachment; filename*0="0001-bindat-strz-Write-null-terminator-after-variable-len.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyOWU0MDQxNGYxYjM0NDc3NGVkOTA4NWE4ZjEyNWZkMDgwMTI3NmMzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogVGh1LCA5IEp1biAyMDIyIDIwOjQxOjUwIC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gYmluZGF0IChzdHJ6KTogV3JpdGUgbnVsbCB0ZXJtaW5hdG9yIGFmdGVyIHZhcmlh YmxlIGxlbmd0aAogc3RyaW5nCgoqIGxpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwgKGJpbmRh dC0tcGFjay1zdHJ6KTogRXhwbGljaXRseSB3cml0ZSBhCm51bGwgYnl0ZSBhZnRlciBwYWNr aW5nIGEgdmFyaWFibGUtbGVuZ3RoIHN0cmluZyB0byBlbnN1cmUgcHJvcGVyCnRlcm1pbmF0 aW9uIHdoZW4gcGFja2luZyB0byBhIHByZS1hbGxvY2F0ZWQgc3RyaW5nLgoqIGRvYy9saXNw cmVmL3Byb2Nlc3Nlcy50ZXhpIChCaW5kYXQgVHlwZXMpOiBVcGRhdGUgZG9jdW1lbnRhdGlv bi4KKiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgKGJpbmRhdC10ZXN0 LS1zdHItc3Ryei1wcmVhbGxvYyk6ClVwZGF0ZSB0ZXN0cy4KLS0tCiBkb2MvbGlzcHJlZi9w cm9jZXNzZXMudGV4aSAgICAgICAgICAgfCAxNyArKysrLS0tLS0tLS0tLS0tLQogbGlzcC9l bWFjcy1saXNwL2JpbmRhdC5lbCAgICAgICAgICAgIHwgIDMgKysrCiB0ZXN0L2xpc3AvZW1h Y3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgfCAgNCArKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDkg aW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3By ZWYvcHJvY2Vzc2VzLnRleGkgYi9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aQppbmRleCA4 YzhmOGZkNmIyLi4xNzk5ODBjMGVkIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9wcm9jZXNz ZXMudGV4aQorKysgYi9kb2MvbGlzcHJlZi9wcm9jZXNzZXMudGV4aQpAQCAtMzQ5NSwyNCAr MzQ5NSwxNSBAQCBCaW5kYXQgVHlwZXMKIEBpdGVtIHN0cnogJm9wdGlvbmFsIEB2YXJ7bGVu fQogSWYgQHZhcntsZW59IGlzIG5vdCBwcm92aWRlZDogVmFyaWFibGUtbGVuZ3RoIG51bGwt dGVybWluYXRlZCB1bmlieXRlCiBzdHJpbmcgKEBweHJlZntUZXh0IFJlcHJlc2VudGF0aW9u c30pLiAgV2hlbiBwYWNraW5nLCB0aGUgZW50aXJlIGlucHV0Ci1zdHJpbmcgaXMgY29waWVk IHRvIHRoZSBwYWNrZWQgb3V0cHV0LiAgVGhlIGZvbGxvd2luZyBieXRlIHdpbGwgYmUKLW51 bGwgKHplcm8pIHVubGVzcyBhIHByZS1hbGxvY2F0ZWQgc3RyaW5nIHdhcyBwcm92aWRlZCB0 bwotQGNvZGV7YmluZGF0LXBhY2t9LCBpbiB3aGljaCBjYXNlIHRoYXQgYnl0ZSBpcyBsZWZ0 IHVubW9kaWZpZWQuICBUaGUKLWxlbmd0aCBvZiB0aGUgcGFja2VkIG91dHB1dCBpcyB0aGUg bGVuZ3RoIG9mIHRoZSBpbnB1dCBzdHJpbmcgcGx1cyBvbmUKLShmb3IgdGhlIG51bGwgdGVy bWluYXRvcikuICBUaGUgaW5wdXQgc3RyaW5nIG11c3Qgbm90IGNvbnRhaW4gYW55IG51bGwK LWJ5dGVzLiAgSWYgdGhlIGlucHV0IHN0cmluZyBpcyBtdWx0aWJ5dGUgd2l0aCBvbmx5IEFT Q0lJIGFuZAorc3RyaW5nIGlzIGNvcGllZCB0byB0aGUgcGFja2VkIG91dHB1dCBmb2xsb3dl ZCBieSBhIG51bGwgKHplcm8pIGJ5dGUuCitUaGUgbGVuZ3RoIG9mIHRoZSBwYWNrZWQgb3V0 cHV0IGlzIHRoZSBsZW5ndGggb2YgdGhlIGlucHV0IHN0cmluZyBwbHVzCitvbmUgKGZvciB0 aGUgbnVsbCB0ZXJtaW5hdG9yKS4gIFRoZSBpbnB1dCBzdHJpbmcgbXVzdCBub3QgY29udGFp biBhbnkKK251bGwgYnl0ZXMuICBJZiB0aGUgaW5wdXQgc3RyaW5nIGlzIG11bHRpYnl0ZSB3 aXRoIG9ubHkgQVNDSUkgYW5kCiBAY29kZXtlaWdodC1iaXR9IGNoYXJhY3RlcnMsIGl0IGlz IGNvbnZlcnRlZCB0byB1bmlieXRlIGJlZm9yZSBpdCBpcwogcGFja2VkOyBvdGhlciBtdWx0 aWJ5dGUgc3RyaW5ncyBzaWduYWwgYW4gZXJyb3IuICBXaGVuIHVucGFja2luZywgdGhlCiBy ZXN1bHRpbmcgc3RyaW5nIGNvbnRhaW5zIGFsbCBieXRlcyB1cCB0byAoYnV0IGV4Y2x1ZGlu ZykgdGhlIG51bGwKIGJ5dGUuCiAKLUBxdW90YXRpb24gQ2F1dGlvbgotSWYgYSBwcmUtYWxs b2NhdGVkIHN0cmluZyBpcyBwcm92aWRlZCB0byBAY29kZXtiaW5kYXQtcGFja30sIHRoZQot cGFja2VkIG91dHB1dCB3aWxsIG5vdCBiZSBwcm9wZXJseSBudWxsLXRlcm1pbmF0ZWQgdW5s ZXNzIHRoZQotcHJlLWFsbG9jYXRlZCBzdHJpbmcgYWxyZWFkeSBoYXMgYSBudWxsIGJ5dGUg YXQgdGhlIGFwcHJvcHJpYXRlCi1sb2NhdGlvbi4KLUBlbmQgcXVvdGF0aW9uCi0KIElmIEB2 YXJ7bGVufSBpcyBwcm92aWRlZDogQGNvZGV7c3Ryen0gYmVoYXZlcyB0aGUgc2FtZSBhcyBA Y29kZXtzdHJ9CiB3aXRoIG9uZSBkaWZmZXJlbmNlOiBXaGVuIHVucGFja2luZywgdGhlIGZp cnN0IG51bGwgYnl0ZSBlbmNvdW50ZXJlZAogaW4gdGhlIHBhY2tlZCBzdHJpbmcgYW5kIGFs bCBzdWJzZXF1ZW50IGJ5dGVzIGFyZSBleGNsdWRlZCBmcm9tIHRoZQpkaWZmIC0tZ2l0IGEv bGlzcC9lbWFjcy1saXNwL2JpbmRhdC5lbCBiL2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQuZWwK aW5kZXggOWJhODlhNWUzZi4uNDZlMmE0OTAxYyAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1s aXNwL2JpbmRhdC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYmluZGF0LmVsCkBAIC00NTAs NiArNDUwLDkgQEAgYmluZGF0LS1wYWNrLXN0cnoKICAgICAgICAgOzsgbmVlZCB0byBzY2Fu IHRoZSBpbnB1dCBzdHJpbmcgbG9va2luZyBmb3IgYSBudWxsIGJ5dGUuCiAgICAgICAgIChl cnJvciAiTnVsbCBieXRlIGVuY291bnRlcmVkIGluIGlucHV0IHN0cnogc3RyaW5nIikpCiAg ICAgICAoYXNldCBiaW5kYXQtcmF3ICgrIGJpbmRhdC1pZHggaSkgKGFyZWYgdiBpKSkpCisg ICAgOzsgRXhwbGljaXRseSB3cml0ZSBhIG51bGwgdGVybWluYXRvciBpbiBjYXNlIHRoZSB1 c2VyIHByb3ZpZGVkIGEKKyAgICA7OyBwcmUtYWxsb2NhdGVkIHN0cmluZyB0byBiaW5kYXQt cGFjayB0aGF0IHdhc24ndCB6ZXJvZWQgZmlyc3QuCisgICAgKGFzZXQgYmluZGF0LXJhdyAo KyBiaW5kYXQtaWR4IGxlbikgMCkKICAgICAoc2V0cSBiaW5kYXQtaWR4ICgrIGJpbmRhdC1p ZHggbGVuIDEpKSkpCiAKIChkZWZ1biBiaW5kYXQtLXBhY2stYml0cyAobGVuIHYpCmRpZmYg LS1naXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwgYi90ZXN0L2xp c3AvZW1hY3MtbGlzcC9iaW5kYXQtdGVzdHMuZWwKaW5kZXggN2QxMjMzZGVkNy4uY2MyMjNh ZDE0ZSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvYmluZGF0LXRlc3RzLmVs CisrKyBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2JpbmRhdC10ZXN0cy5lbApAQCAtMTgyLDgg KzE4Miw4IEBAIGJpbmRhdC10ZXN0LS1zdHItc3Ryei1wcmVhbGxvYwogICAgICAgICAgICAg ICAgICgoKCh4IHN0cnogMikpICgoeCAuICJhIikpKSAuICJheCIpCiAgICAgICAgICAgICAg ICAgKCgoKHggc3RyeiAyKSkgKCh4IC4gImFiIikpKSAuICJhYiIpCiAgICAgICAgICAgICAg ICAgKCgoKHggc3RyeiAyKSkgKCh4IC4gImFiYyIpKSkgLiAiYWIiKQotICAgICAgICAgICAg ICAgICgoLChiaW5kYXQtdHlwZSBzdHJ6KSAiIikgLiAieHgiKQotICAgICAgICAgICAgICAg ICgoLChiaW5kYXQtdHlwZSBzdHJ6KSAiYSIpIC4gImF4IikpKQorICAgICAgICAgICAgICAg ICgoLChiaW5kYXQtdHlwZSBzdHJ6KSAiIikgLiAiXDB4IikKKyAgICAgICAgICAgICAgICAo KCwoYmluZGF0LXR5cGUgc3RyeikgImEiKSAuICJhXDAiKSkpCiAgICAgKGxldCAoKHByZWFs bG9jIChtYWtlLXN0cmluZyAyID94KSkpCiAgICAgICAoYXBwbHkgIydiaW5kYXQtcGFjayAo YXBwZW5kIChjYXIgdGMpIChsaXN0IHByZWFsbG9jKSkpCiAgICAgICAoc2hvdWxkIChlcXVh bCBwcmVhbGxvYyAoY2RyIHRjKSkpKSkpCi0tIAoyLjM2LjEKCg== --------------Tu82aCDlzFwchq98eCF7Ylta--