From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gergely Czuczy Newsgroups: gmane.emacs.bugs Subject: bug#28308: Build failure on FreeBSD/aarch64 Date: Thu, 2 Nov 2017 22:03:41 +0100 Message-ID: <95b89a6c-99ce-cca9-b401-6196b496f554@harmless.hu> References: <2e5f41f7-e005-c28f-c04a-79953a804f71@harmless.hu> <8760d17pyj.fsf@users.sourceforge.net> <9ae1840f-9056-8771-43fa-b27bbd2b1bd3@harmless.hu> <87k218g33g.fsf@users.sourceforge.net> <2fbe77fe-1258-cef2-32e2-f741da514151@harmless.hu> <83y3powdsv.fsf@gnu.org> <87k215lqdf.fsf@users.sourceforge.net> <837ex5thtt.fsf@gnu.org> <83tw09s148.fsf@gnu.org> <83bmmhrw84.fsf@gnu.org> <29f4260c-2fff-9051-5882-0acec819739f@harmless.hu> <8760bag128.fsf@users.sourceforge.net> <83wp3qcn5k.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1509656657 27649 195.159.176.226 (2 Nov 2017 21:04:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 2 Nov 2017 21:04:17 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 Cc: 28308@debbugs.gnu.org To: Noam Postavsky , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 02 22:04:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAMei-000660-5r for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Nov 2017 22:04:04 +0100 Original-Received: from localhost ([::1]:33896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAMep-0004pd-Gl for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Nov 2017 17:04:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAMeh-0004ol-Gu for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2017 17:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAMeg-0004Vn-Lo for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2017 17:04:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAMeg-0004Vb-Hl for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2017 17:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eAMeg-0001TU-2Q for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2017 17:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gergely Czuczy Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Nov 2017 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28308 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28308-submit@debbugs.gnu.org id=B28308.15096566395659 (code B ref 28308); Thu, 02 Nov 2017 21:04:02 +0000 Original-Received: (at 28308) by debbugs.gnu.org; 2 Nov 2017 21:03:59 +0000 Original-Received: from localhost ([127.0.0.1]:48357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAMec-0001TC-O9 for submit@debbugs.gnu.org; Thu, 02 Nov 2017 17:03:59 -0400 Original-Received: from marvin.harmless.hu ([195.56.55.204]:64147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAMeZ-0001Sv-LF for 28308@debbugs.gnu.org; Thu, 02 Nov 2017 17:03:57 -0400 Original-Received: from 85-238-70-59.pool.digikabel.hu ([85.238.70.59] helo=[10.219.16.1]) by marvin.harmless.hu with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.88 (FreeBSD)) (envelope-from ) id 1eAMeM-000B2t-E2; Thu, 02 Nov 2017 21:03:42 +0000 In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139377 Archived-At: On 2017. 10. 31. 18:31, Noam Postavsky wrote: > tags 28308 + patch > quit > > On Tue, Oct 24, 2017 at 2:43 PM, Noam Postavsky > wrote: > >> It seems that the memory pointer to by float_block->floats becomes >> invalid following the dumping process. > The following patch which makes FreeBSD use the hybrid malloc scheme fixes it: > > diff --git a/configure.ac b/configure.ac > index d294412dc4..2e690987a6 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2206,7 +2206,7 @@ AC_DEFUN > case "$opsys" in > ## darwin ld insists on the use of malloc routines in the System framework. > darwin | mingw32 | nacl | sol2-10) ;; > - cygwin) hybrid_malloc=yes > + freebsd | cygwin) hybrid_malloc=yes > system_malloc= ;; > *) test "$ac_cv_func_sbrk" = yes && > system_malloc=$emacs_cv_sanitize_address;; > esac > diff --git a/src/gmalloc.c b/src/gmalloc.c > index baaff58050..8fd05fe845 100644 > --- a/src/gmalloc.c > +++ b/src/gmalloc.c > @@ -1509,9 +1509,13 @@ gdefault_morecore (ptrdiff_t increment) > return bss_sbrk (increment); > } > #endif > +#ifdef HAVE_SBRK > result = (void *) __sbrk (increment); > if (result == (void *) -1) > return NULL; > +#else > + result = NULL; > +#endif > return result; > } So, the amd64 and the aarch64 builds have finished: GNU Emacs 26.0.50 (build 1, amd64-portbld-freebsd11.0) of 2017-11-02 GNU Emacs 26.0.50 (build 1, aarch64-portbld-freebsd12.0) of 2017-11-02 Both are functional. Regarding updating the port, that's rather simple, you don't have to update the whole OS or anything similar. Here's how you can do it: cd /usr/ports/editors/emacs-devel rm distinfo rm -rf work vi Makefile # adjust GH_TAGNAME with the commit id. make fetch; make makesum That will update the required things to build it. However, if the installed files have changed, plist might have to be adjusted for the install target, but just ignore that. If you touch the missing files, that's sufficient (if happens at all). If this version will be the fix for the issue, could you please let me know which commit has it? I would like to let the port's maintainer know, so he can update the port in the master branch, fixing aarch64 support finally. Thank you very much for the help.