From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#75226: [31.0.50] C++ ts-mode missing "alignof" as keyword Date: Fri, 3 Jan 2025 00:50:46 -0800 Message-ID: <95EAF964-0C9F-4719-8AF0-4F9912C9FC8B@gmail.com> References: <7F2C7BC4-F609-4C59-BF1D-BAE12F10CFFE@gmail.com> <86ed1llntt.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34929"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75226@debbugs.gnu.org, Jacob Faibussowitsch To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 03 09:52:29 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTdPx-0008yb-3H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Jan 2025 09:52:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTdPc-0005ip-9B; Fri, 03 Jan 2025 03:52:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTdPW-0005iJ-D2 for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 03:52:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTdPW-0000qh-4a for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 03:52:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=rlXEBUyGSHjc/Lnyr9NEZvkW8HOiPhpMBag9Kktwebo=; b=s2rtohGSY2FUG0btPZhJNwQMPwqG8VGJBCH0Qj0CgFM6l0w8C1d26eDz13gEh4Rs5i+bRS51Rn5Qo88wwmf3VKcU8aVHf6CtgtJxsl3gG3cbbdMi9NROEe6Xrbp7t8L3k6Qc9ukkeNsOSUrU0hEIH0oZc/2m7AYrjxjQlmZIlUz97be+7PVjhg0J7++6s210E4cwi2ZfL5lFsy3xwqcQ+fsDvssdiIW9Q17Ws3LXFC0LRrp5KgNTKCx28TXl5a4Ya5sjAXUOmO56JuN4GSt2KtLsP9nanzM6sQYQYWDi01F09+IHj3IGP7S+xWKh8+mdz+aoGyvnlRYlt5rgcRyvxQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTdPV-0002po-Pv for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 03:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2025 08:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75226 X-GNU-PR-Package: emacs Original-Received: via spool by 75226-submit@debbugs.gnu.org id=B75226.173589426310759 (code B ref 75226); Fri, 03 Jan 2025 08:52:01 +0000 Original-Received: (at 75226) by debbugs.gnu.org; 3 Jan 2025 08:51:03 +0000 Original-Received: from localhost ([127.0.0.1]:49475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTdOY-0002nE-0w for submit@debbugs.gnu.org; Fri, 03 Jan 2025 03:51:02 -0500 Original-Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:53483) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTdOV-0002n1-LH for 75226@debbugs.gnu.org; Fri, 03 Jan 2025 03:51:00 -0500 Original-Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2ef28f07dbaso13215890a91.2 for <75226@debbugs.gnu.org>; Fri, 03 Jan 2025 00:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735894258; x=1736499058; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rlXEBUyGSHjc/Lnyr9NEZvkW8HOiPhpMBag9Kktwebo=; b=FPtVJgaWfvZb8nQp39dtz7NisLz76MKxZu8K0WujthfaIRoJQM/JX8sNrij82hvgRi SthWmWVF/5eaPtdDSoL450MKCvNN4FeiUUUk0LCdzurA/2ll82FIwYvBOqWcelUDZvL3 cHtGaGKRBNc2WVaNrAQ+4jtUbfta3S7s+3Rr6GhMM/Wfq5o6aStqpwi8uMyGNS5k1n39 XrEgZxIYbXO5ZTtyphxjmu42JcDgFBhVegtr++aLeNkhNA4ES0MqzdV/zh0Mi/GqE6CT M0+ZyHTt024iIn9kauvzgZlx4V+KqMvuhqxtdMtcL7OF1uZL5AwoMaKXXpCTpDdH7ecw woKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735894258; x=1736499058; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rlXEBUyGSHjc/Lnyr9NEZvkW8HOiPhpMBag9Kktwebo=; b=ivHBYPcZ6ZxUykKct1O2yyMFp7oonXy7MnRclVdCBj8a4xxM8gi8CO0wMKbbfTsLZp ZY1qtT4B+A2nk1y89YTT8lwTLOkyQwxyz56sBf/cFZoXk3+ZVRBTGmdZUH2vq6MLdz4/ jN4wLFqtsGkL+A8awRnT9DpyPyvXKkpXrz+DGotCFbXx1iwXJQ84aP7AQZIrBHUGRrNT xio3FLlBOOjbtDdAFNRh5wJ2cjii860eCxrw92UMaDAmU6tYkv2sMT3uVMPS8VFGZzD3 KQgG9OQkn+cCKFAx+zfxccq/GOxaOt4p5JR3V1oTWGAzYjHRRVoKJvzExATvdovvTDRJ tqdw== X-Forwarded-Encrypted: i=1; AJvYcCWROJCijmN7UTvyHOOTXNvPubIr2QxMXk8xk05lowXMQoeg8P67bb6SqqMaiHGXeBzyJgq/uQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxjAVl/O4NtHC3i1obuJdhMks9HergmyHf13hWZA6R4XuH0b/JV 1Xug9bonoooHltUSyfKELdDMeuf+MvpppP1nMcPvd7w/0kNhf417 X-Gm-Gg: ASbGncv6KZTj8TBWHhIWbdh81zNDYSysCdvT7Zc/7+trkrA1oO3DnoFX+eYEZT+uy5x W2QpVlJRCpfY+qFjI6nSoM2ROLFoSfb8k24zX8loYAZgN+rnpxM4ZCWWE1DbQCcZ0KR+0CiCLaD PmlLbnMhiDeWM53OmLlz28rVDcTzCyhPZVB6sPx0+NZemMURBxfjlMHko2ezfLb3KPWfYGaCbYf lBBhkDwY6ART0+r9gs4mo/SQqv9oDZMZ09i1aacisRg9+DQUs2iFP9FkjoBC8dHptxcsnqtv22p kN1o X-Google-Smtp-Source: AGHT+IFm+cNelcQvDhZCc5SjZL3PjXsbBJFPNWsh8SQlggfNTIxOvZS1lkjHoctFMVa0k7lY7GP2iw== X-Received: by 2002:a17:90b:5244:b0:2ee:f440:53ed with SMTP id 98e67ed59e1d1-2f452ed6a0dmr62611693a91.31.1735894258093; Fri, 03 Jan 2025 00:50:58 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:85eb:71bd:58ac:56a8]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f44779890bsm30926871a91.9.2025.01.03.00.50.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jan 2025 00:50:57 -0800 (PST) In-Reply-To: <86ed1llntt.fsf@gnu.org> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298265 Archived-At: > On Jan 1, 2025, at 10:41=E2=80=AFPM, Eli Zaretskii = wrote: >=20 >> Cc: 75226@debbugs.gnu.org >> From: Yuan Fu >> Date: Wed, 1 Jan 2025 19:28:35 -0800 >>=20 >>=20 >>=20 >>> On Dec 31, 2024, at 8:01=E2=80=AFAM, Jacob Faibussowitsch = wrote: >>>=20 >>> C++ ts-mode is missing =E2=80=9Calignof=E2=80=9D as a builtin = keyword like sizeof. >>>=20 >>> Best Regards, >>>=20 >>> Jacob Faibussowitsch >>> (Jacob Fai - booss - oh - vitch) >>>=20 >>=20 >> Thanks for reporting this. It seems tree-sitter-c/cpp supports = '__alignof__', '__alignof', '_alignof', 'alignof', =E2=80=98_Alignof=E2=80= =99, I can add all of them as keywords. The feature is added in = tree-sitter-c in Aug 9, 2023 [1], and appears in v0.20.5. >>=20 >> Eli, what=E2=80=99s the status of Emacs 30 right now? Can I push to = emacs-30 and have this change queued for Emacs 30.2? Or should I wait a = bit? >=20 > If this just adds a bunch of strings to c-ts-mode--keywords, it's okay > to add them on emacs-30. Not quite, right now emacs-30=E2=80=99s c-ts-mode works with grammar as = far back as v0.19.0 [1]. If we just add the keywords, c-ts-mode = wouldn=E2=80=99t work with grammar v0.20.4 and earlier. So I=E2=80=99m = going to add the new keywords with a check, which disables the new = keywords if grammar doesn=E2=80=99t recognize them. Also there=E2=80=99re = many missing keywords, none of which I have seen before :-), I need time = to go over them and see how are they supposed by be fontified (keyword = face or something else). So let=E2=80=99s wait for 30.2. [1] It might work with even earlier versions but I didn=E2=80=99t test, = v0.19.0 (4 years ago) is the earliest version that still has compatible = LANGUAGE_VERSION (13) with the latest tree-sitter lib. Yuan