From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#33035: 27.0.50; Deprecated macOS functions Date: Sun, 10 Jan 2021 17:22:48 +0100 Message-ID: <95A3370B-6EDC-470C-AAC4-7788BACDDDC7@acm.org> References: <1AE9CD2F-44C2-45DE-96CD-ED585E70E8DC@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_46746222-45F9-4405-BC90-C8FB5E219FED" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6879"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 33035@debbugs.gnu.org, Lars Ingebrigtsen , Philipp Stephani To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 10 17:23:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kydV3-0001XJ-Tg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 17:23:30 +0100 Original-Received: from localhost ([::1]:49088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kydV2-0004zw-0Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 11:23:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kydUc-0004xY-3g for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 11:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43256) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kydUb-0004NX-T5 for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 11:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kydUb-0004y2-Oa for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 11:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jan 2021 16:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33035 X-GNU-PR-Package: emacs Original-Received: via spool by 33035-submit@debbugs.gnu.org id=B33035.161029577519067 (code B ref 33035); Sun, 10 Jan 2021 16:23:01 +0000 Original-Received: (at 33035) by debbugs.gnu.org; 10 Jan 2021 16:22:55 +0000 Original-Received: from localhost ([127.0.0.1]:54799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kydUV-0004xS-1o for submit@debbugs.gnu.org; Sun, 10 Jan 2021 11:22:55 -0500 Original-Received: from mail18c50.megamailservers.eu ([91.136.10.28]:44480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kydUT-0004xI-AG for 33035@debbugs.gnu.org; Sun, 10 Jan 2021 11:22:54 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1610295771; bh=cYzeW4rxG00Q38z5ePFTrWL4DsbrmkZPbnsZXNTMY5Y=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=oRtdwGWkxrFkWhmdp66UtDPOTcislTmMmtsi2Kgz7mwxG2V6YRhitSfWQW2NdDKw8 SxNd8zjVTlfaOPsbl2OLpt6iAs+FrtaDrFL8VtIab+XxdjH4HXANPVgiU7BeUejj9s mLcUwugz7xyEK3kBxoBeFV+AwDta+qM9zMl3ljhs= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 10AGMnfQ012051; Sun, 10 Jan 2021 16:22:50 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F15.5FFB29DB.002D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=e5N4tph/ c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=M51BFTxLslgA:10 a=hIj89exaAAAA:8 a=7JJ0Wyi1aoXV4cVvzYYA:9 a=CjuIK1q_8ugA:10 a=Yfnsg6gVWrigF8FTW14A:9 a=B2y7HmGcmWMA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197643 Archived-At: --Apple-Mail=_46746222-45F9-4405-BC90-C8FB5E219FED Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii 10 jan. 2021 kl. 16.43 skrev Alan Third : > It certainy seems to do the job. There are still a couple of warnings > in nsselect.m, and I don't think this works in GNUstep, so we'll need > to retain the old method with #ifdef's or whatever. Sorry, that was an oversight. Here is a proper patch. --Apple-Mail=_46746222-45F9-4405-BC90-C8FB5E219FED Content-Disposition: attachment; filename=0001-Avoid-macOS-NSFilenamesPboardType-warning-bug-33035.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Avoid-macOS-NSFilenamesPboardType-warning-bug-33035.patch" Content-Transfer-Encoding: quoted-printable =46rom=202937497ca502db541fc78b4322c0ffb53c890912=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=2010=20Jan=202021=2017:05:18=20+0100=0A= Subject:=20[PATCH]=20Avoid=20macOS=20NSFilenamesPboardType=20warning=20= (bug#33035)=0A=0A*=20src/nsterm.m=20(ns_term_init):=0A([EmacsView=20= performDragOperation:]):=0A*=20src/nsselect.m=20(ns_string_to_symbol):=0A= (nxatoms_of_nsselect):=0ANSFilenamesPboardType=20was=20deprecated=20in=20= macOS=2010.14;=20use=0ANSPasteboardTypeFileURL=20instead.=0A---=0A=20= src/nsselect.m=20|=2015=20+++++++++++++--=0A=20src/nsterm.m=20=20=20|=20= 23=20++++++++++++++++++++---=0A=202=20files=20changed,=2033=20= insertions(+),=205=20deletions(-)=0A=0Adiff=20--git=20a/src/nsselect.m=20= b/src/nsselect.m=0Aindex=2027db9248e4..e0f76f92e5=20100644=0A---=20= a/src/nsselect.m=0A+++=20b/src/nsselect.m=0A@@=20-78,7=20+78,13=20@@=20= Updated=20by=20Christian=20Limpach=20(chris@nice.ch)=0A=20=20=20=20=20= return=20QSECONDARY;=0A=20=20=20if=20([t=20isEqualToString:=20= NSPasteboardTypeString])=0A=20=20=20=20=20return=20QTEXT;=0A-=20=20if=20= ([t=20isEqualToString:=20NSFilenamesPboardType])=0A+=20=20if=20([t=20= isEqualToString:=0A+#ifdef=20NS_IMPL_COCOA=0A+=20=20=20=20=20=20=20=20=20= =20=20NSPasteboardTypeFileURL=0A+#else=0A+=20=20=20=20=20=20=20=20=20=20=20= NSFilenamesPboardType=0A+#endif=0A+=20=20=20=20=20=20=20])=0A=20=20=20=20= =20return=20QFILE_NAME;=0A=20=20=20if=20([t=20isEqualToString:=20= NSPasteboardTypeTabularText])=0A=20=20=20=20=20return=20QTEXT;=0A@@=20= -467,7=20+473,12=20@@=20Updated=20by=20Christian=20Limpach=20= (chris@nice.ch)=0A=20=09=20=20=20=20=20[NSNumber=20numberWithLong:0],=20= NXPrimaryPboard,=0A=20=09=20=20=20=20=20[NSNumber=20numberWithLong:0],=20= NXSecondaryPboard,=0A=20=09=20=20=20=20=20[NSNumber=20numberWithLong:0],=20= NSPasteboardTypeString,=0A-=09=20=20=20=20=20[NSNumber=20= numberWithLong:0],=20NSFilenamesPboardType,=0A+=09=20=20=20=20=20= [NSNumber=20numberWithLong:0],=0A+#ifdef=20NS_IMPL_COCOA=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20NSPasteboardTypeFileURL,=0A+#else=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= NSFilenamesPboardType,=0A+#endif=0A=20=09=20=20=20=20=20[NSNumber=20= numberWithLong:0],=20NSPasteboardTypeTabularText,=0A=20=09=20nil]=20= retain];=0A=20}=0Adiff=20--git=20a/src/nsterm.m=20b/src/nsterm.m=0Aindex=20= 2defb9e2ee..6a03f0b1bc=20100644=0A---=20a/src/nsterm.m=0A+++=20= b/src/nsterm.m=0A@@=20-5602,7=20+5602,11=20@@=20Needs=20to=20be=20here=20= because=20ns_initialize_display_info=20()=20uses=20AppKit=20classes.=0A=20= =20=20ns_drag_types=20=3D=20[[NSArray=20arrayWithObjects:=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= NSPasteboardTypeString,=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20NSPasteboardTypeTabularText,=0A= +#ifdef=20NS_IMPL_COCOA=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20NSPasteboardTypeFileURL,=0A+#else=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20NSFilenamesPboardType,=0A+#endif=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= NSPasteboardTypeURL,=20nil]=20retain];=0A=20=0A=20=20=20/*=20If=20= fullscreen=20is=20in=20init/default-frame-alist,=20focus=20isn't=20set=0A= @@=20-8533,9=20+8537,21=20@@=20-(BOOL)performDragOperation:=20(id=20= )=20sender=0A=20=20=20=20=20{=0A=20=20=20=20=20=20=20= return=20NO;=0A=20=20=20=20=20}=0A-=20=20/*=20FIXME:=20= NSFilenamesPboardType=20is=20deprecated=20in=2010.14,=20but=20the=0A-=20=20= =20=20=20NSURL=20method=20can=20only=20handle=20one=20file=20at=20a=20= time.=20=20Stick=20with=20the=0A-=20=20=20=20=20existing=20code=20at=20= the=20moment.=20=20*/=0A+=20=20/*=20NSFilenamesPboardType=20is=20= deprecated=20in=20macOS=2010.14,=20but=20GNUstep=20may=0A+=20=20=20=20=20= not=20have=20NSPasteboardTypeFileURL.=20*/=0A+#ifdef=20NS_IMPL_COCOA=0A+=20= =20else=20if=20([type=20isEqualToString:=20NSPasteboardTypeFileURL])=0A+=20= =20=20=20{=0A+=20=20=20=20=20=20type_sym=20=3D=20Qfile;=0A+=0A+=20=20=20=20= =20=20NSArray=20*urls=20=3D=20[pb=20readObjectsForClasses:=20@[[NSURL=20= self]]=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20options:=20= nil];=0A+=20=20=20=20=20=20NSEnumerator=20*uenum=20=3D=20[urls=20= objectEnumerator];=0A+=20=20=20=20=20=20NSURL=20*url;=0A+=20=20=20=20=20=20= while=20((url=20=3D=20[uenum=20nextObject]))=0A+=20=20=20=20=20=20=20=20= strings=20=3D=20Fcons=20([[url=20path]=20lispString],=20strings);=0A+=20=20= =20=20}=0A+#else=20=20//=20!defined=20NS_IMPL_COCOA=0A=20=20=20else=20if=20= ([type=20isEqualToString:=20NSFilenamesPboardType])=0A=20=20=20=20=20{=0A= =20=20=20=20=20=20=20NSArray=20*files;=0A@@=20-8551,6=20+8567,7=20@@=20= -(BOOL)performDragOperation:=20(id=20)=20sender=0A=20=20=20= =20=20=20=20while=20(=20(file=20=3D=20[fenum=20nextObject])=20)=0A=20=20=20= =20=20=20=20=20=20strings=20=3D=20Fcons=20([file=20lispString],=20= strings);=0A=20=20=20=20=20}=0A+#endif=20=20//=20!defined=20= NS_IMPL_COCOA=0A=20=20=20else=20if=20([type=20isEqualToString:=20= NSPasteboardTypeURL])=0A=20=20=20=20=20{=0A=20=20=20=20=20=20=20NSURL=20= *url=20=3D=20[NSURL=20URLFromPasteboard:=20pb];=0A--=20=0A2.21.1=20= (Apple=20Git-122.3)=0A=0A= --Apple-Mail=_46746222-45F9-4405-BC90-C8FB5E219FED--