From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Date: Sun, 21 Apr 2019 13:27:03 +0000 (UTC) Message-ID: <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default> References: <96cafba3-7ba2-4e87-8f9d-e53825fd1dde@default> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207617"; mail-complaints-to="usenet@blaine.gmane.org" To: 35353@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 21 15:30:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hICXs-000rpD-UV for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2019 15:30:13 +0200 Original-Received: from localhost ([127.0.0.1]:53276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hICXr-0005Dh-VC for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2019 09:30:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hICXl-0005DO-0b for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 09:30:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hICXk-0001DQ-0Y for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 09:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hICXj-0001Cg-1K for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 09:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hICXi-00020H-Lh for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Apr 2019 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35353 X-GNU-PR-Package: emacs Original-Received: via spool by 35353-submit@debbugs.gnu.org id=B35353.15558533547617 (code B ref 35353); Sun, 21 Apr 2019 13:30:02 +0000 Original-Received: (at 35353) by debbugs.gnu.org; 21 Apr 2019 13:29:14 +0000 Original-Received: from localhost ([127.0.0.1]:47946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hICWv-0001yn-QH for submit@debbugs.gnu.org; Sun, 21 Apr 2019 09:29:14 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:54486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hICWt-0001yQ-So for 35353@debbugs.gnu.org; Sun, 21 Apr 2019 09:29:12 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3LDSxDq195677 for <35353@debbugs.gnu.org>; Sun, 21 Apr 2019 13:29:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=lrkdWZ6jsKBAOV4SUSuJPRQcboQss8/CWfoNMv/SLzg=; b=KIENp/aM7E/iT0FE9/JTsdjGlc+YxtxLbxgiOvnAcIPueR9iLzjcJqtCsiGGQL5hYNbz 3LOvNszVqaiIzwOaldf2zILFAorVNQiYR0L2x6C7vPz7mGuBP4vCaxEijHHeX7BpBSWV QpedKu71A2xssI7+6VnVzoKgiMlXUFp++qbIHExcrsjja5LVXqH+nxhCCSSCVKJNUy5t InbKPJMcT1YdnpDQYQ64i8Puy14n3ajMplSRdQ0BCW3dIEKDTvkuj6oAmqjHzLDMMcKD gPknfwMJFH5T7onhDlilApki1aMgg1J2k7EEany2k/UsJ4gEN0VtbF9yhlgtBzI5J9dw 6g== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2ryv2pu0e3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <35353@debbugs.gnu.org>; Sun, 21 Apr 2019 13:29:05 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3LDR5MN128636 for <35353@debbugs.gnu.org>; Sun, 21 Apr 2019 13:27:05 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2s0dwdc7ry-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <35353@debbugs.gnu.org>; Sun, 21 Apr 2019 13:27:05 +0000 Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3LDR4Xo010917 for <35353@debbugs.gnu.org>; Sun, 21 Apr 2019 13:27:04 GMT In-Reply-To: <96cafba3-7ba2-4e87-8f9d-e53825fd1dde@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4834.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9233 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=13 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=471 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904210103 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9233 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=13 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=494 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904210104 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157944 Archived-At: > Please respect `mouse-1-click-follows-link'. Please contrast what, say, `compile.el' does, which is simple and Emacs-conventional: (define-key map [mouse-2] 'compile-goto-error) (define-key map [follow-link] 'mouse-face) See (elisp) `Key Binding Conventions': Many special major modes, like Dired, Info, Compilation, and Occur, are designed to handle read-only text that contains "hyper-links". Such a major mode should redefine 'mouse-2' and to ^^^^^^^^^^^^^^^^^^^^^^^^^ follow the links. It should also set up a 'follow-link' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ condition, so that the link obeys 'mouse-1-click-follows-link'. *Note Clickable Text::. *Note Buttons::, for an easy method of implementing such clickable links. Each core Emacs developer who defines a major mode with clickable links should be familiar with and respect this convention. Before Emacs distributes a new library - and certainly before it gives new commands keys that have long been bound to other commands, especially commands Emacs still offers - the new library should be vetted to ensure that it doesn't disregard Emacs conventions. We'll soon be in release 27. This bug was introduced in Emacs 25.