From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sskostyaev@gmail.com Newsgroups: gmane.emacs.bugs Subject: bug#61006: 29.0.60; Wrong indentation in go-ts-mode Date: Wed, 25 Jan 2023 11:06:45 +0700 Message-ID: <94c6de01accfebc10cd7a0377e0c1087fdae5086.camel@gmail.com> References: <4e1f92dc54d94cf4860490c643b5fd565deb0e1a.camel@gmail.com> <3aLr20wUmwH_Z8sYXoG4FACIHNCCJlDFFAdFCUNNe5FTsaozqHRxHhZ6fwtVXlRZMmfA_7PDN_rE-YfxrhtEtq5SOMnd0S2LeMgCNGQlyco=@rjt.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11552"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.46.3 Cc: 61006@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 06:32:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKYON-0002qr-RT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 06:32:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKYOC-0002WS-Ff; Wed, 25 Jan 2023 00:32:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKYOB-0002WE-2u for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 00:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKYOA-0008Ht-R4 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 00:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKYOA-0004BB-5i for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 00:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: sskostyaev@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 05:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61006 X-GNU-PR-Package: emacs Original-Received: via spool by 61006-submit@debbugs.gnu.org id=B61006.167462468716017 (code B ref 61006); Wed, 25 Jan 2023 05:32:02 +0000 Original-Received: (at 61006) by debbugs.gnu.org; 25 Jan 2023 05:31:27 +0000 Original-Received: from localhost ([127.0.0.1]:58048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKYNb-0004AH-2C for submit@debbugs.gnu.org; Wed, 25 Jan 2023 00:31:27 -0500 Original-Received: from mail-lf1-f45.google.com ([209.85.167.45]:44790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKX3m-000811-0P for 61006@debbugs.gnu.org; Tue, 24 Jan 2023 23:06:54 -0500 Original-Received: by mail-lf1-f45.google.com with SMTP id w11so23200303lfu.11 for <61006@debbugs.gnu.org>; Tue, 24 Jan 2023 20:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bTM13xyaL0YSJyQkh7/xS1rbHAFQTkC5OfwOm7TeJJk=; b=FT5/tb0RqsU4ds51jCJ8Inp0JBlUV1ztDK98ezMpW6WwGFnqakHdc77Xb/GLPvxfMk x958zxmn84/m3Mm6zo+MEYbDcxg3Qu92RmebqLs6NUTqygksNvqtwajFbC07nNn8/oVf CnNFRcnaA6ZTjV4a0tAdIMoO7hPcuWue/fnc64umqjP0wu2NDpsT6ONOzjDW2idXASjc lsYhwrJ4YOh1e3EB6G35M351oWy7i9Uu/WUgqrFEgUWHJwx/8kcebQtIaa0uXJDF8I7O btI30YJKFBNDZzMlfyUg3IHGpNlJW+eleyv7BQtgBGK6wPm+emAOW075Jq2K8yF008Gp OjPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bTM13xyaL0YSJyQkh7/xS1rbHAFQTkC5OfwOm7TeJJk=; b=Y75q/jZwwoqLGNkaJltVKQv/Zm/9qRsvhIOqA0vo3X5l6JqiqMjy/iQDXfJnk8UjBh z3v6IOXmcAL1J58AAIwhuivGHyV7Co94srv+E+VTPd5vgknBP4j9J6giw/KlyfficNvW sJkiVWdcoJn6rc4v97mgqPZbmtFrWb7QA0UM0RzmfUGYe2wd0uMyiDAeaelBOwDk5dBA 1m6n3MogVhJh92On/J3OjrPJ9Oa/MMDL4JIOlCJXAHsHbLPTrYF4Rmjbjt+XlhOP/Y6s p7rJll5EVBpF2TGRGw4UHFFHKxDeAHAP4q7RH5YqRYfRadv3ELfPDHEhQug/EPADZC08 AzaQ== X-Gm-Message-State: AFqh2kotArkWGkCJecP6oy4ORxh66FtCoq59QoEfiEzwFSzrDOJd8Gcb s89uYZOxDmUcvUz9TktAvkM= X-Google-Smtp-Source: AMrXdXuKEJHfLyWuOB+G594J23fAl6Sjca1csSPfkvPyZzaDbXlWggOx8ZEjq0tCKIAIHyVKQc2dhA== X-Received: by 2002:a05:6512:1312:b0:4d5:a689:d7e8 with SMTP id x18-20020a056512131200b004d5a689d7e8mr7385491lfu.32.1674619607805; Tue, 24 Jan 2023 20:06:47 -0800 (PST) Original-Received: from [192.168.0.14] ([90.189.160.165]) by smtp.gmail.com with ESMTPSA id h5-20020a05651211c500b004cb1b4634edsm337366lfr.194.2023.01.24.20.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 20:06:47 -0800 (PST) In-Reply-To: <3aLr20wUmwH_Z8sYXoG4FACIHNCCJlDFFAdFCUNNe5FTsaozqHRxHhZ6fwtVXlRZMmfA_7PDN_rE-YfxrhtEtq5SOMnd0S2LeMgCNGQlyco=@rjt.dev> X-Mailman-Approved-At: Wed, 25 Jan 2023 00:31:25 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254101 Archived-At: Thank you! Fixed now. =D0=92 =D0=A1=D1=80, 25/01/2023 =D0=B2 02:46 +0000, Randy Taylor =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: > On Tuesday, January 24th, 2023 at 21:35, Randy Taylor > wrote: > >=20 > > On Sunday, January 22nd, 2023 at 05:00, > > sskostyaev@gmail.com=C2=A0sskostyaev@gmail.com=C2=A0wrote: > >=20 > > > Hi. Thank you all for great work. > > > In go-ts-mode indentation breaks in function or method definition > > > if > > > arguments placed on separate lines like this: > > > `func transform( s string, ) string {` > > > This code should be indented like this: > > > `func transform( s string, ) string {` > >=20 > >=20 > > Thanks for the report. I've attached a patch that fixes this. > >=20 > > > Also `go-ts-mode-indent-offset' should be 8 by default. In go > > > world there is gofmt which is a real standart for code > > > indentation. It would be great if emacs will provide the same > > > indentation out of the box. > >=20 > >=20 > > And addresses this. > >=20 > > > There is also other issue - sometimes go-ts-mode syntax > > > highliting breaks when I actively use it with `lsp-mode`- > > > refactorings, auto formatting etc. But I can't reproduce it > > > with`eglot`. > >=20 > >=20 > > Seems like an `lsp-mode` problem then? I only use `eglot` and > > haven't noticed anything amiss. >=20 > Addendum to my last patch: added indentation support for interfaces > as it was missing. Everything else is the same. --=20 Best regards, Sergey Kostyaev