From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#75310: Eliminate obsolete alias warning Date: Sat, 4 Jan 2025 11:26:38 -0800 Message-ID: <94CBEFD3-6E58-4056-B73C-B5FC6AB6E1B9@gmail.com> References: <86h66ggl6a.fsf@gnu.org> <02134785-ad5d-8b9a-4b51-64e8d466b038@mavit.org.uk> <86bjwogewx.fsf@gnu.org> <868qrrhq8h.fsf@gnu.org> <77CBB14F-094D-48DA-A7D1-ED9E1F43DAD3@gmail.com> <86a5c7f0dn.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34331"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Peter Oliver , 75310@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 20:27:08 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU9nf-0008lk-TR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 20:27:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU9nb-00089T-HD; Sat, 04 Jan 2025 14:27:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU9na-000896-3W for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:27:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU9nZ-0002Y2-Q0 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:27:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=b9ZFxqLxxxxczA3SCUVi4bC+oVQuHeuFWyyZ8qGeSVA=; b=KOgi1bDk5qq2oOQtAskHNsqtB151Qup/b++VPodUhwl/hq3SGnbG8mS9i5b9Ig20oM78BdK0uMI0HOO0VXZeINrNR6kYlZh0lVaIuL7yqmWGA/xsbDwcXF0QzuIBPvyW8dAM/0gtINNOAQysIwQ0tQ3m8Rs71tzDu54ucofwV5x0Xc+kxOsG+NGwgxLJu12SKo+W0iufGhZj1Pda0xsg92oXpB+JhNCYg7w6GNC7ZpwyU14YPp+ZBWKiVYLeWIBiZ5Vek6njs9PcTCFkxk7v60QOTQ14oKCmgz1Kjq88zLqlHxJL4lirD2j2V4KON+qUf6WiiF2edn0RXOVDv4Flgg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU9nZ-0000QB-Ka for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 19:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75310 X-GNU-PR-Package: emacs Original-Received: via spool by 75310-submit@debbugs.gnu.org id=B75310.17360188131589 (code B ref 75310); Sat, 04 Jan 2025 19:27:01 +0000 Original-Received: (at 75310) by debbugs.gnu.org; 4 Jan 2025 19:26:53 +0000 Original-Received: from localhost ([127.0.0.1]:57444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU9nR-0000PX-5S for submit@debbugs.gnu.org; Sat, 04 Jan 2025 14:26:53 -0500 Original-Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:48137) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tU9nP-0000PL-9N for 75310@debbugs.gnu.org; Sat, 04 Jan 2025 14:26:52 -0500 Original-Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-216281bc30fso215517205ad.0 for <75310@debbugs.gnu.org>; Sat, 04 Jan 2025 11:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736018810; x=1736623610; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=b9ZFxqLxxxxczA3SCUVi4bC+oVQuHeuFWyyZ8qGeSVA=; b=XNg+eJfWk+BvOA2Q+uD71Y+ALWNvDuqsqg/pu7aO0g+yU8a0dC8KiCbZ++flhOIWek 6D4ylrJBQUSyEmnafNZBYsqFI9pde6Whx1t7aHqhF+eCMwR+xaHxXJuuRRfJ6TGW2/48 1Xg7/5rumEGx4pitXewoRdGoc2kcFQNgQONScauSTCFvFIVdW8UVS0blbbzeIyaruyCy vrK2WaWTXoJBj1AL16eBRzdLq+dyqxYWWqyBTKeAGIym2kszaW0E2vV9Ig3C+BZ3MEdH 1WOfJv4SO4P8iy/5aGqij66+VV/HbyapGlqdvcTw/Qklgc/+mfV1DA2qRBWaHlysZI88 vVVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736018810; x=1736623610; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b9ZFxqLxxxxczA3SCUVi4bC+oVQuHeuFWyyZ8qGeSVA=; b=MnHX0YjARsJeW+JipFPnAKtCEOYXeAZbJucBHTI7Wm23DvOBRhSppAO4J7RXZREmUZ HwrpjYlgRjALP2WLZCKvYOdkc0uarSfbBEsaxWNGaJyxNFWSLtfAarrZEPaOCv+NukOK Ci+QW4lgmEbHRQox0DurKUYexUHXDlsjPpK/o4X9lftjL/+fcea0YKCFmd4fFsxpLYbX lHh61q9u5VqfwwpFEgk6vZISc2HjPSFN2T1pe99p+7IzBR/WbZkKUW7DFPQAvx7GwpvC 34sglbC7Tp1SnjDPQiTRgQaQj4xWzvrHAtl6Po8y87t7m2RYjfP2OT/yjcFbR6S4s/Pj K/qg== X-Forwarded-Encrypted: i=1; AJvYcCUL1REL4Wu5x4/JmhVuFy+RN0XgfrM5BxRuHxHc9eD2w31wGZmEZ0/g/jN+tdI4k2SIvg1Klw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YztCMYY8ljss8LGIo32FSH2E5B9N22253BKRogXC+nB9AW57X5v oPqduDAYBNeLWdVaWG7+4w6Vgm+3zvwq1sX96JrbrpI92tr4vI2aS0/HQA== X-Gm-Gg: ASbGnctGKqr7sqFbxnKbDElHetRDEA2NNP6G77Rer2eOgQSXf3ycRWvDvhBvGxQxV9a B9v6WldYc2GeKWxqX86XKm6pTFxXk2oZTW+/P2dz2mFtXTD/dO267tsdVS9dfi7RilPkEj6ZuOg FWnymiSZN2bExzVJ/JGHdzLilMXvaxGu0p99Hwl0Bo9PWahrt4q1EKaI8hBEB74TkUBYMjzv9GW q2UQPlabHXpBW95hKVzq5XnSyE3hTKmS/0yNwGOLfMQmawz2UEbS+caJUl1az1T0aZpYDNtOuJY lnDD X-Google-Smtp-Source: AGHT+IEryvPgJUxY8MJ4OTvGR9rv76ZDDDUKjNsmXcqcFi7Ma9mGUsSrmqR6ntvZpI01xc2oH6/8bA== X-Received: by 2002:a17:903:22cf:b0:216:7ee9:21ff with SMTP id d9443c01a7336-219e6f38254mr859832745ad.49.1736018810137; Sat, 04 Jan 2025 11:26:50 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:c496:8cdf:4c5d:3617]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842b8e867ccsm26013854a12.47.2025.01.04.11.26.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Jan 2025 11:26:49 -0800 (PST) In-Reply-To: <86a5c7f0dn.fsf@gnu.org> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298459 Archived-At: > On Jan 4, 2025, at 12:29=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Yuan Fu >> Date: Fri, 3 Jan 2025 23:33:25 -0800 >> Cc: Peter Oliver , >> 75310@debbugs.gnu.org >>=20 >>> On Jan 3, 2025, at 7:27=E2=80=AFAM, Eli Zaretskii = wrote: >>>=20 >>>> Date: Fri, 3 Jan 2025 14:47:53 +0000 (GMT) >>>> From: Peter Oliver >>>> cc: 75310@debbugs.gnu.org >>>>=20 >>>> On Fri, 3 Jan 2025, Eli Zaretskii wrote: >>>>=20 >>>>> IOW, can you show a minimal recipe for reproducing the problem, >>>>> starting from "emacs -Q"? >>>>=20 >>>> $ src/emacs -Q --batch --eval "(progn (message emacs-version) = (require 'cl) (require 'treesit))" >>>> 31.0.50 >>>> Package cl is deprecated >>>> lisp/treesit.el: Warning: =E2=80=98loop=E2=80=99 is an obsolete = alias (as of 27.1); use =E2=80=98cl-loop=E2=80=99 instead. >>>=20 >>> Thanks. >>>=20 >>> Yuan, I think it would be good to rename 'loop' there to some other >>> name, do you agree? >>=20 >> I would definitely agree. I=E2=80=99ve always used cl-loop (and now I = try to not use it for new code). The only instance of =E2=80=9Cloop=E2=80=9D= I can find in treesit.el is in a named-let in treesit-transpose-sexps = wriiten by Theo, and it=E2=80=99s not the CL loop but a local function = defined by named-let. I wanted to rewrite it so it doesn=E2=80=99t use = named-let because it=E2=80=99s not very readable, but tbh I haven=E2=80=99= t find the time to understand that function well enough to rewrite it = (because it=E2=80=99s not very readable :-) >>=20 >> It could be that only I can=E2=80=99t understand it, but code should = be simple enough that even I can understand ;-) >=20 > Renaming the symbol is easy, and doesn't require you to understand the > code completely. We don't have to use cl-loop. Ah right, duh :-) Though I renamed the symbol and still gets the = deprecation message. There=E2=80=99s no other =E2=80=9Cloop=E2=80=9D in = treesit.el, only cl-loop. Could you maybe take a look? Yuan