* bug#49665: 28.0.50; Failing autorevert tests on Cygwin
@ 2021-07-20 16:26 Ken Brown
2021-07-20 17:37 ` Michael Albinus
0 siblings, 1 reply; 6+ messages in thread
From: Ken Brown @ 2021-07-20 16:26 UTC (permalink / raw)
To: 49665; +Cc: Michael Albinus
Some of the autorevert tests fail on Cygwin. The precise tests that
fail aren't the same in every run, but here's the result of the most
recent run on my 64-bit Cygwin system:
Ran 8 tests, 3 results as expected, 5 unexpected (2021-07-20 11:28:04-0400,
9.783866 sec)
5 unexpected results:
FAILED auto-revert-test00-auto-revert-mode
FAILED auto-revert-test01-auto-revert-several-files
FAILED auto-revert-test02-auto-revert-deleted-file
FAILED auto-revert-test05-global-notify
FAILED auto-revert-test07-auto-revert-several-buffers
And here's the result of the most recent run on my 32-bit Cygwin system:
Ran 8 tests, 4 results as expected, 4 unexpected (2021-07-20 11:35:17-0400,
19.531540 sec)
4 unexpected results:
FAILED auto-revert-test00-auto-revert-mode
FAILED auto-revert-test01-auto-revert-several-files
FAILED auto-revert-test02-auto-revert-deleted-file
FAILED auto-revert-test05-global-notify
I also see occasional failures of
auto-revert-test03-auto-revert-tail-mode on both architectures.
test02 and test05 have apparently been failing for a long time, but I
didn't notice it prior to commit fe16248b77, because all tests were
tagged as expensive before then and so weren't run by 'make check'. The
(sporadic) failures of test00, test01, and test03 started with that
commit, so they are almost certainly due to timing issues. I'm not sure
about test07, which wasn't added until later. All I know is that it
always fails on 64-bit and occasionally fails on 32-bit. This makes me
guess that it's also a timing issue, but I suppose there could be some
other bug that's specific to 64-bit.
I'm not interested in spending a lot of time on this (or asking anyone
else to spend time on it), because I've never seen a Cygwin user
complain about auto-revert mode. (Maybe no one uses it because it's
slow.) But I would like to stop seeing the test failures.
Here's one possibility: Skip test02 and test05 on Cygwin, with a FIXME
comment indicating that they've been failing for a long time and we
don't know why. Tag test00, test01, and test03 as expensive on Cygwin,
since we would have to make the tests much slower in order for them to
pass. I'm not sure about test07.
Other suggestions?
Thanks.
Ken
In GNU Emacs 28.0.50 (build 4, x86_64-pc-cygwin, GTK+ Version 3.22.28, cairo
version 1.17.4)
of 2021-07-20 built on moufang2
Repository revision: 61c1522ddedc45d85804ff2786bd301e9b487b32
Repository branch: master
Windowing system distributor 'The Cygwin/X Project', version 11.0.12012000
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY GFILENOTIFY PDUMPER PNG
RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49665: 28.0.50; Failing autorevert tests on Cygwin
2021-07-20 16:26 bug#49665: 28.0.50; Failing autorevert tests on Cygwin Ken Brown
@ 2021-07-20 17:37 ` Michael Albinus
2021-07-20 20:15 ` Ken Brown
0 siblings, 1 reply; 6+ messages in thread
From: Michael Albinus @ 2021-07-20 17:37 UTC (permalink / raw)
To: Ken Brown; +Cc: 49665
Ken Brown <kbrown@cornell.edu> writes:
Hi Ken,
> Some of the autorevert tests fail on Cygwin. The precise tests that
> fail aren't the same in every run, but here's the result of the most
> recent run on my 64-bit Cygwin system:
[...]
> I'm not interested in spending a lot of time on this (or asking anyone
> else to spend time on it), because I've never seen a Cygwin user
> complain about auto-revert mode. (Maybe no one uses it because it's
> slow.) But I would like to stop seeing the test failures.
>
> Here's one possibility: Skip test02 and test05 on Cygwin, with a FIXME
> comment indicating that they've been failing for a long time and we
> don't know why. Tag test00, test01, and test03 as expensive on Cygwin,
> since we would have to make the tests much slower in order for them to
> pass. I'm not sure about test07.
>
> Other suggestions?
We have the tag :unstable for such tests. You might tag all tests you're
not interested in. Something like this after the docstring:
:tags (when (eq system-type 'cygwin) '(:unstable))
Perhaps also a comment.
If you could provide me a recent Emacs 28 for cygwin, I could try to
check what's up.
> Thanks.
>
> Ken
Best regards, Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49665: 28.0.50; Failing autorevert tests on Cygwin
2021-07-20 17:37 ` Michael Albinus
@ 2021-07-20 20:15 ` Ken Brown
2021-07-20 21:23 ` Michael Albinus
0 siblings, 1 reply; 6+ messages in thread
From: Ken Brown @ 2021-07-20 20:15 UTC (permalink / raw)
To: Michael Albinus; +Cc: 49665
On 7/20/2021 1:37 PM, Michael Albinus wrote:
Hi Michael,
> We have the tag :unstable for such tests. You might tag all tests you're
> not interested in. Something like this after the docstring:
>
> :tags (when (eq system-type 'cygwin) '(:unstable))
>
> Perhaps also a comment.
Good idea. I'll do this after you've had a chance to look at it.
> If you could provide me a recent Emacs 28 for cygwin, I could try to
> check what's up.
Here they are:
64-bit: https://paste.c-net.org/ToughenTheory
32-bit: https://paste.c-net.org/ChewsAtomic
I've built them --with-x=no to reduce the number of dependent libraries. But
you'll still probably need a fairly up-to-date Cygwin installation to run them.
Thanks for taking a look.
Ken
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49665: 28.0.50; Failing autorevert tests on Cygwin
2021-07-20 20:15 ` Ken Brown
@ 2021-07-20 21:23 ` Michael Albinus
2021-07-27 17:47 ` Michael Albinus
0 siblings, 1 reply; 6+ messages in thread
From: Michael Albinus @ 2021-07-20 21:23 UTC (permalink / raw)
To: Ken Brown; +Cc: 49665
Ken Brown <kbrown@cornell.edu> writes:
> Hi Michael,
Hi Ken,
>> We have the tag :unstable for such tests. You might tag all tests you're
>> not interested in. Something like this after the docstring:
>> :tags (when (eq system-type 'cygwin) '(:unstable))
>> Perhaps also a comment.
>
> Good idea. I'll do this after you've had a chance to look at it.
Will do. Next days are busy, so I cannot promise to be fast.
>> If you could provide me a recent Emacs 28 for cygwin, I could try to
>> check what's up.
>
> Here they are:
>
> 64-bit: https://paste.c-net.org/ToughenTheory
>
> 32-bit: https://paste.c-net.org/ChewsAtomic
>
> I've built them --with-x=no to reduce the number of dependent
> libraries. But you'll still probably need a fairly up-to-date Cygwin
> installation to run them.
>
> Thanks for taking a look.
Thanks. I run a Windows 10 VM just for Emacs test purposes. No problem
to update Cygwin there.
> Ken
Best regards, Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49665: 28.0.50; Failing autorevert tests on Cygwin
2021-07-20 21:23 ` Michael Albinus
@ 2021-07-27 17:47 ` Michael Albinus
2021-07-28 11:48 ` Ken Brown
0 siblings, 1 reply; 6+ messages in thread
From: Michael Albinus @ 2021-07-27 17:47 UTC (permalink / raw)
To: Ken Brown; +Cc: 49665-done
Version: 28.1
Michael Albinus <Michael.Albinus@gmx.de> writes:
Hi Ken,
>>> We have the tag :unstable for such tests. You might tag all tests you're
>>> not interested in. Something like this after the docstring:
>>> :tags (when (eq system-type 'cygwin) '(:unstable))
>>> Perhaps also a comment.
>>
>> Good idea. I'll do this after you've had a chance to look at it.
>
> Will do. Next days are busy, so I cannot promise to be fast.
Finally, I've decided to compile Emacs myself on Cygwin, this allows me
to go forth and back between git revisions.
I could reproduce the problem, but I have no clear view yet what to do
with timings. So I've pushed a change to master which declares all tests
as :unstable on Cygwin, as discussed.
I'm closing this bug, but (as time permits) I'll try to do better. No
promise, and there's not too much spare time, but I hate it if code
written by me doesn't work.
>> Ken
Best regards, Michael.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#49665: 28.0.50; Failing autorevert tests on Cygwin
2021-07-27 17:47 ` Michael Albinus
@ 2021-07-28 11:48 ` Ken Brown
0 siblings, 0 replies; 6+ messages in thread
From: Ken Brown @ 2021-07-28 11:48 UTC (permalink / raw)
To: Michael Albinus; +Cc: 49665-done
On 7/27/2021 1:47 PM, Michael Albinus wrote:
> I'm closing this bug, but (as time permits) I'll try to do better. No
> promise, and there's not too much spare time, but I hate it if code
> written by me doesn't work.
Thanks, Michael, and thanks for looking at this.
Ken
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-28 11:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 16:26 bug#49665: 28.0.50; Failing autorevert tests on Cygwin Ken Brown
2021-07-20 17:37 ` Michael Albinus
2021-07-20 20:15 ` Ken Brown
2021-07-20 21:23 ` Michael Albinus
2021-07-27 17:47 ` Michael Albinus
2021-07-28 11:48 ` Ken Brown
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).