From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#21091: 25.0.50; `isearch-done' called before `isearch-update' raises wrong-type-arg error Date: Sat, 3 Sep 2016 22:43:54 -0700 (PDT) Message-ID: <947c6384-eeb3-475b-be8d-2277d0f799af@default> References: <87h99w9vlo.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1472967922 2276 195.159.176.226 (4 Sep 2016 05:45:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Sep 2016 05:45:22 +0000 (UTC) Cc: 21091@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 04 07:45:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgQF3-0008Pz-6R for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Sep 2016 07:45:17 +0200 Original-Received: from localhost ([::1]:48834 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgQF0-0000qC-SV for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Sep 2016 01:45:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgQEt-0000mr-Kx for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 01:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgQEo-0007BO-MS for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 01:45:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgQEo-0007BK-JD for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 01:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bgQEo-00051J-7X for bug-gnu-emacs@gnu.org; Sun, 04 Sep 2016 01:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Sep 2016 05:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21091 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug patch Original-Received: via spool by 21091-submit@debbugs.gnu.org id=B21091.147296784519216 (code B ref 21091); Sun, 04 Sep 2016 05:45:02 +0000 Original-Received: (at 21091) by debbugs.gnu.org; 4 Sep 2016 05:44:05 +0000 Original-Received: from localhost ([127.0.0.1]:49090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgQDt-0004zs-8A for submit@debbugs.gnu.org; Sun, 04 Sep 2016 01:44:05 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:30373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgQDr-0004zE-Hd for 21091@debbugs.gnu.org; Sun, 04 Sep 2016 01:44:03 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u845htGr002447 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 4 Sep 2016 05:43:56 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u845htM7011054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 4 Sep 2016 05:43:55 GMT Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u845hs3V030047; Sun, 4 Sep 2016 05:43:55 GMT In-Reply-To: <87h99w9vlo.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6753.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122922 Archived-At: > > Anyway, please consider somehow ensuring that `isearch-done' does not > > care whether `isearch--current-buffer' has a string value. >=20 > Make sense to me, I suggest the following (isearch-update checks for a > buffer value, so I went with that to be consistent): Haven't tested, but it looks good to me. I think that's all that's needed. Thanks for doing this.