From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Wed, 7 Apr 2021 01:44:07 +0300 Message-ID: <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> References: <87pmz8lc17.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39344"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: Ramesh Nedunchezian , 47566@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 07 00:45:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTuRb-000A75-6v for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Apr 2021 00:45:11 +0200 Original-Received: from localhost ([::1]:56012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTuRa-0008Sh-4k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Apr 2021 18:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTuRS-0008S6-UP for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2021 18:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTuRS-00063S-L2 for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2021 18:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lTuRS-00012A-Gd for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2021 18:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Apr 2021 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47566 X-GNU-PR-Package: emacs Original-Received: via spool by 47566-submit@debbugs.gnu.org id=B47566.16177490573902 (code B ref 47566); Tue, 06 Apr 2021 22:45:02 +0000 Original-Received: (at 47566) by debbugs.gnu.org; 6 Apr 2021 22:44:17 +0000 Original-Received: from localhost ([127.0.0.1]:42261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTuQj-00010s-Lf for submit@debbugs.gnu.org; Tue, 06 Apr 2021 18:44:17 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:39596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTuQi-00010e-56 for 47566@debbugs.gnu.org; Tue, 06 Apr 2021 18:44:16 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id g18-20020a7bc4d20000b0290116042cfdd8so142943wmk.4 for <47566@debbugs.gnu.org>; Tue, 06 Apr 2021 15:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2AttC5npYv/gOj8u6ERdbvlf0+BYnvm0mZM+G+QZqGY=; b=SJSNCsJgVwN0iXgaKSGvtlmQ4keyz4C1ggtwDplab1yncBLEKrPOYb4QJdHzMbx1L1 GXrjNr01FpnuK4i7/t86S+NGP4cJHuWBmFpmnW1BIzSFqLtzhu7s2rHmc/h7VdcOaxOv +Bv/ILQ6KGFQ+5kJHCVdGaXWT0uprR/z/UVCayGMnboo6v8uUvlXiFIErgj5lbY13xGK 1pOTlSE55rzm77ooWY7D/388anDxpJ9hhfURbVOA8inYHgDVZlRAvmJZ+1kTKJyQ2F8a vbUWUoDyZvVWKjSHD+mNUqK8OX2gDQUOjY1UJZp3waUbwJL8aWooNXX+1tgu30E40q9+ 3EvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2AttC5npYv/gOj8u6ERdbvlf0+BYnvm0mZM+G+QZqGY=; b=sGMLovGQZSb+fP8efTExZVyNWaJxKU4l76Za+KMFCavo5gt9T1QGLpvYD6X8WHJeq7 zo0+f3CFK2N8qE4x/DWrEqNy+gCXqdEOsui2/MylFm0U9IOtdZQNzKEHrPCREgbW4T0h 06GHt96liF62PpGCAlXmawSFC97qZUvsakL6c670z7onO27qM6tl7tvCX1yoinxsee0c l0K1D8JbbRESbGxCNBeRMMOyt+74Q1WL1hjp5f37864UafPkGFzCN2637HULDdKV4s8e RQUnLf0sEalDz6VEkvnxqrpCy+BUe75ucUqni7NIHw4dsueAE8w7FBcZwpnWppbAX5jz DHIg== X-Gm-Message-State: AOAM530JmJ0x6V6fcndeFuwSFNSn3YpF3qWJo/JT5T6gIOp6xd/ER1od N1nNjc10Emb5KMlAEOlATnZqxdlcYy4= X-Google-Smtp-Source: ABdhPJxtjuIoHF63XwRCLIXhoy0/dnkYcwnoq6Gm9P0XZybUTWd8BLajBkDDYSvPsnDatraTA7T2Ew== X-Received: by 2002:a1c:f605:: with SMTP id w5mr208372wmc.66.1617749050156; Tue, 06 Apr 2021 15:44:10 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l6sm33944764wrt.56.2021.04.06.15.44.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 15:44:09 -0700 (PDT) In-Reply-To: <87pmz8lc17.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203660 Archived-At: Hi Juri, On 05.04.2021 23:43, Juri Linkov wrote: > Could you provide a minimal test case? I tried with: > > #+begin_src emacs-lisp > (defun hl-test () > (interactive) > (message "OK") > (y-or-n-p "Yes? ")) > > (defvar hl-repeat-map > (let ((map (make-sparse-keymap))) > (define-key map (kbd "r") 'hl-test) > map) > "Keymap to repeat hl-test.") > (put 'hl-test 'repeat-map 'hl-repeat-map) > #+end_src > > Then typing `M-x hl-test RET', and `y r y r y r ...' keeps the loop. Here you go: (defun hl-test () (interactive) (message "OK") (message "result: %s" (y-or-n-p "Yes? "))) (defvar hl-repeat-map (let ((map (make-sparse-keymap))) (define-key map (kbd "n") 'hl-test) ; Note the changed key binding. map) "Keymap to repeat hl-test.") (put 'hl-test 'repeat-map 'hl-repeat-map) To try it: 1. M-x hl-test. 2. Press 'n' a few times. Expected behavior: It alternates between the prompt "Yes? " and message "result: nil". Actual behavior: It enters some sort of recursive state, only showing the prompt. I have to press 'y' a bunch of times to get out of it.