From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#29206: Make xref-show-xrefs-function a defcustom Date: Sun, 19 Nov 2017 01:42:17 +0200 Message-ID: <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> References: <83wp2ngag7.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1511048595 10930 195.159.176.226 (18 Nov 2017 23:43:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Nov 2017 23:43:15 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Thunderbird/57.0 Cc: 29206@debbugs.gnu.org To: Eli Zaretskii , Fritz Stelzer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 19 00:43:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGClO-00026I-0X for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 00:43:06 +0100 Original-Received: from localhost ([::1]:51418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGClT-0002IW-9G for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Nov 2017 18:43:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGClO-0002IR-1l for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2017 18:43:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGClK-0001Bj-4P for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2017 18:43:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37941) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGClK-0001Bb-1E for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2017 18:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGClJ-0006JA-ID for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2017 18:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2017 23:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.151104854824208 (code B ref 29206); Sat, 18 Nov 2017 23:43:01 +0000 Original-Received: (at 29206) by debbugs.gnu.org; 18 Nov 2017 23:42:28 +0000 Original-Received: from localhost ([127.0.0.1]:46622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGCkm-0006IO-FE for submit@debbugs.gnu.org; Sat, 18 Nov 2017 18:42:28 -0500 Original-Received: from mail-wm0-f48.google.com ([74.125.82.48]:46480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGCkk-0006IB-Uj for 29206@debbugs.gnu.org; Sat, 18 Nov 2017 18:42:27 -0500 Original-Received: by mail-wm0-f48.google.com with SMTP id u83so4061456wmb.5 for <29206@debbugs.gnu.org>; Sat, 18 Nov 2017 15:42:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C7/aiovS1TvP9UbsUBD2hRGZ690gX4ae4pPqaXXLiMo=; b=TVnXtYitIVgXM2xdV3Uoq+0tBl0SI8+SHlsl+qxOdmq07aentHDWvbehtsz/4UIqpb px0MRf7OgUwc1bWwjpW7qiU5Kpc8016rf4eOHGi0iQDlR0OHfP6eKYVj6QqNKRTg9p40 3qn9bTAsdPYhOwzeIgB7FHpUEy7Z0eWGX8I3ke2k5+Q9qYmUMwS4nvQOZmxeiF0zS6g9 7MTUicbgg3hTqruEuNucRwiMCNDudCk3vHK4bByTezvi+nQTtby/KSj7EAaGAE8cwHwX dBki01tEbH9HrIZ0MXUCxnKzSrWwH6GZNwMGncCI2sxSl0QpQo5rcESNbo5O6nFhvQMD /c2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C7/aiovS1TvP9UbsUBD2hRGZ690gX4ae4pPqaXXLiMo=; b=g7RhLNncdl4JT+92QguZHrAWpv+Mf2yWzgG4Lrg3sS2d7rcW8AUx2y8Dwjgivwu4Wd qLG71iRlFuR0FD1vxueJX659NJEm3FcPkHPhOgDoiz5JGQKHCrkvp/a/FCl8setdhf0P lwN1peoC3zeoy93xga/OnLCTfpJ0CbBse2s37rYzJero3u0vb+bNKuzqJFYGjQE/0fMb 5N5fhtEP4gIX3xojQBn9N/wUUZXhw3tZtE3h5J1sVL5hkZ9+lQawWwjsMoWrr0pgQ8ws N3fcxuVTd+2Z45bqUFkdDOUc1JsFLrz2axr2vwY3KHGw6b9WBOBr8LRTknqkMjDJ3ZDD STqQ== X-Gm-Message-State: AJaThX40S3U1i1eySBCa4uqB8J5Ixs+IE5vwN3yUtIxSuN7DDN9CemeQ DFx6D0Iz3MilxGyxZJt0YQ4q8nGw X-Google-Smtp-Source: AGs4zMbEUcSW/cldrCLUgWQSwir+yYUim4zLeoxv8msVQ2tPQpO+JQQhdPTN6+PsEwjFsbac39iAOQ== X-Received: by 10.28.13.212 with SMTP id 203mr6923499wmn.141.1511048540844; Sat, 18 Nov 2017 15:42:20 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id k5sm7771238wmg.21.2017.11.18.15.42.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2017 15:42:19 -0800 (PST) In-Reply-To: <83wp2ngag7.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140070 Archived-At: On 11/18/17 12:14 PM, Eli Zaretskii wrote: >> -(defvar xref-show-xrefs-function 'xref--show-xref-buffer >> - "Function to display a list of xrefs.") >> +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer >> + "Function to display a list of xrefs." >> + :type 'function) >> >> (defvar xref--read-identifier-history nil) > > Dmitry, any comments on this? (If accepted, the defcustom should have > a :version tag.) I don't really see the point, yet: we don't offer any alternative functions, and if the user is going to write one, `setq' is just as easy to do. Further, applying this kind of minor change (and finding it important) seems like it would indicate that xref is kind of "stable", which it is not, so far.