From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59807: 29.0.60; [PATCH] python-ts-mode does not auto-complete the closing quote Date: Sun, 04 Dec 2022 09:07:28 +0100 Message-ID: <93762BCF-628D-49EF-B147-54D26AF69410@thornhill.no> References: <83y1rnbpq8.fsf@gnu.org> <7CF63D0F-B80E-446C-9E22-5CA05A4ACA22@gmail.com> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7097"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Kai Ma , 59807@debbugs.gnu.org To: Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 04 09:09:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1k3s-0001gp-P9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Dec 2022 09:09:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1k3c-0000gq-8R; Sun, 04 Dec 2022 03:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1k3b-0000gh-Ft for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 03:09:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1k3b-0006iL-15 for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 03:09:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1k3a-0008UZ-F4 for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 03:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Dec 2022 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59807-submit@debbugs.gnu.org id=B59807.167014132732635 (code B ref 59807); Sun, 04 Dec 2022 08:09:02 +0000 Original-Received: (at 59807) by debbugs.gnu.org; 4 Dec 2022 08:08:47 +0000 Original-Received: from localhost ([127.0.0.1]:56110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1k3L-0008UJ-BT for submit@debbugs.gnu.org; Sun, 04 Dec 2022 03:08:47 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:19274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1k3I-0008UD-Rc for 59807@debbugs.gnu.org; Sun, 04 Dec 2022 03:08:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670141323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ijaMtIHs01Ga+CJdvk9ciBVFP3DSwPCCSkCpkQvMdwM=; b=Rcf8oYknMJXETYjaEE3rp8nBj2XmHUs1/kaA3zYG6eDl3Jyk0/9aCZNaiT+moyCAhPyH5t gc/aJ9HfDJm9nfGtzmDl3ZNSdXEVSyS6eNIvF6is1vLmtNZAdMOj8CHHx6ry5w9LtYrlor M4fiUpZsS5vXsBl/hsevoZCyyE6ww2S+4E/6mQXC3UfsCQZMph01NCsQyfGMwAp6UjA0G1 Oaq3BYhEgDKS7zlZVmEjUIxyWbcxWD2J6z53xa+2zS7bS+MKpsjoxFxZSSrwznq/gopM+/ VXCJKvLxna/Q0MVEwRBrC/leHVblaN5CEEMZqOsGBGQdsRJu3bmkdK25DuxBbA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <7CF63D0F-B80E-446C-9E22-5CA05A4ACA22@gmail.com> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249906 Archived-At: On 4 December 2022 08:28:23 CET, Yuan Fu wrote: > > >> On Dec 3, 2022, at 11:19 PM, Eli Zaretskii wrote: >>=20 >>> From: Kai Ma >>> Date: Sun, 04 Dec 2022 06:27:18 +0800 >>>=20 >>> When electric-pair-mode is enabled, a single quote ' should be auto >>> completed to be '' (which means an empty string)=2E Python-mode corre= ctly >>> does this, but python-ts-mode does not=2E This is clearly a problem >>> regarding the syntax table=2E >>>=20 >>> The attached patch makes python-ts-mode uses the same syntax table as >>> python-mode's, and fixes this problem=2E I also checked a few other t= s >>> modes, and some also have this issue=2E For example, js-ts-mode does = not >>> auto complete '' either, which is also fixed by this patch=2E >>>=20 >>>> From 7f996826bc47bcdd155eb0cc220a48c32cb2619a Mon Sep 17 00:00:00 200= 1 >>> From: Kai Ma >>> Date: Sun, 4 Dec 2022 06:15:42 +0800 >>> Subject: [PATCH] Fix syntax tables of tree-sitter modes >>>=20 >>> Tree-sitter modes should use the same syntax table as the >>> non-tree-sitter ones=2E >>> * lisp/progmodes/csharp-mode=2Eel (csharp-mode-syntax-table) >>> (csharp-mode): >>> * lisp/progmodes/js=2Eel (js-mode-syntax-table) (js-ts-mode): >>> * lisp/progmodes/python=2Eel (python-ts-mode): >>> * lisp/progmodes/sh-script=2Eel (bash-ts-mode): >>> * lisp/textmodes/css-mode=2Eel (css-ts-mode): >>=20 >> Thanks, but please format the log message according to our conventions: >> there should be a description of the actual changes after the last colo= n=2E >>=20 >> Yuan, is it really true that the syntax tables in treesit-supported mod= es >> should be always identical to those of the non-treesit modes? Or maybe >> there could be subtle differences? > >IMO yes=2E But since I=E2=80=99m not the original author of some of the m= odes, I included Theo for his opinion=2E > >Yuan > I agree! Theo