bug#58289: context-menu-mode on multi-head hidpi display

bug#58289: context-menu-mode on multi-head hidpi display

[Ethan Ongstad via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Environment: Two 4k displays, left is vertical right is horizontal. I am up scaling my display by 200% from gnome settings. No configuration, only activated context-menu-mode. Using Gnome on X11.
Bug : On my right display when mouse-down-3- to activate the context menu it will pop-up on the left edge of the display regardless of where I click.
Tested: Works fine on left display. Also works fine if I go to the regular 100% scaling.

bug#58289: context-menu-mode on multi-head hidpi display

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ethan Ongstad <eongstad@icloud.com> writes:

> Environment: Two 4k displays, left is vertical right is horizontal. I
> am up scaling my display by 200% from gnome settings. No
> configuration, only activated context-menu-mode. Using Gnome on X11.
> Bug : On my right display when mouse-down-3- to activate the context
> menu it will pop-up on the left edge of the display regardless of
> where I click.  Tested: Works fine on left display. Also works fine if
> I go to the regular 100% scaling.

Please show the system information output by `report-emacs-bug',
otherwise we cannot determine what toolkit you have built Emacs with.

Thanks.

bug#58289: context-menu-mode on multi-head hidpi display

[Ethan Ongstad via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Setup: two 4k 27" displays, left vertical, right horizontal. Using gnome
42.4 on X11 with 200% upscaling.

Bug:
1. emacs -Q
2. M-x context-menu-mode
3. Go full screen on right display
4. right click anywhere on left half of right display

Outcome: the context menu will only popup on the very most left edge of the
right display. 

Doesn't occur when 100% scaled, when using the left monitor,
or when clicking on the right half of the right display.

In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6)
 of 2022-09-12 built on frederik
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Arch Linux

Configured using:
 'configure --sysconfdir=/etc --prefix=/usr --libexecdir=/usr/lib
 --localstatedir=/var --with-cairo --with-harfbuzz --with-libsystemd
 --with-modules --with-x-toolkit=gtk3 'CFLAGS=-march=x86-64
 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2
 -Wformat -Werror=format-security -fstack-clash-protection
 -fcf-protection -g -ffile-prefix-map=/build/emacs/src=/usr/src/debug
 -flto=auto' 'LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
 -flto=auto''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE
XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  context-menu-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils thingatpt xref project ring cl-loaddefs cl-lib seq
byte-opt gv bytecomp byte-compile cconv cus-start cus-load server
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 62809 9659)
 (symbols 48 8009 1)
 (strings 32 21784 2117)
 (string-bytes 1 686210)
 (vectors 16 15087)
 (vector-slots 8 204718 6920)
 (floats 8 27 37)
 (intervals 56 226 0)
 (buffers 992 11))


> On Oct 4, 2022, at 06:19, Po Lu <luangruo@yahoo.com> wrote:
> 
> Ethan Ongstad <eongstad@icloud.com> writes:
> 
>> Environment: Two 4k displays, left is vertical right is horizontal. I
>> am up scaling my display by 200% from gnome settings. No
>> configuration, only activated context-menu-mode. Using Gnome on X11.
>> Bug : On my right display when mouse-down-3- to activate the context
>> menu it will pop-up on the left edge of the display regardless of
>> where I click.  Tested: Works fine on left display. Also works fine if
>> I go to the regular 100% scaling.
> 
> Please show the system information output by `report-emacs-bug',
> otherwise we cannot determine what toolkit you have built Emacs with.
> 
> Thanks.

bug#58289: context-menu-mode on multi-head hidpi display

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ethan Ongstad <eongstad@icloud.com> writes:

> Setup: two 4k 27" displays, left vertical, right horizontal. Using gnome
> 42.4 on X11 with 200% upscaling.
>
> Bug:
> 1. emacs -Q
> 2. M-x context-menu-mode
> 3. Go full screen on right display
> 4. right click anywhere on left half of right display
>
> Outcome: the context menu will only popup on the very most left edge of the
> right display. 
>
> Doesn't occur when 100% scaled, when using the left monitor,
> or when clicking on the right half of the right display.

Please tell me whether or not this patch resolves the problem:

diff --git a/src/xmenu.c b/src/xmenu.c
index 1452b3c6d1..f972186154 100644
--- a/src/xmenu.c
+++ b/src/xmenu.c
@@ -1430,7 +1430,11 @@ menu_position_func (GtkMenu *menu, gint *x, gint *y, gboolean *push_in, gpointer
      items in x-display-monitor-attributes-list. */
   workarea = call3 (Qframe_monitor_workarea,
                     Qnil,
-                    make_fixnum (data->x),
+#ifdef HAVE_GTK3
+                    make_fixnum (data->x * scale),
+                    make_fixnum (data->y * scale)
+#else
+		    make_fixnum (data->x),
                     make_fixnum (data->y));
 
   if (CONSP (workarea))