From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Date: Tue, 1 Aug 2023 19:29:11 +0200 Message-ID: <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> References: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38254"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64985@debbugs.gnu.org, Philip Kaludercic To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 01 19:30:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qQtCV-0009p8-Kx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Aug 2023 19:30:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQtCF-0004YE-MY; Tue, 01 Aug 2023 13:30:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQtCA-0004Wf-LK for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 13:30:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQtC6-00051Z-TI for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 13:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qQtC6-00054I-I0 for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 13:30:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64985-submit@debbugs.gnu.org id=B64985.169091096219415 (code B ref 64985); Tue, 01 Aug 2023 17:30:02 +0000 Original-Received: (at 64985) by debbugs.gnu.org; 1 Aug 2023 17:29:22 +0000 Original-Received: from localhost ([127.0.0.1]:48279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQtBR-000535-U0 for submit@debbugs.gnu.org; Tue, 01 Aug 2023 13:29:22 -0400 Original-Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:60830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQtBP-00052o-K3 for 64985@debbugs.gnu.org; Tue, 01 Aug 2023 13:29:20 -0400 Original-Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fe28f92d8eso5062873e87.1 for <64985@debbugs.gnu.org>; Tue, 01 Aug 2023 10:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690910953; x=1691515753; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=CT42cQ4OyQ7jorb11unYY9fG6h4QI5/UmtoEtsEnhNQ=; b=TFTUJWeC5KLUSoimMi4xsKngsNkOnvNtpYdwEvxF9Lw0Si3sfusvTQ5shT5KSkyMxT LZdcnCWr0VX4uVGUB+fUPykXbML7aNF2DQAweIitsyZkym+8bKf/8dQ6LU5my99u9rRU UzO3B5AcQknaf0WKAhyQF2iPy4vz5yPj32dqPTuoYRW+LCRiGoNsyr0snAp5A9awwFSm QP64/t03Y5B+l80wQu/1ASEz+ltv+8dMg8xZB7MpNzIs7nhlD3Alb/IlOaHS2HUCCbfc rQZguBPGadU6effrIuDu6MlZ4UDl82Si3VkNvVdh7xUMLe8y0McouU8HQ3rtg1BVxFoR MyLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690910953; x=1691515753; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CT42cQ4OyQ7jorb11unYY9fG6h4QI5/UmtoEtsEnhNQ=; b=RIT/qgsmVOrVLmVvyKz4nZ6EFu0q/JZquSmobpnSF+/K1pvJQtIDbPubM0SRBtxJvx TjLpgYNm2Nfz9KhKtyUtU0L3iiIYUo0nHzRhHC76VCOBUbxsfPDP0b0PBLx52tUDxv3/ KmFko+myABVY1qA2AkO2ly0HXIdwL6kKQJIvVs4ZmQpIZ+q0scvE0XtmszYxzgARIs/d OqwKZufZbwRiw81n7b/I7IL1gDNLCs/FyBR3vv41vOyaxTiKswR05BOkNmL2S2fXavPB 0awb/FWLo+xNtPHGsu4r/RaD0NE4SGbvo851agsvdktHd/vG9m1LvC/wQlYjAqvmpT5b D9Bg== X-Gm-Message-State: ABy/qLZt7m4csFHBsL6wTOeUmTtM3cgqUu+L8CEEUN7ySuiJush+FgN3 xDrv0BxLMUVxVYLU40bg9PQ= X-Google-Smtp-Source: APBJJlHRd14M3HBuHYqldDj5Ya1oPRL+t+N2Eua6CTU+V8rMdMzQt3Y6QJ5cKifzCW/tTK2JTemEAw== X-Received: by 2002:ac2:5a1c:0:b0:4f4:c6ab:f119 with SMTP id q28-20020ac25a1c000000b004f4c6abf119mr2872475lfn.64.1690910952951; Tue, 01 Aug 2023 10:29:12 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm2617275lfn.39.2023.08.01.10.29.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2023 10:29:12 -0700 (PDT) X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266465 Archived-At: >> There might be another way to do this, e.g. so that we could optimize=20= >> the regexp, but I'm not sure if Emacs has anything to optimize a list = of=20 >> *regexp* alternatives (rather than a list of *string* alternatives). = I=20 >> tested out 'rx' too, but no luck there either. This seemed like the = best=20 >> I could do without more extensive changes, which I wanted to avoid = for=20 >> the 29 branch. >>=20 > Note: 'rx' (well, 'rx-to-string') would work here too, but it didn't=20= > optimize the list of regexp alternatives, and I found the code to be=20= > harder to read (though I could just be doing it in a clumsy way). rx doesn't attempt to left-factorise disjunctive patterns unless they = are all literal strings or characters. I have considered a = generalisation, but it would be done on the rx level and so wouldn't = solve your immediate problem here. An alternative would be to match against (mapconcat #'identity byte-compile-ignore-files "\\|") ...)