unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 64985@debbugs.gnu.org, Philip Kaludercic <philipk@posteo.net>
Subject: bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards
Date: Tue, 1 Aug 2023 19:29:11 +0200	[thread overview]
Message-ID: <931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com> (raw)
In-Reply-To: <8e555eb8-529d-d11c-66c7-bd16f5d45be7@gmail.com>

>> There might be another way to do this, e.g. so that we could optimize 
>> the regexp, but I'm not sure if Emacs has anything to optimize a list of 
>> *regexp* alternatives (rather than a list of *string* alternatives). I 
>> tested out 'rx' too, but no luck there either. This seemed like the best 
>> I could do without more extensive changes, which I wanted to avoid for 
>> the 29 branch.
>> 
> Note: 'rx' (well, 'rx-to-string') would work here too, but it didn't 
> optimize the list of regexp alternatives, and I found the code to be 
> harder to read (though I could just be doing it in a clumsy way).

rx doesn't attempt to left-factorise disjunctive patterns unless they are all literal strings or characters. I have considered a generalisation, but it would be done on the rx level and so wouldn't solve your immediate problem here.

An alternative would be to match against

(mapconcat #'identity byte-compile-ignore-files "\\|") ...)







  parent reply	other threads:[~2023-08-01 17:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01  6:20 bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Jim Porter
2023-08-01 11:21 ` Eli Zaretskii
2023-08-01 19:22   ` Jim Porter
2023-08-01 12:20 ` Philip Kaludercic
2023-08-01 16:10   ` Jim Porter
2023-08-01 16:18     ` Jim Porter
2023-08-01 17:29 ` Mattias Engdegård [this message]
2023-08-01 18:10   ` Jim Porter
2023-08-01 18:32     ` Philip Kaludercic
2023-08-01 19:18       ` Jim Porter
2023-08-01 19:21         ` Philip Kaludercic
2023-08-02 18:08           ` Jim Porter
2023-08-04 19:37 ` bug#64985: 30.0.50; package-recompile-all and package-recompile do not recompile anything, seems related to the patch associated with bug #64985 Vincenzo Pupillo
2023-08-04 20:05   ` Jim Porter
2023-08-05 17:12 ` Mattias Engdegård
2023-08-05 17:16   ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=931A378C-454C-442C-9551-9A0905F1CBFC@gmail.com \
    --to=mattias.engdegard@gmail.com \
    --cc=64985@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).