From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing Date: Wed, 2 Oct 2019 10:54:03 +0200 Message-ID: <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60212"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37563@debbugs.gnu.org To: Ingo Lohmar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 02 10:58:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFaST-000FWS-TL for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Oct 2019 10:58:06 +0200 Original-Received: from localhost ([::1]:52644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFaSS-0001T6-Hb for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Oct 2019 04:58:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41239) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFaPZ-0000NT-DY for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 04:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFaPX-0004dt-HX for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 04:55:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFaPX-0004dj-Dl for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 04:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFaPX-0007IF-BH for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 04:55:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Oct 2019 08:55:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37563 X-GNU-PR-Package: emacs Original-Received: via spool by 37563-submit@debbugs.gnu.org id=B37563.157000645227920 (code B ref 37563); Wed, 02 Oct 2019 08:55:03 +0000 Original-Received: (at 37563) by debbugs.gnu.org; 2 Oct 2019 08:54:12 +0000 Original-Received: from localhost ([127.0.0.1]:35330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFaOi-0007GG-4X for submit@debbugs.gnu.org; Wed, 02 Oct 2019 04:54:12 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:33693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFaOh-0007G3-4D for 37563@debbugs.gnu.org; Wed, 02 Oct 2019 04:54:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570006442; bh=4fnc3ALsgPJezyWSVRwO5/0MnCtwF9UGE4rOcjp4UAw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=bn3titZgdPDmpt+bVobGjnibtVjXpJvKV/Hhvoo3eLTc3TuuR5sO/bWXntZnJpDj1 FkLpZ6TDckzPmJAWgMr6lSkNeXtfNATy0j28JZ7L6cicsstTl2cGld9j/BaL0b+CV3 UJVVcQd06AbflyNwQgs7dkFvmuhh+39vbY5iUUuM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.203]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7i8Y-1i2zSC2p50-014ij8; Wed, 02 Oct 2019 10:54:02 +0200 In-Reply-To: <87d0fgamzj.fsf@kenko.localhost.com> Content-Language: de-AT X-Provags-ID: V03:K1:JUcjH/0g9JDZcYngXWpHNkjKSWAXMIvqjSRHUzcp1kVdKoi+YzA PlTWPP61l5aqx45fYXMLbXUpoH1HcdgOSXnoJi4ERTXXeHxcY+IhRz7LBUK1tGNHF8QupjM XOKnfvn2SMoQFrMp7DReDHAU4gyo1asOhlBVpyYL1k8r3shMTD6r+zEr4c8dhjLJ8NSqWX8 eWCcvj6KPjjTlHaDNxyQQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:l9zsel5TgBc=:60Hv917MzyoTPS2OBqH8/E XWwFTLKcUyuQ6f4Y0Ds4sWwSvzLkUxQNC2sSWYnWQ5ZV6+ozShQ23ioP0Hc9o9+18X06lwmuA Ngw9yFkehVB5CXbAXM6fAlQ/jSEOK0Gs5Vc9Sr1ImQScrlKllxz8q353/q9mJxy0ZlDY7oJLm Q4UIFkz8RdrHIyz7LEzAb7lCN6cMJmcfnIlLvXpQV0L3Z3EN7aEiDYghH8R5BHWxgQ21v+FCg SaPES5ExME9myVSrMLsYb1RvzXDW9rPVmMWQClZDYwhnahzq6x7kgqKvDdKrGqU2vsqCYl+Vh lYq5kFzW37PJlYFA55Ra+vjq1fJGSMlwjNUUk+xxyT4EG+TznJvH1uM+0ozGCfN6qhWVpi03x pYR/SW1O8tndr9KjIE8r0RQA9PW855R/8lc4nrLn9mnlwx0M1k6kVWgP+ArX1taHSC2zPS56P N+N9TsHODDqEUiQShFOF6SCqBwb03Z7U1MWUbSt7Gy5/A+t0ZxdPyJelTV0OVUAwboBdNvGw5 /En4ZSW+FeoKdsewu6N3w95HJ3Esc95HR2C5X9AxbG/zWGbAeBOVKfGsnBkaGcTV8g2iWXhx3 UtjalOGmknDcGFkW1yHtEC+QThpA0+ngvyYBYyKjVAyGKCt3gM42m7gX/p+CYjPmt4M3/roue x85zZm7xkZ/pHP9o4pLZ8EpTHYc9YPGvpmDxn7iDJaVf1aSjKtSpbinWFYFQ/rgXevrOntcQL davfiLCGChd+dOODV/vNi5gh+MEXcTIY7hm+jaiG4xo/xzP0XYEcTI+HOBt5bxMMe56khZX3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168120 Archived-At: > I surely find the complexity of all this code jarring, so I have to > restrict myself to looking at a single issue; and here, it's clearly > fixing a bug, using the char height is simply wrong, IMO. Agreed. But if I change 'fit-frame-to-buffer', then, for consistency, I have to at least change 'fit-window-to-buffer' too. > + (setq height (* (/ (+ height line-height -1) line-height) > + line-height))) [...] > And then char-height can be dropped. Right. Thanks, martin