From: Paul Eggert <eggert@cs.ucla.edu>
To: Daniel Vianna <dmlvianna@gmail.com>
Cc: 33803@debbugs.gnu.org
Subject: bug#33803: gomoku demotivational messages
Date: Thu, 27 Dec 2018 21:59:21 -0800 [thread overview]
Message-ID: <92d44e37-a1f6-4fd3-d19a-8e6b5490c075@cs.ucla.edu> (raw)
In-Reply-To: <CAMLJ+NFwFOvdcxTtP06W5KtEhUaB25kUdwuGxP6OyM0JiC=VfA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
Thanks for the bug report. I installed into the master branch the attached
patch, which I hope prevents similar problems in the future. I didn't implement
a move-counter; perhaps someone else can volunteer to do that, if they have the
time.
[-- Attachment #2: 0001-Improve-motivations-in-gomoku-messages.patch --]
[-- Type: text/x-patch, Size: 3401 bytes --]
From 8167316fd6406adbeb8fe91db9ee59e2f47bddb0 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 27 Dec 2018 21:55:01 -0800
Subject: [PATCH] Improve motivations in gomoku messages
* lisp/play/gomoku.el (gomoku-terminate-game):
Don't make six-year-old children cry (Bug#33803).
---
lisp/play/gomoku.el | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/lisp/play/gomoku.el b/lisp/play/gomoku.el
index 6ce2750f86..32b29b70f4 100644
--- a/lisp/play/gomoku.el
+++ b/lisp/play/gomoku.el
@@ -656,48 +656,48 @@ gomoku-terminate-game
((eq result 'emacs-won)
(setq gomoku-number-of-emacs-wins (1+ gomoku-number-of-emacs-wins))
(cond ((< gomoku-number-of-moves 20)
- "This was a REALLY QUICK win.")
+ "I won... I hope you like the game as you get better.")
(gomoku-human-refused-draw
"I won... Too bad you refused my offer of a draw!")
(gomoku-human-took-back
- "I won... Taking moves back will not help you!")
+ "I won... It's OK to take back more moves next time.")
((not gomoku-emacs-played-first)
- "I won... Playing first did not help you much!")
+ "I won... Use C-c C-b to take back a move on second thought.")
((and (zerop gomoku-number-of-human-wins)
(zerop gomoku-number-of-draws)
(> gomoku-number-of-emacs-wins 1))
- "I'm becoming tired of winning...")
+ "I won... It might be time take a break before trying again.")
("I won.")))
((eq result 'human-won)
(setq gomoku-number-of-human-wins (1+ gomoku-number-of-human-wins))
(concat "OK, you won this one."
(cond
(gomoku-human-took-back
- " I, for one, never take my moves back...")
+ " For a bigger challenge, play without taking moves back.")
(gomoku-emacs-played-first
- ".. so what?")
- (" Now, let me play first just once."))))
+ " Congratulations!")
+ (" For a bigger challenge, let me play first."))))
((eq result 'human-resigned)
(setq gomoku-number-of-emacs-wins (1+ gomoku-number-of-emacs-wins))
- "So you resign. That's just one more win for me.")
+ "I see that you resigned. Better luck next time.")
((eq result 'nobody-won)
(setq gomoku-number-of-draws (1+ gomoku-number-of-draws))
(concat "This is a draw. "
(cond
(gomoku-human-took-back
- "I, for one, never take my moves back...")
+ " For a bigger challenge, try without taking moves back.")
(gomoku-emacs-played-first
- "Just chance, I guess.")
- ("Now, let me play first just once."))))
+ "Wow, that was a long game. We both played well.")
+ (" For a bigger challenge, let me play first."))))
((eq result 'draw-agreed)
(setq gomoku-number-of-draws (1+ gomoku-number-of-draws))
(concat "Draw agreed. "
(cond
(gomoku-human-took-back
- "I, for one, never take my moves back...")
+ " For a bigger challenge, try without taking moves back.")
(gomoku-emacs-played-first
- "You were lucky.")
- ("Now, let me play first just once."))))
+ "Good game.")
+ (" For a bigger challenge, let me play first."))))
((eq result 'crash-game)
"Sorry, I have been interrupted and cannot resume that game...")))
(gomoku-display-statistics)
--
2.17.1
next prev parent reply other threads:[~2018-12-28 5:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 7:52 bug#33803: gomoku demotivational messages Daniel Vianna
2018-12-19 15:13 ` Eli Zaretskii
[not found] ` <CAMLJ+NEpw=XL0qJH1UJD6W5JJ436opwRKbNSFTB-Jqu9mXBN7A@mail.gmail.com>
2018-12-22 9:29 ` Eli Zaretskii
2018-12-19 15:17 ` Francesco Potortì
2018-12-22 14:09 ` Douglas Lewan
2018-12-28 5:59 ` Paul Eggert [this message]
2018-12-28 7:38 ` Daniel Vianna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92d44e37-a1f6-4fd3-d19a-8e6b5490c075@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=33803@debbugs.gnu.org \
--cc=dmlvianna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).