From: Yves Baumes <ybaumes@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 12444-done@debbugs.gnu.org, schwab@linux-m68k.org
Subject: bug#12444: Emacs, a segmentation fault occurs when saving a file on a NFS partition.
Date: Fri, 14 Sep 2012 19:56:08 +0200 [thread overview]
Message-ID: <92F40F37-0E30-4AF1-A92B-ECB508A39C1B@gmail.com> (raw)
In-Reply-To: <83y5kctu38.fsf@gnu.org>
Thank you. :-)
Le 14 sept. 2012 à 19:03, Eli Zaretskii a écrit :
>> From: Yves Baumes <ybaumes@gmail.com>
>> Date: Fri, 14 Sep 2012 18:55:45 +0200
>> Cc: 12444-done@debbugs.gnu.org
>>
>> the bug occurred with emacs-24.2, fetch from the gnu's ftp. Do you mean it is fixed on the cvs repository?
>
> In bzr, not in CVS. Here's the patch committed by Andreas:
>
> === modified file 'src/ChangeLog'
> --- src/ChangeLog 2012-09-12 17:18:33 +0000
> +++ src/ChangeLog 2012-09-14 16:35:25 +0000
> @@ -1,3 +1,9 @@
> +2012-09-14 Andreas Schwab <schwab@linux-m68k.org>
> +
> + * fileio.c (Ffile_selinux_context): Only call freecon when
> + lgetfilecon succeeded.
> + (Fset_file_selinux_context): Likewise. (Bug#12444)
> +
> 2012-09-12 Eli Zaretskii <eliz@gnu.org>
>
> * xdisp.c (try_window_reusing_current_matrix): Under bidi
>
> === modified file 'src/fileio.c'
> --- src/fileio.c 2012-07-14 10:46:56 +0000
> +++ src/fileio.c 2012-09-14 16:35:25 +0000
> @@ -2841,9 +2841,8 @@ or if SELinux is disabled, or if Emacs l
> if (context_range_get (context))
> values[3] = build_string (context_range_get (context));
> context_free (context);
> + freecon (con);
> }
> - if (con)
> - freecon (con);
> }
> #endif
>
> @@ -2920,12 +2919,10 @@ compiled with SELinux support. */)
> report_file_error ("Doing lsetfilecon", Fcons (absname, Qnil));
>
> context_free (parsed_con);
> + freecon (con);
> }
> else
> report_file_error ("Doing lgetfilecon", Fcons (absname, Qnil));
> -
> - if (con)
> - freecon (con);
> }
> #endif
>
>
prev parent reply other threads:[~2012-09-14 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 15:54 bug#12444: Emacs, a segmentation fault occurs when saving a file on a NFS partition Yves Baumes
2012-09-14 16:38 ` Andreas Schwab
2012-09-14 16:55 ` Yves Baumes
2012-09-14 17:03 ` Eli Zaretskii
2012-09-14 17:56 ` Yves Baumes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92F40F37-0E30-4AF1-A92B-ECB508A39C1B@gmail.com \
--to=ybaumes@gmail.com \
--cc=12444-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).